From f38c1af7babde44ba5f8325042482142a3cff1ae Mon Sep 17 00:00:00 2001
From: "Bharat Devnani (OpenERP)" <bde@tinyerp.com>
Date: Fri, 8 Jun 2012 17:26:39 +0530
Subject: [PATCH 1/2] [ADD] added separator, onchange methods and tooltip in
 Accounting configuration

bzr revid: bde@tinyerp.com-20120608115639-6z2jk2qvwuuvmr5s
---
 addons/account/res_config.py        | 4 ++--
 addons/account/res_config_view.xml  | 5 +++--
 addons/purchase/res_config.py       | 8 ++++++++
 addons/purchase/res_config_view.xml | 2 +-
 addons/sale/res_config.py           | 8 ++++++++
 addons/sale/res_config_view.xml     | 2 +-
 6 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/addons/account/res_config.py b/addons/account/res_config.py
index 583b769d315..9b77ae77733 100644
--- a/addons/account/res_config.py
+++ b/addons/account/res_config.py
@@ -111,8 +111,8 @@ class account_config_settings(osv.osv_memory):
         'group_proforma_invoices': fields.boolean('Allow Pro-forma Invoices',
             implied_group='account.group_proforma_invoices',
             help="Allows you to put invoices in pro-forma state."),
-        'default_sale_tax': fields.many2one('account.tax', 'Default Sale Tax'),
-        'default_purchase_tax': fields.many2one('account.tax', 'Default Purchase Tax'),
+        'default_sale_tax': fields.many2one('account.tax', 'Default Sale Tax', help="Selected tax will be applied by default to Product's Sale Tax, while creating a new product"),
+        'default_purchase_tax': fields.many2one('account.tax', 'Default Purchase Tax', help="Selected tax will be applied by default to Product's Purchase Tax, while creating a new product"),
         'decimal_precision': fields.integer('Decimal Precision',
             help="""Set the decimal precision for rounding results in accounting."""),
     }
diff --git a/addons/account/res_config_view.xml b/addons/account/res_config_view.xml
index 41a0b121735..8d49cb856e3 100644
--- a/addons/account/res_config_view.xml
+++ b/addons/account/res_config_view.xml
@@ -21,9 +21,10 @@
                         <button string="Cancel" special="cancel"/>
                     </header>
                     <sheet layout="auto">
-                        <field name="has_default_company" invisible="1" />
+                        <separator string="Accounting Details of Company" colspan="4"/>
+                        <field name="has_default_company" invisible="1"/>
                         <field name="has_chart_of_accounts" invisible="1"/>
-                        <field name="company_id" widget="selection" on_change="onchange_company_id(company_id)"
+                        <field name="company_id" groups="base.group_multi_company" widget="selection" on_change="onchange_company_id(company_id)"
                             attrs="{'invisible': [('has_default_company', '=', True)]}"/>
                         <field name="expects_chart_of_accounts"/>
 
diff --git a/addons/purchase/res_config.py b/addons/purchase/res_config.py
index d4baa2d6099..243399bd2e0 100644
--- a/addons/purchase/res_config.py
+++ b/addons/purchase/res_config.py
@@ -89,5 +89,13 @@ class account_config_settings(osv.osv_memory):
             implied_group='purchase.group_analytic_accounting',
             help="Allows you to specify an analytic account on purchase orders."),
     }
+    
+    def onchange_purchase_analytic_plans(self, cr, uid, ids, module_purchase_analytic_plans, context=None):
+        res = {}
+        if module_purchase_analytic_plans:
+            res['value'] = {'group_analytic_account_for_purchases': True}
+        else:
+            res['value'] = {'group_analytic_account_for_purchases': False}
+        return res
 
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
diff --git a/addons/purchase/res_config_view.xml b/addons/purchase/res_config_view.xml
index 575863fddc4..d0548c2c96f 100644
--- a/addons/purchase/res_config_view.xml
+++ b/addons/purchase/res_config_view.xml
@@ -54,7 +54,7 @@
                 </group>
                 <group name="analytic_accounting" position="inside">
                     <field name="group_analytic_account_for_purchases"/>
-                    <field name="module_purchase_analytic_plans"/>
+                    <field name="module_purchase_analytic_plans" on_change="onchange_purchase_analytic_plans(module_purchase_analytic_plans)"/>
                 </group>
             </field>
         </record>
diff --git a/addons/sale/res_config.py b/addons/sale/res_config.py
index 1007107f1a0..f6e3763f25c 100644
--- a/addons/sale/res_config.py
+++ b/addons/sale/res_config.py
@@ -190,5 +190,13 @@ class account_config_settings(osv.osv_memory):
             implied_group='sale.group_analytic_accounting',
             help="Allows you to specify an analytic account on sale orders."),
     }
+    
+    def onchange_sale_analytic_plans(self, cr, uid, ids, module_sale_analytic_plans, context=None):
+        res = {}
+        if module_sale_analytic_plans:
+            res['value'] = {'group_analytic_account_for_sales': True}
+        else:
+            res['value'] = {'group_analytic_account_for_sales': False}
+        return res
 
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
diff --git a/addons/sale/res_config_view.xml b/addons/sale/res_config_view.xml
index fa8aa2baa8e..c633ee4165e 100644
--- a/addons/sale/res_config_view.xml
+++ b/addons/sale/res_config_view.xml
@@ -60,7 +60,7 @@
                 </group>
                 <group name="analytic_accounting" position="inside">
                     <field name="group_analytic_account_for_sales"/>
-                    <field name="module_sale_analytic_plans"/>
+                    <field name="module_sale_analytic_plans" on_change="onchange_sale_analytic_plans(module_sale_analytic_plans)"/>
                 </group>
             </field>
         </record>

From a46b5cfeab0990cdea1e264b65b12a2bb65b8b7d Mon Sep 17 00:00:00 2001
From: "Bharat Devnani (OpenERP)" <bde@tinyerp.com>
Date: Mon, 11 Jun 2012 13:08:09 +0530
Subject: [PATCH 2/2] [ADD] added group tag inorder to make strings of fields
 visible

bzr revid: bde@tinyerp.com-20120611073809-fj87yjaz96uxcw2c
---
 addons/account/res_config_view.xml | 180 +++++++++++++++--------------
 1 file changed, 92 insertions(+), 88 deletions(-)

diff --git a/addons/account/res_config_view.xml b/addons/account/res_config_view.xml
index a5e8b277cc3..f14bb0a5c8a 100644
--- a/addons/account/res_config_view.xml
+++ b/addons/account/res_config_view.xml
@@ -21,102 +21,106 @@
                         <button string="Cancel" special="cancel"/>
                     </header>
                     <sheet layout="auto">
-                        <separator string="Accounting Details of Company" colspan="4"/>
-                        <field name="has_default_company" invisible="1"/>
-                        <field name="has_chart_of_accounts" invisible="1"/>
-                        <field name="company_id" groups="base.group_multi_company" widget="selection" on_change="onchange_company_id(company_id)"
-                            attrs="{'invisible': [('has_default_company', '=', True)]}"/>
-                        <field name="expects_chart_of_accounts"/>
+                        <group>
+                            <separator string="Accounting Details of Company" colspan="4"/>
+                            <field name="has_default_company" invisible="1"/>
+                            <field name="has_chart_of_accounts" invisible="1"/>
+                            <field name="company_id" groups="base.group_multi_company" widget="selection" on_change="onchange_company_id(company_id)"
+                                attrs="{'invisible': [('has_default_company', '=', True)]}"/>
+                            <field name="expects_chart_of_accounts"/>
+                        
 
-                        <group string="No Chart of Accounts exists for this Company" colspan="4" attrs="{'invisible': ['|', ('expects_chart_of_accounts','=',False), ('has_chart_of_accounts','=',True)]}">
-                            <label string="Please select a chart template to install a chart of accounts." colspan="4"/>
-                            <field name="chart_template_id" widget="selection" on_change="onchange_chart_template_id(chart_template_id)" domain="[('visible','=', True)]"/>
-                            <button string="Install More Chart Templates" icon="gtk-go-forward"
-                                name="%(open_account_charts_modules)d" type="action"/>
-                            <newline/>
-                            <field name ="code_digits" groups="account.group_account_user"/>
-                            <field name ="seq_journal"/>
-                            <newline/>
-                            <field name ="complete_tax_set" invisible="1"/>
-                            <field name="sale_tax" attrs="{'invisible': ['|', ('chart_template_id','=',False), ('complete_tax_set','=',False)]}"
-                                domain="[('chart_template_id', '=', chart_template_id),('parent_id','=',False),('type_tax_use','in',('sale','all'))]"/>
-                            <field name="purchase_tax" attrs="{'invisible': ['|', ('chart_template_id','=',False), ('complete_tax_set','=',False)]}"
-                                domain="[('chart_template_id', '=', chart_template_id),('parent_id','=',False),('type_tax_use','in',('purchase', 'all'))]"/>
-                            <field name ="sale_tax_rate" attrs="{'invisible': ['|', ('chart_template_id','=',False), ('complete_tax_set','=',True)]}" on_change="onchange_tax_rate(sale_tax_rate)"/>
-                            <field name ="purchase_tax_rate" attrs="{'invisible': ['|', ('chart_template_id','=',False), ('complete_tax_set','=',True)]}"/>
-                        </group>
-
-                        <field name="has_fiscal_year" invisible="1"/>
-                        <group string="No Fiscal Year exists for this Company" colspan="4" attrs="{'invisible': ['|', ('expects_chart_of_accounts','=',False), ('has_fiscal_year','=',True)]}">
-                            <field name="date_start" on_change="onchange_start_date(date_start)"/>
-                            <field name="date_stop"/>
-                            <field name="period" colspan="4"/>
-                        </group>
-
-                        <group colspan="4">
-                            <separator string="Accounting Configuration" colspan="4"/>
-                            <field name ="complete_tax_set" invisible="1"/>
-                            <newline/>
-                            <group colspan="" col="2">
-                                <field name="default_sale_tax" domain="[('type_tax_use','=','sale'), ('company_id','=',company_id)]" attrs="{'invisible': [('has_chart_of_accounts','=',False)]}"/>
-                                <field name="module_account_accountant"/>
-                                <field name="module_account_asset"/>
+                            <group string="No Chart of Accounts exists for this Company" colspan="4" attrs="{'invisible': ['|', ('expects_chart_of_accounts','=',False), ('has_chart_of_accounts','=',True)]}">
+                                <label string="Please select a chart template to install a chart of accounts." colspan="4"/>
+                                <field name="chart_template_id" widget="selection" on_change="onchange_chart_template_id(chart_template_id)" domain="[('visible','=', True)]"/>
+                                <button string="Install More Chart Templates" icon="gtk-go-forward"
+                                    name="%(open_account_charts_modules)d" type="action"/>
+                                <newline/>
+                                <field name ="code_digits" groups="account.group_account_user"/>
+                                <field name ="seq_journal"/>
+                                <newline/>
+                                <field name ="complete_tax_set" invisible="1"/>
+                                <field name="sale_tax" attrs="{'invisible': ['|', ('chart_template_id','=',False), ('complete_tax_set','=',False)]}"
+                                    domain="[('chart_template_id', '=', chart_template_id),('parent_id','=',False),('type_tax_use','in',('sale','all'))]"/>
+                                <field name="purchase_tax" attrs="{'invisible': ['|', ('chart_template_id','=',False), ('complete_tax_set','=',False)]}"
+                                    domain="[('chart_template_id', '=', chart_template_id),('parent_id','=',False),('type_tax_use','in',('purchase', 'all'))]"/>
+                                <field name ="sale_tax_rate" attrs="{'invisible': ['|', ('chart_template_id','=',False), ('complete_tax_set','=',True)]}" on_change="onchange_tax_rate(sale_tax_rate)"/>
+                                <field name ="purchase_tax_rate" attrs="{'invisible': ['|', ('chart_template_id','=',False), ('complete_tax_set','=',True)]}"/>
+                            </group>
+                            
+                            <field name="has_fiscal_year" invisible="1"/>
+                            
+                            <group string="No Fiscal Year exists for this Company" colspan="4" attrs="{'invisible': ['|', ('expects_chart_of_accounts','=',False), ('has_fiscal_year','=',True)]}">
+                                <field name="date_start" on_change="onchange_start_date(date_start)"/>
+                                <field name="date_stop"/>
+                                <field name="period" colspan="4"/>
+                            </group>
+    
+                            <group colspan="4">
+                                <separator string="Accounting Configuration" colspan="4"/>
+                                <field name ="complete_tax_set" invisible="1"/>
+                                <newline/>
+                                <group colspan="" col="2">
+                                    <field name="default_sale_tax" domain="[('type_tax_use','=','sale'), ('company_id','=',company_id)]" attrs="{'invisible': [('has_chart_of_accounts','=',False)]}"/>
+                                    <field name="module_account_accountant"/>
+                                    <field name="module_account_asset"/>
+                                </group>
+                                <group colspan="2" col="2">
+                                    <field name="default_purchase_tax" domain="[('type_tax_use','=','purchase'), ('company_id','=',company_id)]" attrs="{'invisible': [('has_chart_of_accounts','=',False)]}"/>
+                                    <field name="currency_id" widget="selection"/>
+                                    <field name="module_account_budget"/>
+                                    <field name="decimal_precision"/>
+                                </group>
                             </group>
                             <group colspan="2" col="2">
-                                <field name="default_purchase_tax" domain="[('type_tax_use','=','purchase'), ('company_id','=',company_id)]" attrs="{'invisible': [('has_chart_of_accounts','=',False)]}"/>
-                                <field name="currency_id" widget="selection"/>
-                                <field name="module_account_budget"/>
-                                <field name="decimal_precision"/>
+                                <separator string="Customer Invoices" colspan="2"/>
+                                <field name="sale_journal_id" invisible="1"/>
+                                <label string="Next Invoice Number" for="sale_sequence_prefix" help='If you put "%%(year)s" in the prefix, it will be replaced by the current year.'/>
+                                <group colspan="1" col="2">
+                                    <field name="sale_sequence_prefix" nolabel="1"/>
+                                    <field name="sale_sequence_next" nolabel="1" attrs="{'readonly': [('sale_journal_id','=',False)]}"/>
+                                </group>
+                                <field name="sale_refund_journal_id" invisible="1"/>
+                                <label string="Next Credit Note Number" for="sale_refund_sequence_prefix" help='If you put "%%(year)s" in the prefix, it will be replaced by the current year.'/>
+                                <group colspan="1" col="2">
+                                    <field name="sale_refund_sequence_prefix" nolabel="1"/>
+                                    <field name="sale_refund_sequence_next" nolabel="1" attrs="{'readonly': [('sale_refund_journal_id','=',False)]}"/>
+                                </group>
+                                <field name="module_account_invoice_layout"/>
+                                <field name="module_account_voucher"/>
+                                <field name="module_account_followup"/>
+                                <field name="group_proforma_invoices"/>
                             </group>
-                        </group>
-                        <group colspan="2" col="2">
-                            <separator string="Customer Invoices" colspan="2"/>
-                            <field name="sale_journal_id" invisible="1"/>
-                            <label string="Next Invoice Number" for="sale_sequence_prefix" help='If you put "%%(year)s" in the prefix, it will be replaced by the current year.'/>
-                            <group colspan="1" col="2">
-                                <field name="sale_sequence_prefix" nolabel="1"/>
-                                <field name="sale_sequence_next" nolabel="1" attrs="{'readonly': [('sale_journal_id','=',False)]}"/>
+                            <group colspan="2" col="2">
+                                <separator string="Supplier Invoices" colspan="2"/>
+                                <field name="purchase_journal_id" invisible="1"/>
+                                <label string="Next Supplier Invoice Number" for="purchase_sequence_prefix" help='If you put "%%(year)s" in the prefix, it will be replaced by the current year.'/>
+                                <group colspan="1" col="2">
+                                    <field name="purchase_sequence_prefix" nolabel="1"/>
+                                    <field name="purchase_sequence_next" nolabel="1" attrs="{'readonly': [('purchase_journal_id','=',False)]}"/>
+                                </group>
+                                <field name="purchase_refund_journal_id" invisible="1"/>
+                                <label string="Next Supplier Credit Note Number" for="purchase_refund_sequence_prefix" help='If you put "%%(year)s" in the prefix, it will be replaced by the current year.'/>
+                                <group colspan="1" col="2">
+                                    <field name="purchase_refund_sequence_prefix" nolabel="1"/>
+                                    <field name="purchase_refund_sequence_next" nolabel="1" attrs="{'readonly': [('purchase_refund_journal_id','=',False)]}"/>
+                                </group>
+                                <field name="module_account_payment"/>
                             </group>
-                            <field name="sale_refund_journal_id" invisible="1"/>
-                            <label string="Next Credit Note Number" for="sale_refund_sequence_prefix" help='If you put "%%(year)s" in the prefix, it will be replaced by the current year.'/>
-                            <group colspan="1" col="2">
-                                <field name="sale_refund_sequence_prefix" nolabel="1"/>
-                                <field name="sale_refund_sequence_next" nolabel="1" attrs="{'readonly': [('sale_refund_journal_id','=',False)]}"/>
+                            <group colspan="2" col="2">
+                                <separator string="Electronic Payments" colspan="2"/>
+                                <field name="paypal_account"/>
                             </group>
-                            <field name="module_account_invoice_layout"/>
-                            <field name="module_account_voucher"/>
-                            <field name="module_account_followup"/>
-                            <field name="group_proforma_invoices"/>
-                        </group>
-                        <group colspan="2" col="2">
-                            <separator string="Supplier Invoices" colspan="2"/>
-                            <field name="purchase_journal_id" invisible="1"/>
-                            <label string="Next Supplier Invoice Number" for="purchase_sequence_prefix" help='If you put "%%(year)s" in the prefix, it will be replaced by the current year.'/>
-                            <group colspan="1" col="2">
-                                <field name="purchase_sequence_prefix" nolabel="1"/>
-                                <field name="purchase_sequence_next" nolabel="1" attrs="{'readonly': [('purchase_journal_id','=',False)]}"/>
+                            <group colspan="2" col="2">
+                                <separator string="Bank &amp; Cash" colspan="2"/>
+                                <b><label string="Configure Bank Accounts :"/></b>
+                                <button name="%(action_bank_tree)d" string="Configure Bank Accounts" icon="gtk-go-forward" type="action"/>
+                                <field name="company_footer"/>
+                                <field name="module_account_check_writing"/>
                             </group>
-                            <field name="purchase_refund_journal_id" invisible="1"/>
-                            <label string="Next Supplier Credit Note Number" for="purchase_refund_sequence_prefix" help='If you put "%%(year)s" in the prefix, it will be replaced by the current year.'/>
-                            <group colspan="1" col="2">
-                                <field name="purchase_refund_sequence_prefix" nolabel="1"/>
-                                <field name="purchase_refund_sequence_next" nolabel="1" attrs="{'readonly': [('purchase_refund_journal_id','=',False)]}"/>
+                            <group name="analytic_accounting" colspan="4" invisible="1">
+                                <separator string="Analytic Accounting" colspan="4"/>
                             </group>
-                            <field name="module_account_payment"/>
-                        </group>
-                        <group colspan="2" col="2">
-                            <separator string="Electronic Payments" colspan="2"/>
-                            <field name="paypal_account"/>
-                        </group>
-                        <group colspan="2" col="2">
-                            <separator string="Bank &amp; Cash" colspan="2"/>
-                            <b><label string="Configure Bank Accounts :"/></b>
-                            <button name="%(action_bank_tree)d" string="Configure Bank Accounts" icon="gtk-go-forward" type="action"/>
-                            <field name="company_footer"/>
-                            <field name="module_account_check_writing"/>
-                        </group>
-                        <group name="analytic_accounting" colspan="4" invisible="1">
-                            <separator string="Analytic Accounting" colspan="4"/>
                         </group>
                     </sheet>
                 </form>