From 6a9b29ec9aba37c25534f7effd53ebddeeb8aed2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexandre=20K=C3=BChn?= <aku@odoo.com>
Date: Thu, 9 Jan 2020 16:14:45 +0000
Subject: [PATCH] [FIX] mail:tests: no crash on intercepted crosstab heartbeat

The test may fail non-deterministically from intercepting an
heartbeat in the local storage. Only a document thread window fold
state change from the local storage should be intercepted.

Closes #43072
---
 .../static/tests/document_thread_window_tests.js  | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/addons/mail/static/tests/document_thread_window_tests.js b/addons/mail/static/tests/document_thread_window_tests.js
index 0748168a0cb..d10f32c1e89 100644
--- a/addons/mail/static/tests/document_thread_window_tests.js
+++ b/addons/mail/static/tests/document_thread_window_tests.js
@@ -227,7 +227,7 @@ QUnit.test('post messages in a document thread window', async function (assert)
 });
 
 QUnit.test('open, fold, unfold and close a document thread window', async function (assert) {
-    assert.expect(24);
+    assert.expect(20);
     var messagingMenu = new MessagingMenu();
     testUtils.mock.addMockEnvironment(messagingMenu, {
         services: this.services,
@@ -238,12 +238,13 @@ QUnit.test('open, fold, unfold and close a document thread window', async functi
     testUtils.mock.intercept(messagingMenu, 'call_service', function (ev) {
         if (ev.data.service === 'local_storage' && ev.data.method === 'setItem') {
             const key = ev.data.args[0];
-            const state = ev.data.args[1].state;
-            assert.strictEqual(key, 'mail.document_threads_state/some.res.model_1');
-            assert.ok(state);
-            assert.ok(state.name);
-            assert.ok(state.windowState);
-            assert.step(`${key}: { name: "${state.name}", windowState: '${state.windowState}' }`);
+            if (key === 'mail.document_threads_state/some.res.model_1') {
+                const state = ev.data.args[1].state;
+                assert.ok(state);
+                assert.ok(state.name);
+                assert.ok(state.windowState);
+                assert.step(`${key}: { name: "${state.name}", windowState: '${state.windowState}' }`);
+            }
         }
     }, true);
     await messagingMenu.appendTo($('#qunit-fixture'));