From 69f192eeef40534f2d64d34e8525291b9fed026c Mon Sep 17 00:00:00 2001
From: Yenthe666 <yenthevg@gmail.com>
Date: Thu, 8 Aug 2019 11:22:45 +0000
Subject: [PATCH] [IMP] website_forum,slides: add name on main elements for
 easier xpaths
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

closes odoo/odoo#35561

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
---
 addons/website_forum/views/forum.xml          | 25 +++++++++++--------
 .../views/rating_rating_views.xml             |  4 +--
 .../views/slide_channel_views.xml             | 22 ++++++++--------
 .../views/slide_slide_views.xml               | 18 ++++++-------
 4 files changed, 36 insertions(+), 33 deletions(-)

diff --git a/addons/website_forum/views/forum.xml b/addons/website_forum/views/forum.xml
index 8c5a9c126d0..81d952f8a6e 100644
--- a/addons/website_forum/views/forum.xml
+++ b/addons/website_forum/views/forum.xml
@@ -46,7 +46,7 @@
                             <field name="website_id" options="{'no_create': True}" groups="website.group_multi_website"/>
                         </group>
                         <notebook>
-                            <page string="Options">
+                            <page name="options" string="Options">
                               <group string="Order" name="group_order">
                                 <field name="default_order"/>
                                 <label for="relevancy_post_vote" string="Relevance Computation" groups="base.group_no_one" attrs="{'invisible':[('default_order','!=','relevancy desc')]}"/>
@@ -55,8 +55,8 @@
                                 </div>
                               </group>
                             </page>
-                            <page string='Karma Gains'>
-                                <group>
+                            <page name="karma_gains" string="Karma Gains">
+                                <group name="karma_gain_details">
                                     <field name="karma_gen_question_new"/>
                                     <field name="karma_gen_question_upvote"/>
                                     <field name="karma_gen_question_downvote"/>
@@ -67,9 +67,9 @@
                                     <field name="karma_gen_answer_flagged"/>
                                 </group>
                             </page>
-                            <page string='Karma Related Rights'>
+                            <page name="karma_rights" string="Karma Related Rights">
                                 <group>
-                                    <group>
+                                    <group name="karma_rights_left">
                                         <field name="karma_ask"/>
                                         <field name="karma_answer"/>
                                         <field name="karma_upvote"/>
@@ -84,7 +84,7 @@
                                         <field name="karma_answer_accept_own"/>
                                         <field name="karma_answer_accept_all"/>
                                     </group>
-                                    <group>
+                                    <group name="karma_rights_right">
                                         <field name="karma_editor"/>
                                         <field name="karma_comment_own"/>
                                         <field name="karma_comment_all"/>
@@ -160,23 +160,26 @@
                             <field name="name" placeholder="Name"/>
                         </h1>
                         <group>
-                            <group>
+                            <group name="forum_details">
                                 <field name="active" invisible="1"/>
                                 <field name="forum_id"/>
                                 <field name="website_id" groups="website.group_multi_website"/>
                                 <field name="parent_id"/>
-                            </group><group>
+                            </group>
+                            <group name="post_details">
                                 <field name="tag_ids" widget="many2many_tags" options="{'color_field': 'color'}"/>
                                 <field name="state"/>
                                 <field name="closed_reason_id"/>
                                 <field name="closed_uid"/>
                                 <field name="closed_date"/>
-                            </group><group>
+                            </group>
+                            <group name="creation_details">
                                 <field name="create_uid"/>
                                 <field name="create_date"/>
                                 <field name="write_uid"/>
                                 <field name="write_date"/>
-                            </group><group>
+                            </group>
+                            <group name="post_statistics">
                                 <field name="is_correct"/>
                                 <field name="views"/>
                                 <field name="vote_count"/>
@@ -185,7 +188,7 @@
                                 <field name="relevancy"/>
                             </group>
                         </group>
-                        <group string="Answers" attrs="{'invisible':[('parent_id','!=',False)]}">
+                        <group name="answers" string="Answers" attrs="{'invisible':[('parent_id','!=',False)]}">
                             <field name="child_ids" nolabel="1">
                                 <tree>
                                     <field name="create_uid" string="Answered by"/>
diff --git a/addons/website_slides/views/rating_rating_views.xml b/addons/website_slides/views/rating_rating_views.xml
index 599a217109b..5446fc76779 100644
--- a/addons/website_slides/views/rating_rating_views.xml
+++ b/addons/website_slides/views/rating_rating_views.xml
@@ -95,7 +95,7 @@
         <field name="view_id" ref="rating_rating_view_kanban_slide_channel"/>
         <field name="help" type="html">
             <p class="o_view_nocontent_empty_folder">
-                There is no rating for those courses at the moment
+                There is no rating for these courses at the moment
             </p>
         </field>
     </record>
@@ -110,7 +110,7 @@
         <field name="view_id" ref="rating_rating_view_graph_slide_channel"/>
         <field name="help" type="html">
             <p class="o_view_nocontent_empty_folder">
-                There is no rating for those courses at the moment
+                There is no rating for these courses at the moment
             </p>
         </field>
     </record>
diff --git a/addons/website_slides/views/slide_channel_views.xml b/addons/website_slides/views/slide_channel_views.xml
index e1cdacc0f1c..87e9d875c20 100644
--- a/addons/website_slides/views/slide_channel_views.xml
+++ b/addons/website_slides/views/slide_channel_views.xml
@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
     <data>
-
         <!-- SLIDE.CHANNEL VIEWS -->
         <record model="ir.ui.view" id="view_slide_channel_form">
             <field name="name">slide.channel.form</field>
@@ -53,7 +52,7 @@
                             </group>
                         </group>
                         <notebook colspan="4">
-                            <page string="Content">
+                            <page name="content" string="Content">
                                 <field name="slide_ids" colspan="4" nolabel="1" widget="slide_category_one2many" context="{'default_channel_id': active_id}">
                                      <tree decoration-bf="is_category" editable="bottom">
                                         <field name="sequence" widget="handle"/>
@@ -70,29 +69,29 @@
                                     </tree>
                                 </field>
                             </page>
-                            <page string="Description">
+                            <page name="description" string="Description">
                                 <field name="description" colspan="4" nolabel="1"/>
                             </page>
-                            <page string="Options">
+                            <page name="options" string="Options">
                                 <group>
-                                    <group string="Course">
+                                    <group name="course" string="Course">
                                         <field string="Type" name="channel_type" widget="radio"/>
                                         <field name="user_id"/>
                                         <field name="website_id" options="{'no_create': True}" groups="website.group_multi_website"/>
                                     </group>
-                                    <group string="Access Rights">
+                                    <group name="access_rights" string="Access Rights">
                                         <field name="enroll" widget="radio" options="{'horizontal': true}"/>
                                         <field name="upload_group_ids" string="New Content" widget="many2many_tags"/>
                                         <field name="enroll_group_ids" widget="many2many_tags" groups="base.group_no_one"/>
                                     </group>
                                 </group>
                                 <group>
-                                    <group string="Communication">
+                                    <group name="communication" string="Communication">
                                         <field string="Allow Rating" name="allow_comment"/>
                                         <field name="publish_template_id" domain="[('model','=','slide.slide')]"/>
                                         <field name="share_template_id" domain="[('model','=','slide.slide')]"/>
                                     </group>
-                                    <group string="Display">
+                                    <group name="display" string="Display">
                                         <field name="visibility" widget="radio"/>
                                         <field name="promote_strategy" widget="radio"/>
                                     </group>
@@ -111,9 +110,9 @@
                                     <field name="karma_slide_vote" attrs="{'invisible': [('allow_comment', '!=', True)]}"/>
                                 </group>
                             </page>
-                            <page string="Statistics">
+                            <page name="statistics" string="Statistics">
                                 <group>
-                                    <group class="col-4">
+                                    <group name="statistics_nbr" class="col-4">
                                         <field name="nbr_presentation"/>
                                         <field name="nbr_document"/>
                                         <field name="nbr_video"/>
@@ -123,7 +122,7 @@
                                         <separator/>
                                         <field name="total_slides"/>
                                     </group>
-                                    <group>
+                                    <group name="view_stats">
                                         <field name="total_views" string="Visits"/>
                                         <field string="Rating" name="rating_avg" widget="field_float_rating"/>
                                         <label for="total_time" string="Watch Time"/>
@@ -144,6 +143,7 @@
             </field>
         </record>
 
+
         <record id="slide_channel_view_tree" model="ir.ui.view">
             <field name="name">slide.channel.view.tree</field>
             <field name="model">slide.channel</field>
diff --git a/addons/website_slides/views/slide_slide_views.xml b/addons/website_slides/views/slide_slide_views.xml
index fddf5ee0934..e553f164d01 100644
--- a/addons/website_slides/views/slide_slide_views.xml
+++ b/addons/website_slides/views/slide_slide_views.xml
@@ -59,9 +59,9 @@
                             <field name="tag_ids" attrs="{'invisible': [('is_category', '=', True)]}" widget="many2many_tags" placeholder="Tags..."/>
                         </div>
                         <notebook attrs="{'invisible': [('is_category', '=', True)]}">
-                            <page string="Document">
+                            <page name="document" string="Document">
                                 <group>
-                                    <group>
+                                    <group name="lesson_details">
                                         <field name="active" invisible="1"/>
                                         <field name="slide_type"/>
                                         <field name="url" attrs="{
@@ -72,7 +72,7 @@
                                         <field name="datas" string="Attachment"
                                             attrs="{'invisible': [('slide_type', 'not in', ('document', 'presentation'))]}"/>
                                     </group>
-                                    <group>
+                                    <group name="related_details">
                                         <field name="user_id"/>
                                         <field name="channel_id"/>
                                         <field name="website_id" groups="website.group_multi_website"/>
@@ -87,7 +87,7 @@
                                     </group>
                                 </group>
                             </page>
-                            <page string="Description">
+                            <page name="description" string="Description">
                                 <field name="description"/>
                             </page>
                             <page string="External Links" name="external_links" >
@@ -100,9 +100,9 @@
                                     </field>
                                 </group>
                             </page>
-                            <page string="Quiz">
-                                <group name="container_row_2">
-                                    <group string="Rewards">
+                            <page name="quiz" string="Quiz">
+                                <group name="quiz_details">
+                                    <group name="quiz_rewards" string="Rewards">
                                         <group>
                                             <field string="First attempt" name="quiz_first_attempt_reward"/>
                                             <field string="Second attempt" name="quiz_second_attempt_reward"/>
@@ -120,9 +120,9 @@
                                     </group>
                                 </group>
                             </page>
-                            <page string="Statistics">
+                            <page name="statistics" string="Statistics">
                                 <group>
-                                    <group string="Views">
+                                    <group name="view_statistics" string="Views">
                                         <field string="Member views" name="slide_views"/>
                                         <field string="Public views" name="public_views" readonly="1"/>
                                         <field string="Total views" name="total_views"/>