From 693b62f38e1e2ef84cd009be3bfb9fcbc1a8ab97 Mon Sep 17 00:00:00 2001 From: Victor Feyens Date: Tue, 29 Aug 2023 17:04:46 +0200 Subject: [PATCH] [REM] sale_quotation_builder The value provided by the sale quotation builder feature is small due to many problems, and the technical debt behind is high. For instance: - The feature is nice but hidden: not visible on quotation, the most visible part is the button "Design Template" on the quotation template (if you did activate the feature), it requires to have eCommerce installed... - The feature relies on fields that are shared with eCommerce which leads to unwanted behavior: e.g. updating the bottom of the product page in eCommerce will impact quotation html description on the portal - The feature works as template but it is unclear for users: updating the HTML description on a specific quotation will only impact that quotation. Updating the HTML page of a quotation only update this quotation - The feature is technically complex As we want to keep most of the value of the feature but reduce its complexity, we remove the quotation builder feature that'll get replace with the PDF quote builder feature. task-3249142 Part-of: odoo/odoo#133773 Co-authored-by: Victor Feyens Co-authored-by: Morgane Demesmaeker --- .../models/res_config_settings.py | 6 - .../views/res_config_settings_views.xml | 11 - addons/sale_quotation_builder/__init__.py | 32 -- addons/sale_quotation_builder/__manifest__.py | 22 -- .../controllers/__init__.py | 4 - .../controllers/main.py | 16 - .../data/sale_order_template_data.xml | 81 ----- addons/sale_quotation_builder/i18n/ar.po | 306 ----------------- addons/sale_quotation_builder/i18n/az.po | 264 --------------- addons/sale_quotation_builder/i18n/bs.po | 263 --------------- addons/sale_quotation_builder/i18n/ca.po | 311 ----------------- addons/sale_quotation_builder/i18n/cs.po | 278 ---------------- addons/sale_quotation_builder/i18n/da.po | 303 ----------------- addons/sale_quotation_builder/i18n/de.po | 300 ----------------- addons/sale_quotation_builder/i18n/el.po | 264 --------------- addons/sale_quotation_builder/i18n/es.po | 305 ----------------- addons/sale_quotation_builder/i18n/et.po | 309 ----------------- addons/sale_quotation_builder/i18n/fa.po | 267 --------------- addons/sale_quotation_builder/i18n/fi.po | 310 ----------------- addons/sale_quotation_builder/i18n/fr.po | 307 ----------------- addons/sale_quotation_builder/i18n/gu.po | 263 --------------- addons/sale_quotation_builder/i18n/he.po | 308 ----------------- addons/sale_quotation_builder/i18n/hr.po | 269 --------------- addons/sale_quotation_builder/i18n/hu.po | 269 --------------- addons/sale_quotation_builder/i18n/is.po | 259 --------------- addons/sale_quotation_builder/i18n/it.po | 300 ----------------- addons/sale_quotation_builder/i18n/ja.po | 273 --------------- addons/sale_quotation_builder/i18n/km.po | 262 --------------- addons/sale_quotation_builder/i18n/ko.po | 298 ----------------- addons/sale_quotation_builder/i18n/lb.po | 259 --------------- addons/sale_quotation_builder/i18n/lt.po | 282 ---------------- addons/sale_quotation_builder/i18n/mn.po | 277 --------------- addons/sale_quotation_builder/i18n/nb.po | 266 --------------- addons/sale_quotation_builder/i18n/nl.po | 306 ----------------- addons/sale_quotation_builder/i18n/pl.po | 314 ------------------ addons/sale_quotation_builder/i18n/pt.po | 269 --------------- addons/sale_quotation_builder/i18n/pt_BR.po | 299 ----------------- addons/sale_quotation_builder/i18n/ro.po | 299 ----------------- addons/sale_quotation_builder/i18n/ru.po | 280 ---------------- .../i18n/sale_quotation_builder.pot | 261 --------------- addons/sale_quotation_builder/i18n/sk.po | 301 ----------------- addons/sale_quotation_builder/i18n/sr.po | 291 ---------------- addons/sale_quotation_builder/i18n/th.po | 307 ----------------- addons/sale_quotation_builder/i18n/tr.po | 307 ----------------- addons/sale_quotation_builder/i18n/uk.po | 305 ----------------- addons/sale_quotation_builder/i18n/vi.po | 305 ----------------- addons/sale_quotation_builder/i18n/zh_CN.po | 301 ----------------- addons/sale_quotation_builder/i18n/zh_TW.po | 302 ----------------- .../sale_quotation_builder/models/__init__.py | 11 - .../models/product_template.py | 34 -- .../models/res_company.py | 17 - .../models/sale_order.py | 25 -- .../models/sale_order_line.py | 26 -- .../models/sale_order_option.py | 29 -- .../models/sale_order_template.py | 24 -- .../models/sale_order_template_line.py | 33 -- .../models/sale_order_template_option.py | 31 -- .../views/res_config_settings_views.xml | 14 - .../views/sale_order_template_views.xml | 32 -- .../views/sale_order_views.xml | 38 --- .../views/sale_portal_templates.xml | 96 ------ 61 files changed, 12401 deletions(-) delete mode 100644 addons/sale_quotation_builder/__init__.py delete mode 100644 addons/sale_quotation_builder/__manifest__.py delete mode 100644 addons/sale_quotation_builder/controllers/__init__.py delete mode 100644 addons/sale_quotation_builder/controllers/main.py delete mode 100644 addons/sale_quotation_builder/data/sale_order_template_data.xml delete mode 100644 addons/sale_quotation_builder/i18n/ar.po delete mode 100644 addons/sale_quotation_builder/i18n/az.po delete mode 100644 addons/sale_quotation_builder/i18n/bs.po delete mode 100644 addons/sale_quotation_builder/i18n/ca.po delete mode 100644 addons/sale_quotation_builder/i18n/cs.po delete mode 100644 addons/sale_quotation_builder/i18n/da.po delete mode 100644 addons/sale_quotation_builder/i18n/de.po delete mode 100644 addons/sale_quotation_builder/i18n/el.po delete mode 100644 addons/sale_quotation_builder/i18n/es.po delete mode 100644 addons/sale_quotation_builder/i18n/et.po delete mode 100644 addons/sale_quotation_builder/i18n/fa.po delete mode 100644 addons/sale_quotation_builder/i18n/fi.po delete mode 100644 addons/sale_quotation_builder/i18n/fr.po delete mode 100644 addons/sale_quotation_builder/i18n/gu.po delete mode 100644 addons/sale_quotation_builder/i18n/he.po delete mode 100644 addons/sale_quotation_builder/i18n/hr.po delete mode 100644 addons/sale_quotation_builder/i18n/hu.po delete mode 100644 addons/sale_quotation_builder/i18n/is.po delete mode 100644 addons/sale_quotation_builder/i18n/it.po delete mode 100644 addons/sale_quotation_builder/i18n/ja.po delete mode 100644 addons/sale_quotation_builder/i18n/km.po delete mode 100644 addons/sale_quotation_builder/i18n/ko.po delete mode 100644 addons/sale_quotation_builder/i18n/lb.po delete mode 100644 addons/sale_quotation_builder/i18n/lt.po delete mode 100644 addons/sale_quotation_builder/i18n/mn.po delete mode 100644 addons/sale_quotation_builder/i18n/nb.po delete mode 100644 addons/sale_quotation_builder/i18n/nl.po delete mode 100644 addons/sale_quotation_builder/i18n/pl.po delete mode 100644 addons/sale_quotation_builder/i18n/pt.po delete mode 100644 addons/sale_quotation_builder/i18n/pt_BR.po delete mode 100644 addons/sale_quotation_builder/i18n/ro.po delete mode 100644 addons/sale_quotation_builder/i18n/ru.po delete mode 100644 addons/sale_quotation_builder/i18n/sale_quotation_builder.pot delete mode 100644 addons/sale_quotation_builder/i18n/sk.po delete mode 100644 addons/sale_quotation_builder/i18n/sr.po delete mode 100644 addons/sale_quotation_builder/i18n/th.po delete mode 100644 addons/sale_quotation_builder/i18n/tr.po delete mode 100644 addons/sale_quotation_builder/i18n/uk.po delete mode 100644 addons/sale_quotation_builder/i18n/vi.po delete mode 100644 addons/sale_quotation_builder/i18n/zh_CN.po delete mode 100644 addons/sale_quotation_builder/i18n/zh_TW.po delete mode 100644 addons/sale_quotation_builder/models/__init__.py delete mode 100644 addons/sale_quotation_builder/models/product_template.py delete mode 100644 addons/sale_quotation_builder/models/res_company.py delete mode 100644 addons/sale_quotation_builder/models/sale_order.py delete mode 100644 addons/sale_quotation_builder/models/sale_order_line.py delete mode 100644 addons/sale_quotation_builder/models/sale_order_option.py delete mode 100644 addons/sale_quotation_builder/models/sale_order_template.py delete mode 100644 addons/sale_quotation_builder/models/sale_order_template_line.py delete mode 100644 addons/sale_quotation_builder/models/sale_order_template_option.py delete mode 100644 addons/sale_quotation_builder/views/res_config_settings_views.xml delete mode 100644 addons/sale_quotation_builder/views/sale_order_template_views.xml delete mode 100644 addons/sale_quotation_builder/views/sale_order_views.xml delete mode 100644 addons/sale_quotation_builder/views/sale_portal_templates.xml diff --git a/addons/sale_management/models/res_config_settings.py b/addons/sale_management/models/res_config_settings.py index e0b250da5ba..a17e5a73147 100644 --- a/addons/sale_management/models/res_config_settings.py +++ b/addons/sale_management/models/res_config_settings.py @@ -12,12 +12,6 @@ class ResConfigSettings(models.TransientModel): company_so_template_id = fields.Many2one( related="company_id.sale_order_template_id", string="Default Template", readonly=False, domain="['|', ('company_id', '=', False), ('company_id', '=', company_id)]") - module_sale_quotation_builder = fields.Boolean("Quotation Builder") - - @api.onchange('group_sale_order_template') - def _onchange_group_sale_order_template(self): - if not self.group_sale_order_template: - self.module_sale_quotation_builder = False def set_values(self): if not self.group_sale_order_template: diff --git a/addons/sale_management/views/res_config_settings_views.xml b/addons/sale_management/views/res_config_settings_views.xml index 4dd0bcbda5d..399c5d41501 100644 --- a/addons/sale_management/views/res_config_settings_views.xml +++ b/addons/sale_management/views/res_config_settings_views.xml @@ -21,17 +21,6 @@