From 69397e2bcb112457e272d479be41eaf6a317e527 Mon Sep 17 00:00:00 2001
From: Damien Bouvy <dbo@odoo.com>
Date: Mon, 29 Jan 2024 09:24:15 +0100
Subject: [PATCH] [FIX] website: broken ir.act_server view

Since the refactoring of base_automation, the 'website-publishing'
option of server actions was broken; it did get included in the view
but outside of a group node and without labels. The result was a
floating checkbox which would trigger a label-less char field upon
selection - not the clearest of UIs.

This commit properly insert these fields into a group node. Note that
since server actions can normally only be reached by going through
technical menus, the fact that this section of view is now in a
group_no_one-only section should not change anything functionally.

closes odoo/odoo#151498

Signed-off-by: Bouvy Damien (dbo) <dbo@odoo.com>
---
 .../website/views/ir_actions_server_views.xml | 20 ++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/addons/website/views/ir_actions_server_views.xml b/addons/website/views/ir_actions_server_views.xml
index 9a48bdaf3ea..511758295fb 100644
--- a/addons/website/views/ir_actions_server_views.xml
+++ b/addons/website/views/ir_actions_server_views.xml
@@ -8,15 +8,17 @@
             <field name="inherit_id" ref="base.view_server_action_form"/>
             <field name="arch" type="xml">
                 <data>
-                    <xpath expr="//field[@name='state']" position="after">
-                        <field name="website_published"
-                            invisible="state != 'code'"/>
-                        <field name="xml_id" invisible="1"/>
-                        <field name="website_path"
-                            invisible="not website_published or state != 'code'"/>
-                        <field name="website_url" widget="url"
-                            readonly="1"
-                            invisible="not website_published or state != 'code'"/>
+                    <xpath expr="//group[@groups='base.group_no_one']" position="inside">
+                        <group>
+                            <field name="website_published"
+                                invisible="state != 'code'"/>
+                            <field name="xml_id" invisible="1"/>
+                            <field name="website_path"
+                                invisible="not website_published or state != 'code'"/>
+                            <field name="website_url" widget="url"
+                                readonly="1"
+                                invisible="not website_published or state != 'code'"/>
+                        </group>
                     </xpath>
                 </data>
             </field>