From 6807eea38c0ecbfe89953416892e7d3a4e3c4f4d Mon Sep 17 00:00:00 2001
From: MAHAMADASIF ANSARI <maan@odoo.com>
Date: Wed, 13 Jul 2022 12:27:57 +0000
Subject: [PATCH] [FIX] various: display full name/title in form views
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

With commit[1], we added `o_text_overflow` classes at several places to avoid
long names going out of the boxes. However, for the name/title fields in the
form views, we should always show the full name.

So this commit replaces `o_text_overflow` class with `text-break` from
name/title fields in the form views to display full string in the read
only mode, but also keep them from going outside of the form view.

Below are the modules affected:
 - base
 - coupon
 - crm
 - event
 - mass_mailing
 - mass_mailing_sms
 - project
 - sales_team

commit[1] - a0ebb46

task-2889845

closes odoo/odoo#96132

X-original-commit: 4a74c7af6b54bd771f50d3885813f4aae442c9e7
Related: odoo/enterprise#29552
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
---
 addons/crm/views/crm_lead_views.xml                     | 2 +-
 addons/event/views/event_event_views.xml                | 2 +-
 addons/loyalty/views/loyalty_program_views.xml          | 2 +-
 addons/mass_mailing/views/mailing_contact_views.xml     | 2 +-
 addons/mass_mailing/views/mailing_list_views.xml        | 2 +-
 addons/mass_mailing/views/mailing_mailing_views.xml     | 2 +-
 addons/mass_mailing_sms/views/mailing_mailing_views.xml | 2 +-
 addons/product/views/product_views.xml                  | 2 +-
 addons/project/views/project_views.xml                  | 2 +-
 addons/sales_team/views/crm_team_views.xml              | 2 +-
 addons/utm/views/utm_campaign_views.xml                 | 2 +-
 odoo/addons/base/views/res_partner_views.xml            | 4 ++--
 12 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/addons/crm/views/crm_lead_views.xml b/addons/crm/views/crm_lead_views.xml
index 68f8eda3fb5..48ddac5e8d8 100644
--- a/addons/crm/views/crm_lead_views.xml
+++ b/addons/crm/views/crm_lead_views.xml
@@ -48,7 +48,7 @@
                         <widget name="web_ribbon" title="Lost" bg_color="bg-danger" attrs="{'invisible': ['|', ('probability', '&gt;', 0), ('active', '=', True)]}"/>
                         <widget name="web_ribbon" title="Won" attrs="{'invisible': [('probability', '&lt;', 100)]}" />
                         <div class="oe_title">
-                            <h1><field class="o_text_overflow" name="name" placeholder="e.g. Product Pricing"/></h1>
+                            <h1><field class="text-break" name="name" placeholder="e.g. Product Pricing"/></h1>
                             <h2 class="o_row g-0 align-items-end">
                                 <div class="col" attrs="{'invisible': [('type', '=', 'lead')]}">
                                     <label for="expected_revenue" class="oe_edit_only" />
diff --git a/addons/event/views/event_event_views.xml b/addons/event/views/event_event_views.xml
index e6ea43fae38..2c20ebd6fb5 100644
--- a/addons/event/views/event_event_views.xml
+++ b/addons/event/views/event_event_views.xml
@@ -34,7 +34,7 @@
                     <field name="kanban_state" widget="state_selection" class="ms-auto float-end"/>
                     <div class="oe_title">
                         <label for="name" string="Event Name"/>
-                        <h1><field class="o_text_overflow" name="name" placeholder="e.g. Conference for Architects"/></h1>
+                        <h1><field class="text-break" name="name" placeholder="e.g. Conference for Architects"/></h1>
                     </div>
                     <group>
                         <group>
diff --git a/addons/loyalty/views/loyalty_program_views.xml b/addons/loyalty/views/loyalty_program_views.xml
index 7650cdebdf6..bc20aafeed1 100644
--- a/addons/loyalty/views/loyalty_program_views.xml
+++ b/addons/loyalty/views/loyalty_program_views.xml
@@ -32,7 +32,7 @@
                     <div class="oe_title">
                         <label for="name" string="Program Name"/>
                         <h1>
-                            <field name="name" placeholder="e.g. 10% discount on laptops"/>
+                            <field name="name" class="text-break" placeholder="e.g. 10% discount on laptops"/>
                         </h1>
                     </div>
                     <group>
diff --git a/addons/mass_mailing/views/mailing_contact_views.xml b/addons/mass_mailing/views/mailing_contact_views.xml
index 79c590940bf..a835859719b 100644
--- a/addons/mass_mailing/views/mailing_contact_views.xml
+++ b/addons/mass_mailing/views/mailing_contact_views.xml
@@ -112,7 +112,7 @@
                     <div class="oe_title">
                         <label for="name" string="Contact Name"/>
                         <h1>
-                            <field class="o_text_overflow" name="name" placeholder="e.g. John Smith"/>
+                            <field class="text-break" name="name" placeholder="e.g. John Smith"/>
                         </h1>
                         <div>
                             <field name="tag_ids" widget="many2many_tags" options="{'color_field': 'color'}" placeholder="Tags" style="width: 100%"/>
diff --git a/addons/mass_mailing/views/mailing_list_views.xml b/addons/mass_mailing/views/mailing_list_views.xml
index 6438f3a2c07..4ce6ee1e5cc 100644
--- a/addons/mass_mailing/views/mailing_list_views.xml
+++ b/addons/mass_mailing/views/mailing_list_views.xml
@@ -90,7 +90,7 @@
                     <div class="oe_title">
                         <label for="name"/>
                         <h1>
-                            <field name="name" class="o_text_overflow" placeholder="e.g. Consumer Newsletter"/>
+                            <field name="name" class="text-break" placeholder="e.g. Consumer Newsletter"/>
                         </h1>
                     </div>
                     <group>
diff --git a/addons/mass_mailing/views/mailing_mailing_views.xml b/addons/mass_mailing/views/mailing_mailing_views.xml
index e91c034781b..cd4b20d18d5 100644
--- a/addons/mass_mailing/views/mailing_mailing_views.xml
+++ b/addons/mass_mailing/views/mailing_mailing_views.xml
@@ -171,7 +171,7 @@
                                 attrs="{'readonly': [('state', '!=', 'draft')]}" force_save="1"/>
                             <label for="subject">Subject</label>
                             <div class="o_mass_mailing_subject d-flex flex-row align-items-baseline">
-                                <field class="o_text_overflow" name="subject" string="Subject"
+                                <field class="text-break" name="subject" string="Subject"
                                     attrs="{'readonly': [('state', 'in', ('sending', 'done'))]}"
                                     widget="char_emojis" placeholder="e.g. New Sale on all T-shirts"/>
                                 <field name="favorite" invisible="1"/>
diff --git a/addons/mass_mailing_sms/views/mailing_mailing_views.xml b/addons/mass_mailing_sms/views/mailing_mailing_views.xml
index 6d336dcd25e..12930f28b63 100644
--- a/addons/mass_mailing_sms/views/mailing_mailing_views.xml
+++ b/addons/mass_mailing_sms/views/mailing_mailing_views.xml
@@ -102,7 +102,7 @@
                     For an SMS Text Message, internal Title of the Message.</attribute>
             </xpath>
             <xpath expr="//field[@name='subject']" position="after">
-                <field class="o_text_overflow" name="sms_subject" string="Title" placeholder="e.g. Black Friday SMS coupon" attrs="{'invisible': [('mailing_type', '!=', 'sms')], 'readonly': [('state', 'in', ('sending', 'done'))], 'required': [('mailing_type', '=', 'sms')]}"/>
+                <field class="text-break" name="sms_subject" string="Title" placeholder="e.g. Black Friday SMS coupon" attrs="{'invisible': [('mailing_type', '!=', 'sms')], 'readonly': [('state', 'in', ('sending', 'done'))], 'required': [('mailing_type', '=', 'sms')]}"/>
             </xpath>
             <xpath expr="//button[@name='action_set_favorite']" position="attributes">
                 <attribute name="attrs">{'invisible': ['|', ('mailing_type', '!=', 'mail'), ('favorite', '=', True)]}</attribute>
diff --git a/addons/product/views/product_views.xml b/addons/product/views/product_views.xml
index 6dc25863c52..9cb53aefda6 100644
--- a/addons/product/views/product_views.xml
+++ b/addons/product/views/product_views.xml
@@ -43,7 +43,7 @@
                         <h1>
                             <div class="d-flex">
                                 <field name="priority" widget="priority" class="me-3"/>
-                                <field class="o_text_overflow" name="name" placeholder="e.g. Cheese Burger"/>
+                                <field class="text-break" name="name" placeholder="e.g. Cheese Burger"/>
                             </div>
                         </h1>
                     </div>
diff --git a/addons/project/views/project_views.xml b/addons/project/views/project_views.xml
index a0dd11f7b54..5ba49667e2a 100644
--- a/addons/project/views/project_views.xml
+++ b/addons/project/views/project_views.xml
@@ -512,7 +512,7 @@
                     <div class="oe_title">
                         <h1 class="d-flex flex-row">
                             <field name="is_favorite" nolabel="1" widget="boolean_favorite" class="me-3"/>
-                            <field name="name" class="o_text_overflow" placeholder="Project Name"/>
+                            <field name="name" class="text-break" placeholder="Project Name"/>
                         </h1>
                     </div>
                     <group>
diff --git a/addons/sales_team/views/crm_team_views.xml b/addons/sales_team/views/crm_team_views.xml
index 4f887f68bd2..272ee299401 100644
--- a/addons/sales_team/views/crm_team_views.xml
+++ b/addons/sales_team/views/crm_team_views.xml
@@ -32,7 +32,7 @@
                     <div class="oe_title">
                         <label for="name" string="Sales Team"/>
                         <h1>
-                            <field class="o_text_overflow" name="name" placeholder="e.g. North America"/>
+                            <field class="text-break" name="name" placeholder="e.g. North America"/>
                         </h1>
                         <div name="options_active"/>
                     </div>
diff --git a/addons/utm/views/utm_campaign_views.xml b/addons/utm/views/utm_campaign_views.xml
index 2f7c9bb4983..2bf034b4b17 100644
--- a/addons/utm/views/utm_campaign_views.xml
+++ b/addons/utm/views/utm_campaign_views.xml
@@ -31,7 +31,7 @@
                     <div class="oe_button_box d-flex justify-content-end" name="button_box">
                     </div>
                     <group id="top-group">
-                        <field class="o_text_overflow" name="title" string="Campaign Name" placeholder="e.g. Black Friday"/>
+                        <field class="text-break" name="title" string="Campaign Name" placeholder="e.g. Black Friday"/>
                         <field name="name" invisible="1"/>
                         <field name="user_id" domain="[('share', '=', False)]"/>
                         <field name="tag_ids" widget="many2many_tags" options="{'color_field': 'color', 'no_create_edit': True}"/>
diff --git a/odoo/addons/base/views/res_partner_views.xml b/odoo/addons/base/views/res_partner_views.xml
index d9224540baf..a9a56edd2cd 100644
--- a/odoo/addons/base/views/res_partner_views.xml
+++ b/odoo/addons/base/views/res_partner_views.xml
@@ -172,8 +172,8 @@
                         <field name="country_code" invisible="1"/>
                         <field name="company_type" widget="radio" options="{'horizontal': true}"/>
                         <h1>
-                            <field id="company" class="o_text_overflow" name="name" default_focus="1" placeholder="e.g. Lumber Inc" attrs="{'required' : [('type', '=', 'contact'),('is_company', '=', True)], 'invisible': [('is_company','=', False)]}"/>
-                            <field id="individual" class="o_text_overflow" name="name" default_focus="1" placeholder="e.g. Brandom Freeman" attrs="{'required' : [('type', '=', 'contact'), ('is_company', '=', False)], 'invisible': [('is_company','=', True)]}"/>
+                            <field id="company" class="text-break" name="name" default_focus="1" placeholder="e.g. Lumber Inc" attrs="{'required' : [('type', '=', 'contact'),('is_company', '=', True)], 'invisible': [('is_company','=', False)]}"/>
+                            <field id="individual" class="text-break" name="name" default_focus="1" placeholder="e.g. Brandom Freeman" attrs="{'required' : [('type', '=', 'contact'), ('is_company', '=', False)], 'invisible': [('is_company','=', True)]}"/>
                         </h1>
                         <div class="o_row">
                             <field name="parent_id"