From 6772216842523bf6893125c8d7834d7c02577aa2 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Tue, 22 Jan 2019 14:41:50 +0000 Subject: [PATCH] [FIX] bus, mail, web: missing super() call in destroy overrides closes odoo/odoo#30792 --- addons/bus/static/src/js/longpolling_bus.js | 1 + addons/mail/static/src/js/thread_widget.js | 1 + addons/web/static/src/js/fields/basic_fields.js | 1 + 3 files changed, 3 insertions(+) diff --git a/addons/bus/static/src/js/longpolling_bus.js b/addons/bus/static/src/js/longpolling_bus.js index 4764e2e52b0..a24dcb593fd 100644 --- a/addons/bus/static/src/js/longpolling_bus.js +++ b/addons/bus/static/src/js/longpolling_bus.js @@ -57,6 +57,7 @@ var LongpollingBus = Bus.extend(ServicesMixin, { $(window).off("click." + this._id); $(window).off("keydown." + this._id); $(window).off("keyup." + this._id); + this._super(); }, //-------------------------------------------------------------------------- // Public diff --git a/addons/mail/static/src/js/thread_widget.js b/addons/mail/static/src/js/thread_widget.js index 01af2e73d7c..39b32fbb499 100644 --- a/addons/mail/static/src/js/thread_widget.js +++ b/addons/mail/static/src/js/thread_widget.js @@ -96,6 +96,7 @@ var ThreadWidget = Widget.extend({ if (this._messageMailPopover) { this._messageMailPopover.popover('hide'); } + this._super(); }, /** * @param {mail.model.AbstractThread} thread the thread to render. diff --git a/addons/web/static/src/js/fields/basic_fields.js b/addons/web/static/src/js/fields/basic_fields.js index aac91081c3c..a5f7649929c 100644 --- a/addons/web/static/src/js/fields/basic_fields.js +++ b/addons/web/static/src/js/fields/basic_fields.js @@ -2908,6 +2908,7 @@ var AceEditor = DebouncedField.extend({ if (this.aceEditor) { this.aceEditor.destroy(); } + this._super.apply(this, arguments); }, //--------------------------------------------------------------------------