[CHG] *: make binary fields default to attachment=True

Check that it makes custom binary fields into attachment as that's the
main reason for the change: when users create binary fields via Studio,
they're necessarily db-stored (as the interface doesn't allow altering
the attachment attribute and it's unclear how we'd handle users
switching it on/off every time), which significantly bloats their
database (and burns storage & backup space), especially as the primary
use case for binary fields is adding images and documents to records.

* check that binary fields are properly created as attachment=True
* add attachment=False on fields where that seems relevant (most but not
  all of the fields previously using the default)
* remove occurrences of attachment=True

closes odoo/odoo#29308
This commit is contained in:
Xavier Morel
2018-12-07 13:37:34 +00:00
parent 299f9f1eb0
commit 66f0e26f6f
29 changed files with 61 additions and 55 deletions
@@ -9,7 +9,7 @@ class BaseImportModule(models.TransientModel):
_name = "base.import.module"
_description = "Import Module"
module_file = fields.Binary(string='Module .ZIP file', required=True)
module_file = fields.Binary(string='Module .ZIP file', required=True, attachment=False)
state = fields.Selection([('init', 'init'), ('done', 'done')], string='Status', readonly=True, default='init')
import_message = fields.Char()
force = fields.Boolean(string='Force init', help="Force init mode even if installed. (will update `noupdate='1'` records)")