From 0e65962a16265e9264e1a1876acce80fb1dbde47 Mon Sep 17 00:00:00 2001
From: Josse Colpaert <jco@odoo.com>
Date: Mon, 9 Oct 2017 12:10:36 +0200
Subject: [PATCH 1/6] [FIX] mrp: states are sufficient for Update link in mo
 fixes #19962

---
 addons/mrp/views/mrp_production_views.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/mrp/views/mrp_production_views.xml b/addons/mrp/views/mrp_production_views.xml
index 1886d119b6e..78f2d1e57d3 100644
--- a/addons/mrp/views/mrp_production_views.xml
+++ b/addons/mrp/views/mrp_production_views.xml
@@ -89,7 +89,7 @@
                                 <field name="product_uom_id" options="{'no_open':True,'no_create':True}" groups="product.group_uom" attrs="{'readonly': [('has_moves', '=', True)]}"/>
                                 <button type="action"
                                     name="%(mrp.action_change_production_qty)d"
-                                    string="Update" states="confirmed,planned,progress" class="oe_link" attrs="{'invisible': [('state','=','done')]}"/>
+                                    string="Update" states="confirmed,planned,progress" class="oe_link"/>
                             </div>
                             <field name="bom_id"
                                 domain="['&amp;', '|',

From 5a1e5aa4294cbb375e86636e69963286b56215a5 Mon Sep 17 00:00:00 2001
From: Nicolas Martinelli <nim@odoo.com>
Date: Tue, 3 Oct 2017 15:37:24 +0200
Subject: [PATCH 2/6] [FIX] account: payment communication

- Set up a journal which only accepts SEPA payments
- Import a CAMT file which contains a statement containing:
  No "Ustrd" data
  A "AddtlNtryInf" description longer than 140 characters
- Reconcile the bank statement

A contrain is raised because the communication of the SEPA payment is
longer than 140 characters.

From commit https://github.com/odoo/enterprise/commit/ff84f8b7,
"AddtlNtryInf" is used if "Ustrd" is empty. However, "AddtlNtryInf" and
"Ustrd" do not have the same restrictions. "Ustrd" can have a maximum of
140 characters, while "AddtlNtryInf" can have a maximum of 500
characters.

opw-772009
---
 addons/account/models/account_bank_statement.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/addons/account/models/account_bank_statement.py b/addons/account/models/account_bank_statement.py
index b272de830a7..15fa128cb30 100644
--- a/addons/account/models/account_bank_statement.py
+++ b/addons/account/models/account_bank_statement.py
@@ -830,6 +830,9 @@ class AccountBankStatementLine(models.Model):
             }
             st_line.process_reconciliation(new_aml_dicts=[vals])
 
+    def _get_communication(self, payment_method_id):
+        return self.name or ''
+
     def process_reconciliation(self, counterpart_aml_dicts=None, payment_aml_rec=None, new_aml_dicts=None):
         """ Match statement lines with existing payments (eg. checks) and/or payables/receivables (eg. invoices and refunds) and/or new move lines (eg. write-offs).
             If any new journal item needs to be created (via new_aml_dicts or counterpart_aml_dicts), a new journal entry will be created and will contain those
@@ -928,7 +931,7 @@ class AccountBankStatementLine(models.Model):
                     'state': 'reconciled',
                     'currency_id': currency.id,
                     'amount': abs(total),
-                    'communication': self.name or '',
+                    'communication': self._get_communication(payment_methods[0] if payment_methods else False),
                     'name': self.statement_id.name,
                 })
 

From fcf6ef476ced0953e6faf88b7bbf9881923de4d5 Mon Sep 17 00:00:00 2001
From: Raphael Collet <rco@odoo.com>
Date: Thu, 31 Aug 2017 14:46:34 +0200
Subject: [PATCH 3/6] [FIX] fields: writing on a one2many with a domain should
 not remove all lines

Specifically, the command `(6, 0, ids)` should only unlink/detach the lines
that satisfy to the field's domain.

Test from #18440

opw-756983
---
 .../test_new_api/tests/test_new_fields.py     | 24 +++++++++++++++++++
 odoo/fields.py                                |  9 ++++---
 2 files changed, 28 insertions(+), 5 deletions(-)

diff --git a/odoo/addons/test_new_api/tests/test_new_fields.py b/odoo/addons/test_new_api/tests/test_new_fields.py
index 9deaee1a5f0..dc5b9936c7a 100644
--- a/odoo/addons/test_new_api/tests/test_new_fields.py
+++ b/odoo/addons/test_new_api/tests/test_new_fields.py
@@ -697,6 +697,30 @@ class TestFields(common.TransactionCase):
         self.assertFalse(discussion.very_important_messages)
         self.assertFalse(message.exists())
 
+    def test_70_x2many_write(self):
+        discussion = self.env.ref('test_new_api.discussion_0')
+        Message = self.env['test_new_api.message']
+        # There must be 3 messages, 0 important
+        self.assertEqual(len(discussion.messages), 3)
+        self.assertEqual(len(discussion.important_messages), 0)
+        self.assertEqual(len(discussion.very_important_messages), 0)
+        discussion.important_messages = [(0, 0, {
+            'body': 'What is the answer?',
+            'important': True,
+        })]
+        # There must be 4 messages, 1 important
+        self.assertEqual(len(discussion.messages), 4)
+        self.assertEqual(len(discussion.important_messages), 1)
+        self.assertEqual(len(discussion.very_important_messages), 1)
+        discussion.very_important_messages |= Message.new({
+            'body': '42',
+            'important': True,
+        })
+        # There must be 5 messages, 2 important
+        self.assertEqual(len(discussion.messages), 5)
+        self.assertEqual(len(discussion.important_messages), 2)
+        self.assertEqual(len(discussion.very_important_messages), 2)
+
 
 class TestHtmlField(common.TransactionCase):
 
diff --git a/odoo/fields.py b/odoo/fields.py
index 60aefa9bc25..50209746c10 100644
--- a/odoo/fields.py
+++ b/odoo/fields.py
@@ -2205,14 +2205,13 @@ class One2many(_RelationalMulti):
                 elif act[0] == 6:
                     record = records[-1]
                     comodel.browse(act[2]).write({inverse: record.id})
-                    query = "SELECT id FROM %s WHERE %s=%%s AND id <> ALL(%%s)" % (comodel._table, inverse)
-                    comodel._cr.execute(query, (record.id, act[2] or [0]))
-                    lines = comodel.browse([row[0] for row in comodel._cr.fetchall()])
+                    domain = self.domain(records) if callable(self.domain) else self.domain
+                    domain = domain + [(inverse, 'in', records.ids), ('id', 'not in', act[2] or [0])]
                     inverse_field = comodel._fields[inverse]
                     if inverse_field.ondelete == 'cascade':
-                        lines.unlink()
+                        comodel.search(domain).unlink()
                     else:
-                        lines.write({inverse: False})
+                        comodel.search(domain).write({inverse: False})
 
 
 class Many2many(_RelationalMulti):

From 0e28db88d13255434abf90af01675734d129d798 Mon Sep 17 00:00:00 2001
From: Christophe Matthieu <chm@odoo.com>
Date: Tue, 10 Oct 2017 11:38:02 +0200
Subject: [PATCH 4/6] [FIX] stock: Decimal precision on weight can not be saved

odoo issue: 774361
https://github.com/odoo/odoo/issues/13784
---
 addons/stock/models/stock_config_settings.py | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/addons/stock/models/stock_config_settings.py b/addons/stock/models/stock_config_settings.py
index f8bccb48eab..a8f23d5d5a0 100644
--- a/addons/stock/models/stock_config_settings.py
+++ b/addons/stock/models/stock_config_settings.py
@@ -144,3 +144,15 @@ class StockSettings(models.TransientModel):
             warehouses.mapped('int_type_id').write({'active': active})
 
         return True
+
+    @api.model
+    def get_default_decimal_precision(self, fields):
+        # don't forward-port in v11.0, the API of config wizards changed.
+        digits = self.env.ref('product.decimal_stock_weight').digits
+        return {'decimal_precision': digits}
+
+    @api.multi
+    def set_decimal_precision(self):
+        # don't forward-port in v11.0, the API of config wizards changed.
+        for record in self:
+            self.env.ref('product.decimal_stock_weight').write({'digits': record.decimal_precision})

From e890682656b4739f489d34b954a1b1e8d9f78065 Mon Sep 17 00:00:00 2001
From: Nicolas Martinelli <nim@odoo.com>
Date: Mon, 9 Oct 2017 14:57:16 +0200
Subject: [PATCH 5/6] [FIX] account: invoice analysis

- Create a customer invoice of 100, validate
- Refund the invoice
- Go to Accounting > Reports > Business Intelligence > Invoices
- A total of 200 is shown, while it should be 0.
- The same occurs with a vendor bill (-200 instead of 0)

The invoice lines have their sign modified at two places when used in
the report:
- in method `_compute_price` of `account.invoice.line`
- in method `_from` of `account.invoice.report`

The signs are computed with the following combination:

|Invoice type|`_compute_price`|`_from`|Report sign|
|------------|----------------|-------|-----------|
|out_invoice |              +1|     +1|         +1|
|in_invoice  |              +1|     -1|         -1|
|out_refund  |              -1|     -1|         +1|
|in_refund   |              -1|     +1|         -1|

This is not correct: out_invoice and out_refund should have opposite
signs. Same applies to in_invoice and in_refund.

opw-772479
Closes #19954
---
 addons/account/report/account_invoice_report.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/account/report/account_invoice_report.py b/addons/account/report/account_invoice_report.py
index df6c4c5c2f8..7c6bf726a38 100644
--- a/addons/account/report/account_invoice_report.py
+++ b/addons/account/report/account_invoice_report.py
@@ -141,7 +141,7 @@ class AccountInvoiceReport(models.Model):
                 JOIN (
                     -- Temporary table to decide if the qty should be added or retrieved (Invoice vs Refund) 
                     SELECT id,(CASE
-                         WHEN ai.type::text = ANY (ARRAY['out_refund'::character varying::text, 'in_invoice'::character varying::text])
+                         WHEN ai.type::text = ANY (ARRAY['in_refund'::character varying::text, 'in_invoice'::character varying::text])
                             THEN -1
                             ELSE 1
                         END) AS sign

From b1ce2dd6c163522633572b31f3aba29a21c5c913 Mon Sep 17 00:00:00 2001
From: Nicolas Martinelli <nim@odoo.com>
Date: Tue, 10 Oct 2017 10:24:31 +0200
Subject: [PATCH 6/6] [FIX] account: invoiced amount

- Create 2 companies: A is parent of B.
- Demo is in Company A
- Create 2 invoices for a partner: one in A, one in B (100 each)
- Validate the invoices

Connected as Demo, the 'Invoiced' amount on the partner form view (stat
button) is 100, while clicking on it shows both invoices (total of 200).

There is no need to manually add the company in the `where` clause since
the `_apply_ir_rules` will take care of adding the appropriate
multi-company rules.

opw-772479
---
 addons/account/models/partner.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/account/models/partner.py b/addons/account/models/partner.py
index 08037dc6225..07e6c0e7c5f 100644
--- a/addons/account/models/partner.py
+++ b/addons/account/models/partner.py
@@ -279,7 +279,7 @@ class ResPartner(models.Model):
 
         # generate where clause to include multicompany rules
         where_query = account_invoice_report._where_calc([
-            ('partner_id', 'in', all_partner_ids), ('state', 'not in', ['draft', 'cancel']), ('company_id', '=', self.env.user.company_id.id),
+            ('partner_id', 'in', all_partner_ids), ('state', 'not in', ['draft', 'cancel']),
             ('type', 'in', ('out_invoice', 'out_refund'))
         ])
         account_invoice_report._apply_ir_rules(where_query, 'read')