From 665781d5a8524e73ce2649665d1113d9e6c854d6 Mon Sep 17 00:00:00 2001 From: Yannick Tivisse Date: Thu, 11 Aug 2016 11:27:27 +0530 Subject: [PATCH] [IMP] various: Move all configuration fields from res_company form to the related modules ======= Purpose ======= The company form should be heavily simplified. It's complex to have some settings on the company form, and others on the Settings menu of the related app. It would be much easier to have all settings in Settings menu (res.config) and nothing on the company, even if some of the Settings are multi company. (Stored on the company but set from the Settings menu). --- addons/account/__openerp__.py | 1 - addons/account/models/res_config.py | 11 ++--- addons/account/views/company_view.xml | 26 ------------ addons/account/views/res_config_view.xml | 15 ++++++- addons/auth_ldap/__openerp__.py | 4 +- addons/auth_ldap/models/__init__.py | 1 + .../models/auth_ldap_config_settings.py | 10 +++++ .../views/auth_ldap_config_settings_views.xml | 42 +++++++++++++++++++ addons/auth_ldap/views/res_company_views.xml | 37 ---------------- addons/base_setup/models/res_config.py | 16 +++++++ addons/base_setup/views/res_config_views.xml | 42 +++++++++++++++++++ addons/hr_timesheet_attendance/__openerp__.py | 1 + .../models/__init__.py | 1 + .../models/project_config_settings.py | 9 ++++ ...sheet_attendance_config_settings_views.xml | 18 ++++++++ .../views/hr_timesheet_sheet_views.xml | 18 -------- .../hr_timesheet_sheet_config_settings.py | 1 + .../hr_timesheet_sheet/models/res_company.py | 4 -- ..._timesheet_sheet_config_settings_views.xml | 1 + .../views/hr_timesheet_sheet_views.xml | 25 ----------- addons/l10n_fr_hr_payroll/__openerp__.py | 1 + addons/l10n_fr_hr_payroll/models/__init__.py | 1 + .../l10n_fr_hr_payroll_config_settings.py | 14 +++++++ ...0n_fr_hr_payroll_config_settings_views.xml | 34 +++++++++++++++ .../views/l10n_fr_hr_payroll_view.xml | 21 ---------- addons/mrp/__openerp__.py | 1 - addons/mrp/models/mrp_config_settings.py | 3 ++ .../mrp/views/mrp_config_settings_views.xml | 4 ++ addons/mrp/views/res_company_views.xml | 17 -------- addons/pad/__openerp__.py | 4 +- addons/pad/models/__init__.py | 1 + addons/pad/models/res_config.py | 11 +++++ addons/pad/views/res_company.xml | 16 ------- addons/pad/views/res_config_view.xml | 22 ++++++++++ addons/procurement/__openerp__.py | 1 - .../procurement/views/res_company_views.xml | 20 --------- addons/project/models/res_config.py | 3 ++ addons/project/views/project_views.xml | 14 ------- addons/project/views/res_config_views.xml | 8 ++++ addons/purchase/__openerp__.py | 1 - addons/purchase/models/res_config.py | 8 ++++ addons/purchase/views/res_company_views.xml | 19 --------- addons/purchase/views/res_config_views.xml | 13 ++++++ addons/report/__openerp__.py | 4 +- addons/report/models/__init__.py | 1 + addons/report/models/base_config_settings.py | 19 +++++++++ .../views/base_config_settings_views.xml | 23 ++++++++++ addons/report/views/res_company_views.xml | 25 ----------- addons/sale/models/sale_config_settings.py | 3 ++ .../sale/views/sale_config_settings_views.xml | 9 +++- addons/sale/views/sale_views.xml | 14 ------- addons/sale_stock/__openerp__.py | 1 - .../sale_stock/models/sale_config_settings.py | 1 + addons/sale_stock/views/res_company_views.xml | 16 ------- .../views/sale_config_settings_views.xml | 3 ++ addons/sales_team/views/res_config_view.xml | 2 +- openerp/addons/base/res/res_company_view.xml | 30 ------------- 57 files changed, 350 insertions(+), 321 deletions(-) delete mode 100644 addons/account/views/company_view.xml create mode 100644 addons/auth_ldap/models/auth_ldap_config_settings.py create mode 100644 addons/auth_ldap/views/auth_ldap_config_settings_views.xml delete mode 100644 addons/auth_ldap/views/res_company_views.xml create mode 100644 addons/hr_timesheet_attendance/models/project_config_settings.py create mode 100644 addons/hr_timesheet_attendance/views/hr_timesheet_attendance_config_settings_views.xml create mode 100644 addons/l10n_fr_hr_payroll/models/l10n_fr_hr_payroll_config_settings.py create mode 100644 addons/l10n_fr_hr_payroll/views/l10n_fr_hr_payroll_config_settings_views.xml delete mode 100644 addons/mrp/views/res_company_views.xml create mode 100644 addons/pad/models/res_config.py delete mode 100644 addons/pad/views/res_company.xml create mode 100644 addons/pad/views/res_config_view.xml delete mode 100644 addons/procurement/views/res_company_views.xml delete mode 100644 addons/purchase/views/res_company_views.xml create mode 100644 addons/report/models/base_config_settings.py create mode 100644 addons/report/views/base_config_settings_views.xml delete mode 100644 addons/report/views/res_company_views.xml delete mode 100644 addons/sale_stock/views/res_company_views.xml diff --git a/addons/account/__openerp__.py b/addons/account/__openerp__.py index 477655ac2b6..f3699bff585 100644 --- a/addons/account/__openerp__.py +++ b/addons/account/__openerp__.py @@ -38,7 +38,6 @@ You could use this simplified accounting in case you work with an (external) acc 'views/partner_view.xml', 'views/product_view.xml', 'views/account_analytic_view.xml', - 'views/company_view.xml', 'views/res_config_view.xml', 'views/account_tip_data.xml', 'views/account.xml', diff --git a/addons/account/models/res_config.py b/addons/account/models/res_config.py index 76de3db1d25..be03ef03a0f 100644 --- a/addons/account/models/res_config.py +++ b/addons/account/models/res_config.py @@ -40,13 +40,13 @@ class AccountConfigSettings(models.TransientModel): has_chart_of_accounts = fields.Boolean(string='Company has a chart of accounts') chart_template_id = fields.Many2one('account.chart.template', string='Template', domain="[('visible','=', True)]") - use_anglo_saxon = fields.Boolean(string='Use Anglo-Saxon Accounting', related='company_id.anglo_saxon_accounting') - code_digits = fields.Integer(string='# of Digits', related='company_id.accounts_code_digits', help="No. of digits to use for account code") + use_anglo_saxon = fields.Boolean(string='Use Anglo-Saxon Accounting *', related='company_id.anglo_saxon_accounting') + code_digits = fields.Integer(string='# of Digits *', related='company_id.accounts_code_digits', help="No. of digits to use for account code") tax_calculation_rounding_method = fields.Selection( [ ('round_per_line', 'Round calculation of taxes per line'), ('round_globally', 'Round globally calculation of taxes '), - ], related='company_id.tax_calculation_rounding_method', string='Tax calculation rounding method', + ], related='company_id.tax_calculation_rounding_method', string='Tax calculation rounding method *', help="""If you select 'Round per line' : for each tax, the tax amount will first be computed and rounded for each PO/SO/invoice line and then these rounded amounts will be summed, leading to the total amount for that tax. If you select 'Round globally': for each tax, @@ -58,8 +58,8 @@ class AccountConfigSettings(models.TransientModel): purchase_tax_id = fields.Many2one('account.tax.template', string='Default purchase tax', oldname="purchase_tax") sale_tax_rate = fields.Float(string='Sales tax (%)') purchase_tax_rate = fields.Float(string='Purchase tax (%)') - bank_account_code_prefix = fields.Char(string='Bank Accounts Prefix', related='company_id.bank_account_code_prefix', help='Define the code prefix for the bank accounts', oldname='bank_account_code_char') - cash_account_code_prefix = fields.Char(string='Cash Accounts Prefix', related='company_id.cash_account_code_prefix', help='Define the code prefix for the cash accounts') + bank_account_code_prefix = fields.Char(string='Bank Accounts Prefix *', related='company_id.bank_account_code_prefix', help='Define the code prefix for the bank accounts', oldname='bank_account_code_char') + cash_account_code_prefix = fields.Char(string='Cash Accounts Prefix *', related='company_id.cash_account_code_prefix', help='Define the code prefix for the cash accounts') template_transfer_account_id = fields.Many2one('account.account.template', help="Intermediary account used when moving money from a liquidity account to another") transfer_account_id = fields.Many2one('account.account', related='company_id.transfer_account_id', @@ -143,6 +143,7 @@ class AccountConfigSettings(models.TransientModel): module_account_bank_statement_import_csv = fields.Boolean("Import in .csv format", help='Get your bank statements from your bank and import them in Odoo in the .CSV format.\n' '-This installs the module account_bank_statement_import_csv.') + overdue_msg = fields.Text(related='company_id.overdue_msg', string='Overdue Payments Message *') @api.model diff --git a/addons/account/views/company_view.xml b/addons/account/views/company_view.xml deleted file mode 100644 index a3bd3fac5fc..00000000000 --- a/addons/account/views/company_view.xml +++ /dev/null @@ -1,26 +0,0 @@ - - - - - res.company.form.inherit - - res.company - - - - - - - - - - - - - - - - - - - diff --git a/addons/account/views/res_config_view.xml b/addons/account/views/res_config_view.xml index ba595c74aa8..5840947cf1f 100644 --- a/addons/account/views/res_config_view.xml +++ b/addons/account/views/res_config_view.xml @@ -98,7 +98,7 @@ - + + + + +