[IMP] project, project_issue : fix the escalation, usability improvements on views, tooltips and error messages (onboarding).

addons/project/project.py

@@ -912,7 +912,7 @@ class task(osv.osv):
 
     _constraints = [
         (_check_recursion, 'Error ! You cannot create recursive tasks.', ['parent_ids']),
-        (_check_dates, 'Error ! Task end-date must be greater then task start-date', ['date_start','date_end'])
+        (_check_dates, 'Error ! Task starting date must be lower then its ending date.', ['date_start','date_end'])
     ]
 
     # Override view according to the company definition

addons/project/project_view.xml

@@ -476,7 +476,7 @@
                             <group>
                                 <group string="Gantt View">
                                     <p class="oe_grey" colspan='2'>
-                                        Assign dates to make this task appear in the gantt chart (<span class="oe_form_gantt_avatars"></span> icon on the top right)
+                                        Assign dates to make this task appear in the gantt chart ( <i class="fa fa-tasks"> </i> icon on the top right)
                                     </p>
                                     <field name="date_start"/>
                                     <field name="date_end"/>

addons/project/wizard/project_task_delegate.py

@@ -34,7 +34,7 @@ class project_task_delegate(osv.osv_memory):
         'prefix': fields.char('Your Task Title', help="Title for your validation task"),
         'project_id': fields.many2one('project.project', 'Project', help="User you want to delegate this task to"),
         'user_id': fields.many2one('res.users', 'Assign To', required=True, help="User you want to delegate this task to"),
-        'new_task_description': fields.text('New Task Description', help="Reinclude the description of the task in the task of the user"),
+        'new_task_description': fields.html('New Task Description', help="Reinclude the description of the task in the task of the user"),
         'planned_hours': fields.float('Planned Hours',  help="Estimated time to close this task by the delegated user"),
         'planned_hours_me': fields.float('Hours to Validate', help="Estimated time for you to validate the work done by the user to whom you delegate this task"),
         'state': fields.selection([('pending','Pending'), ('done','Done'), ], 'Validation State', help="New state of your own task. Pending will be reopened automatically when the delegated task is closed")

addons/project_issue/project_issue.py

@@ -196,7 +196,8 @@ class project_issue(osv.Model):
     def _can_escalate(self, cr, uid, ids, field_name, arg, context=None):
         res = {}
         for issue in self.browse(cr, uid, ids, context=context):
-            if issue.project_id.parent_id.type == 'contract':
+            esc_proj = issue.project_id.project_escalation_id
+            if esc_proj and esc_proj.analytic_account_id.type == 'contract':
                 res[issue.id] = True
         return res
 
@@ -260,7 +261,8 @@ class project_issue(osv.Model):
                         domain="[('project_ids', '=', project_id)]", copy=False),
         'project_id': fields.many2one('project.project', 'Project', track_visibility='onchange', select=True),
         'duration': fields.float('Duration'),
-        'task_id': fields.many2one('project.task', 'Task', domain="[('project_id','=',project_id)]"),
+        'task_id': fields.many2one('project.task', 'Task', domain="[('project_id','=',project_id)]",
+            help="You can link this issue to an existing task or directly create a new one from here"),
         'day_open': fields.function(_compute_day, string='Days to Assign',
                                     multi='compute_day', type="float",
                                     store={'project.issue': (lambda self, cr, uid, ids, c={}: ids, ['date_open'], 10)}),

addons/project_issue/project_issue_view.xml

@@ -80,7 +80,6 @@
                             </div>
                         </group>
                         <group>
-                            <field name="id"/>
                             <field name="version_id" groups="base.group_user"/>
                             <field name="priority" groups="base.group_user" widget="priority"/>
                             <label for="task_id" groups="base.group_user"/>
@@ -94,9 +93,10 @@
                         <page string="Description">
                             <field name="description" placeholder="Add an internal note..." groups="base.group_user"/>
                         </page>
-                        <page string="Extra Info" groups="project.group_project_manager,project.group_project_user">
+                        <page string="Extra Info" name="extra_info" groups="project.group_project_manager,project.group_project_user">
                             <group>
-                                <group string="Statistics">
+                                <group>
+                                    <field name="id"/>
                                     <field name="day_open"/>
                                     <field name="day_close"/>
                                     <field name="working_hours_open" widget="float_time"/>
@@ -104,7 +104,7 @@
                                     <field name="inactivity_days"/>
                                     <field name="days_since_creation"/>
                                 </group>
-                                <group string="Status" groups="base.group_no_one">
+                                <group groups="base.group_no_one">
                                     <field name="active"/>
                                 </group>
                             </group>

addons/project_issue_sheet/project_issue_sheet_view.xml

@@ -10,20 +10,17 @@
                     <attribute name="on_change">on_change_project(project_id)</attribute>
                 </field>
                 <field name="active" position="after">
-                    <newline/>
+                    <field name="analytic_account_id"
-                    <group colspan="4"> 
+                        domain="[('parent_id','!=',False),('partner_id', '=', partner_id),('type', '!=', 'view')]"
-                        <field name="analytic_account_id"
+                        on_change='on_change_account_id(analytic_account_id)'/>
-                            domain="[('parent_id','!=',False),('partner_id', '=', partner_id),('type', '!=', 'view')]"
-                            on_change='on_change_account_id(analytic_account_id)'/>
-                    </group>
                 </field>
-                <xpath expr="//notebook/page[@string='Extra Info']" position="before">
+                <xpath expr="//notebook/page[@name='extra_info']" position="before">
                     <page string="Worklogs">
                         <field name="timesheet_ids" colspan="4" nolabel="1" context="{'default_user_id' : uid, 'default_account_id' : analytic_account_id}"
                                 groups="base.group_user">
                             <tree editable="top" string="Timesheets">
                                 <field name="name"/>
-                                <field name="unit_amount" on_change="on_change_unit_amount(product_id, unit_amount, False, product_uom_id,journal_id)" widget="float_time"/>
+                                <field name="unit_amount" string="Duration" on_change="on_change_unit_amount(product_id, unit_amount, False, product_uom_id,journal_id)" widget="float_time"/>
                                 <field name="account_id" invisible="0" domain="[('partner_id', '=', parent.partner_id)]" on_change="on_change_account_id(account_id)" groups="analytic.group_analytic_accounting"/>
                                 <field name="date"/>
                                 <field name="user_id"/>

addons/sale_service/__openerp__.py

@@ -21,7 +21,7 @@
 
 
 {
-    'name': 'Create Tasks on SO',
+    'name': 'Create Tasks from SO',
     'version': '1.0',
     'category': 'Project Management',
     'description': """
@@ -33,10 +33,9 @@ This module will automatically create a new task for each procurement order line
 characteristics:
 
     * Product Type = Service
-    * Procurement Method (Order fulfillment) = MTO (Make to Order)
+    * Create Task Automatically = True
-    * Supply/Procurement Method = Manufacture
 
-If on top of that a projet is specified on the product form (in the Procurement
+If on top of that a project is specified on the product form (in the Procurement
 tab), then the new task will be created in that specific project. Otherwise, the
 new task will not belong to any project, and may be added to a project manually
 later.

addons/sale_stock/sale_stock_view.xml

@@ -39,8 +39,11 @@
                        groups="base.group_user" 
                        on_change="product_id_change_with_wh(parent.pricelist_id,product_id,product_uom_qty,False,product_uos_qty,False,name,parent.partner_id, False, True, parent.date_order, product_packaging, parent.fiscal_position, False, parent.warehouse_id, context)"/>
                    </xpath>
-                   <xpath expr="//field[@name='order_line']/tree//field[@name='product_id']" position="attributes">
+                   <xpath expr="//field[@name='order_line']/form//field[@name='product_id']" position="replace">
-                       <attribute name="on_change">product_id_change_with_wh(parent.pricelist_id,product_id,product_uom_qty,False,product_uos_qty,False,name,parent.partner_id, False, True, parent.date_order, product_packaging, parent.fiscal_position, False, parent.warehouse_id, context)</attribute>
+                       <field name="product_id"
+                       context="{'partner_id':parent.partner_id, 'quantity':product_uom_qty, 'pricelist':parent.pricelist_id, 'uom':product_uom}"
+                       groups="base.group_user"
+                       on_change="product_id_change_with_wh(parent.pricelist_id,product_id,product_uom_qty,False,product_uos_qty,False,name,parent.partner_id, False, True, parent.date_order, product_packaging, parent.fiscal_position, False, parent.warehouse_id, context)"/>
                    </xpath>
                    <xpath expr="//field[@name='order_line']/tree//field[@name='product_uom_qty']" position="attributes">
                        <attribute name="on_change">product_id_change_with_wh(parent.pricelist_id,product_id,product_uom_qty,product_uom,product_uos_qty,False,name,parent.partner_id, False, False, parent.date_order, product_packaging, parent.fiscal_position, True, parent.warehouse_id, context)</attribute>