From 65b67d4cbbf6eb7eef58dc8824373c91b167fa61 Mon Sep 17 00:00:00 2001
From: "Pierrot (prro)" <prro@odoo.com>
Date: Fri, 3 Jun 2022 09:08:35 +0000
Subject: [PATCH] [IMP] account: improve invoice UX

Improvements to the account move form:
- "Reconciled Entries" button -> "Reconciled Items", and goes now to the
    Journal Items list view grouped by Matching number
- Removed the unwanted margin next to the "Journal Items" table (in the
    "Journal Items" tab)
- the partner can be hidden, in the Journal Items list view

task-2855459

Part-of: odoo/odoo#92852
---
 addons/account/models/account_move.py       |  2 +-
 addons/account/views/account_move_views.xml | 18 ++++++++++++++----
 2 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/addons/account/models/account_move.py b/addons/account/models/account_move.py
index fe03b179b2a..2cbab458eef 100644
--- a/addons/account/models/account_move.py
+++ b/addons/account/models/account_move.py
@@ -5714,7 +5714,7 @@ class AccountMoveLine(models.Model):
         return ids
 
     def open_reconcile_view(self):
-        action = self.env['ir.actions.act_window']._for_xml_id('account.action_account_moves_all_a')
+        action = self.env['ir.actions.act_window']._for_xml_id('account.action_account_moves_all_grouped_matching')
         ids = self._reconciled_lines()
         action['domain'] = [('id', 'in', ids)]
         return action
diff --git a/addons/account/views/account_move_views.xml b/addons/account/views/account_move_views.xml
index 35170fdb06d..bf194e4561e 100644
--- a/addons/account/views/account_move_views.xml
+++ b/addons/account/views/account_move_views.xml
@@ -743,7 +743,7 @@
                                     icon="fa-bars"
                                     type="object"
                                     attrs="{'invisible': ['|', '|', ('move_type', '!=', 'entry'), ('id', '=', False), ('has_reconciled_entries', '=', False)]}"
-                                    string="Reconciled Entries">
+                                    string="Reconciled Items">
                             </button>
                             <button name="open_created_caba_entries"
                                     class="oe_stat_button"
@@ -1109,9 +1109,6 @@
                                 </group>
                             </page>
                             <page id="aml_tab" string="Journal Items" groups="account.group_account_readonly">
-                                <div class="alert alert-info text-center mb-0" role="alert" attrs="{'invisible': ['|', ('payment_state', '!=', 'invoicing_legacy'), ('move_type', '=', 'entry')]}">
-                                    <span>This entry has been generated through the Invoicing app, before installing Accounting. Its balance has been imported separately.</span>
-                                </div>
                                 <field name="line_ids"
                                        mode="tree,kanban"
                                        context="{'default_move_type': context.get('default_move_type'), 'line_ids': line_ids, 'journal_id': journal_id, 'default_partner_id': commercial_partner_id, 'default_currency_id': currency_id or company_currency_id}"
@@ -1125,6 +1122,7 @@
                                                }"
                                                domain="[('deprecated', '=', False), ('company_id', '=', parent.company_id)]" />
                                         <field name="partner_id"
+                                               optional="show"
                                                domain="['|', ('parent_id', '=', False), ('is_company', '=', True)]"
                                                attrs="{'column_invisible': [('parent.move_type', '!=', 'entry')]}"/>
                                         <field name="name" widget="section_and_note_text" optional="show"/>
@@ -1242,6 +1240,9 @@
                                       </group>
                                     </form>
                                 </field>
+                                <div class="alert alert-info text-center mb-0" role="alert" attrs="{'invisible': ['|', ('payment_state', '!=', 'invoicing_legacy'), ('move_type', '=', 'entry')]}">
+                                    <span>This entry has been generated through the Invoicing app, before installing Accounting. Its balance has been imported separately.</span>
+                                </div>
                             </page>
                             <page id="other_tab" string="Other Info" name="other_info"
                                   attrs="{'invisible': [('move_type', 'not in', ('out_invoice', 'out_refund', 'in_invoice', 'in_refund'))]}">
@@ -1435,6 +1436,15 @@
             <field name="view_mode">tree,pivot,graph,kanban</field>
         </record>
 
+        <record id="action_account_moves_all_grouped_matching" model="ir.actions.act_window">
+            <field name="context">{'journal_type':'general', 'search_default_group_by_matching': 1, 'search_default_posted':1, 'expand':'1'}</field>
+            <field name="name">Journal Items</field>
+            <field name="res_model">account.move.line</field>
+            <field name="domain">[('display_type', 'not in', ('line_section', 'line_note'))]</field>
+            <field name="view_id" ref="view_move_line_tree_grouped"/>
+            <field name="view_mode">tree,pivot,graph,kanban</field>
+        </record>
+
         <record id="action_account_moves_journal_sales" model="ir.actions.act_window">
             <field name="context">{'journal_type':'sales', 'search_default_group_by_move': 1, 'search_default_posted':1, 'search_default_sales':1, 'name_groupby':1, 'expand': 1}</field>
             <field name="name">Sales</field>