From 64d5cc38996fa4238088c8e541fc64964e8592fa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Tue, 21 Mar 2023 14:02:41 +0000
Subject: [PATCH] [IMP] website_forum: add tests for website/forum count

Add tests for website.forums_count field that should be synchronized manually
with the actual number of forum. Seems it is not working as expected, as
the manual update is not done at forum creation, and the default seems not
correctly computed.

Those tests are therefore red without the upcoming fix.

Task-3240082 (Forum: Reorganize and lint module)

Part-of: odoo/odoo#114841
---
 addons/website_forum/tests/__init__.py        |  1 +
 addons/website_forum/tests/common.py          | 10 ++++
 .../tests/test_forum_internals.py             | 56 ++++++++++++++++++-
 3 files changed, 66 insertions(+), 1 deletion(-)

diff --git a/addons/website_forum/tests/__init__.py b/addons/website_forum/tests/__init__.py
index 1ddabc7f08d..6bfcd2456f9 100644
--- a/addons/website_forum/tests/__init__.py
+++ b/addons/website_forum/tests/__init__.py
@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 
 from . import common
+from . import test_forum_internals
 from . import test_forum_karma_access
 from . import test_forum_tours
 from . import test_web_editor
diff --git a/addons/website_forum/tests/common.py b/addons/website_forum/tests/common.py
index c17d565c7bf..5f6c8f7ee31 100644
--- a/addons/website_forum/tests/common.py
+++ b/addons/website_forum/tests/common.py
@@ -24,6 +24,10 @@ class TestForumCommon(common.TransactionCase):
     def setUpClass(cls):
         super(TestForumCommon, cls).setUpClass()
 
+        # default base data
+        cls.base_website = cls.env.ref("website.default_website")
+        cls.base_forum = cls.env.ref("website_forum.forum_help")
+
         Forum = cls.env['forum.forum']
         Post = cls.env['forum.post']
 
@@ -94,3 +98,9 @@ class TestForumCommon(common.TransactionCase):
             'forum_id': cls.forum.id,
             'parent_id': cls.post.id,
         })
+
+    @classmethod
+    def _activate_multi_website(cls):
+        cls.website_2 = cls.env['website'].create({
+            'name': 'Second Website on same company',
+        })
diff --git a/addons/website_forum/tests/test_forum_internals.py b/addons/website_forum/tests/test_forum_internals.py
index 3f1eebef6b7..3efdabc1514 100644
--- a/addons/website_forum/tests/test_forum_internals.py
+++ b/addons/website_forum/tests/test_forum_internals.py
@@ -2,7 +2,61 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
 from odoo.addons.website_forum.tests.common import KARMA, TestForumCommon
-from odoo.tests import tagged
+from odoo.tests import tagged, users
+
+
+@tagged('forum_internals')
+class TestForumInternals(TestForumCommon):
+
+    @classmethod
+    def setUpClass(cls):
+        super(TestForumInternals, cls).setUpClass()
+        cls._activate_multi_website()
+
+    @users('admin')
+    def test_assert_initial_values(self):
+        """ To ease test setup we support tests only with base data, to avoid
+        having to deal with custom / existing data in various asserts. """
+        forums = self.env['forum.forum'].search([])
+        self.assertEqual(forums, self.base_forum + self.forum)
+        self.assertFalse(forums.website_id)
+
+    @users('admin')
+    def test_website_forums_count(self):
+        """ Test synchronization of website / forum counters. """
+        base_website = self.base_website.with_env(self.env)
+        website_2 = self.website_2.with_env(self.env)
+
+        self.assertEqual(base_website.forums_count, 2,
+                         'Should count default global forums')
+        self.assertEqual(website_2.forums_count, 2,
+                         'Should count default global forums')
+
+        new_forums = self.env['forum.forum'].create([
+            {
+                'name': 'New Global',
+                'website_id': False,
+            }, {
+                'name': 'Base Website',
+                'website_id': base_website.id,
+            }, {
+                'name': 'Website 2',
+                'website_id': website_2.id,
+            }, {
+                'name': 'Website 2.2',
+                'website_id': website_2.id,
+            }
+        ])
+        self.assertEqual(base_website.forums_count, 4,
+                         '3 globals, 1 specific')
+        self.assertEqual(website_2.forums_count, 5,
+                         '3 globals, 2 specific')
+
+        new_forums.write({'website_id': False})
+        self.assertEqual(base_website.forums_count, 6,
+                         '6 global forums')
+        self.assertEqual(website_2.forums_count, 6,
+                         '6 global forums')
 
 
 @tagged('forum_internals')