From 1cdbb47ccda5a5dc3c48f731df5d663de84bbd2e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Thu, 4 Aug 2016 12:55:14 +0200 Subject: [PATCH 1/7] [FIX] account_asset: effectively set default value --- addons/account_asset/wizard/account_asset_change_duration.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/addons/account_asset/wizard/account_asset_change_duration.py b/addons/account_asset/wizard/account_asset_change_duration.py index 8564968434c..8b5f2d06d78 100644 --- a/addons/account_asset/wizard/account_asset_change_duration.py +++ b/addons/account_asset/wizard/account_asset_change_duration.py @@ -54,7 +54,8 @@ class AssetModify(models.TransientModel): if 'method_end' in fields and asset.method_time == 'end': res.update({'method_end': asset.method_end}) if self.env.context.get('active_id'): - res['asset_method_time'] = self._get_asset_method_time() + active_asset = self.env['account.asset.asset'].browse(self.env.context.get('active_id')) + res['asset_method_time'] = active_asset.method_time return res @api.multi From afcd0e1a5893a0dafd645e949c39cba87b8095eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Thu, 4 Aug 2016 12:59:53 +0200 Subject: [PATCH 2/7] [FIX] account_asset: missing at --- addons/account_asset/account_asset.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/account_asset/account_asset.py b/addons/account_asset/account_asset.py index 7db9e20a322..4575adcd3f5 100644 --- a/addons/account_asset/account_asset.py +++ b/addons/account_asset/account_asset.py @@ -532,7 +532,7 @@ class AccountAssetDepreciationLine(models.Model): created_moves.post() return [x.id for x in created_moves] - api.multi + @api.multi def post_lines_and_close_asset(self): # we re-evaluate the assets to determine whether we can close them for line in self: From c3be4c40101e44d99ace384de50cb40fedd6756d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Thu, 4 Aug 2016 12:55:55 +0200 Subject: [PATCH 3/7] [FIX] account_asset: remove duplicate method whose code is less effective --- addons/account_asset/account_asset_invoice.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/addons/account_asset/account_asset_invoice.py b/addons/account_asset/account_asset_invoice.py index a53f2959138..81bc658ac98 100644 --- a/addons/account_asset/account_asset_invoice.py +++ b/addons/account_asset/account_asset_invoice.py @@ -96,11 +96,6 @@ class AccountInvoiceLine(models.Model): self.asset_category_id = self.product_id.product_tmpl_id.asset_category_id return vals - @api.onchange('asset_category_id') - def onchange_asset_category_id(self): - if self.asset_category_id: - self.account_id = self.asset_category_id.account_asset_id - def _set_additional_fields(self, invoice): if not self.asset_category_id: if invoice.type == 'out_invoice': From 0b2127c25fc4cb8d17307eadcdbda748fa06ab06 Mon Sep 17 00:00:00 2001 From: "Denis Vermylen (dve)" Date: Wed, 13 Jul 2016 12:14:22 +0200 Subject: [PATCH 4/7] [MOV] account_asset: reorganise module directory --- addons/account_asset/__init__.py | 3 +-- addons/account_asset/__openerp__.py | 16 ++++++++-------- .../account_asset_data.xml} | 0 .../{ => data}/account_asset_demo.yml | 0 addons/account_asset/models/__init__.py | 5 +++++ .../account_asset/{ => models}/account_asset.py | 0 .../account_invoice.py} | 0 ...t_view.xml => account_asset_report_views.xml} | 0 ...unt_asset.xml => account_asset_templates.xml} | 0 ...nt_asset_view.xml => account_asset_views.xml} | 0 ...nvoice_view.xml => account_invoice_views.xml} | 0 addons/account_asset/wizard/__init__.py | 4 ++-- ...=> asset_depreciation_confirmation_wizard.py} | 0 ...t_depreciation_confirmation_wizard_views.xml} | 0 ..._asset_change_duration.py => asset_modify.py} | 0 ..._duration_view.xml => asset_modify_views.xml} | 0 16 files changed, 16 insertions(+), 12 deletions(-) rename addons/account_asset/{account_asset_cron.xml => data/account_asset_data.xml} (100%) rename addons/account_asset/{ => data}/account_asset_demo.yml (100%) create mode 100644 addons/account_asset/models/__init__.py rename addons/account_asset/{ => models}/account_asset.py (100%) rename addons/account_asset/{account_asset_invoice.py => models/account_invoice.py} (100%) rename addons/account_asset/report/{account_asset_report_view.xml => account_asset_report_views.xml} (100%) rename addons/account_asset/views/{account_asset.xml => account_asset_templates.xml} (100%) rename addons/account_asset/views/{account_asset_view.xml => account_asset_views.xml} (100%) rename addons/account_asset/views/{account_asset_invoice_view.xml => account_invoice_views.xml} (100%) rename addons/account_asset/wizard/{wizard_asset_compute.py => asset_depreciation_confirmation_wizard.py} (100%) rename addons/account_asset/wizard/{wizard_asset_compute_view.xml => asset_depreciation_confirmation_wizard_views.xml} (100%) rename addons/account_asset/wizard/{account_asset_change_duration.py => asset_modify.py} (100%) rename addons/account_asset/wizard/{account_asset_change_duration_view.xml => asset_modify_views.xml} (100%) diff --git a/addons/account_asset/__init__.py b/addons/account_asset/__init__.py index f826640892b..ee052fe0c50 100644 --- a/addons/account_asset/__init__.py +++ b/addons/account_asset/__init__.py @@ -1,6 +1,5 @@ # -*- coding: utf-8 -*- -import account_asset -import account_asset_invoice +import models import wizard import report diff --git a/addons/account_asset/__openerp__.py b/addons/account_asset/__openerp__.py index f323fe820b5..a59e1b13aba 100644 --- a/addons/account_asset/__openerp__.py +++ b/addons/account_asset/__openerp__.py @@ -15,7 +15,7 @@ Keeps track of depreciations, and creates corresponding journal entries. 'category': 'Accounting', 'sequence': 32, 'demo': [ - 'account_asset_demo.yml', + 'data/account_asset_demo.yml', ], # 'test': [ # '../account/test/account_minimal_test.xml', @@ -24,13 +24,13 @@ Keeps track of depreciations, and creates corresponding journal entries. 'data': [ 'security/account_asset_security.xml', 'security/ir.model.access.csv', - 'wizard/account_asset_change_duration_view.xml', - 'wizard/wizard_asset_compute_view.xml', - 'views/account_asset_view.xml', - 'views/account_asset_invoice_view.xml', - 'report/account_asset_report_view.xml', - 'views/account_asset.xml', - 'account_asset_cron.xml', + 'wizard/asset_depreciation_confirmation_wizard_views.xml', + 'wizard/asset_modify_views.xml', + 'views/account_asset_views.xml', + 'views/account_invoice_views.xml', + 'views/account_asset_templates.xml', + 'report/account_asset_report_views.xml', + 'data/account_asset_data.xml', ], 'qweb': [ "static/src/xml/account_asset_template.xml", diff --git a/addons/account_asset/account_asset_cron.xml b/addons/account_asset/data/account_asset_data.xml similarity index 100% rename from addons/account_asset/account_asset_cron.xml rename to addons/account_asset/data/account_asset_data.xml diff --git a/addons/account_asset/account_asset_demo.yml b/addons/account_asset/data/account_asset_demo.yml similarity index 100% rename from addons/account_asset/account_asset_demo.yml rename to addons/account_asset/data/account_asset_demo.yml diff --git a/addons/account_asset/models/__init__.py b/addons/account_asset/models/__init__.py new file mode 100644 index 00000000000..a34a91f91b1 --- /dev/null +++ b/addons/account_asset/models/__init__.py @@ -0,0 +1,5 @@ +# -*- coding: utf-8 -*- +# Part of Odoo. See LICENSE file for full copyright and licensing details. + +import account_asset +import account_asset_invoice diff --git a/addons/account_asset/account_asset.py b/addons/account_asset/models/account_asset.py similarity index 100% rename from addons/account_asset/account_asset.py rename to addons/account_asset/models/account_asset.py diff --git a/addons/account_asset/account_asset_invoice.py b/addons/account_asset/models/account_invoice.py similarity index 100% rename from addons/account_asset/account_asset_invoice.py rename to addons/account_asset/models/account_invoice.py diff --git a/addons/account_asset/report/account_asset_report_view.xml b/addons/account_asset/report/account_asset_report_views.xml similarity index 100% rename from addons/account_asset/report/account_asset_report_view.xml rename to addons/account_asset/report/account_asset_report_views.xml diff --git a/addons/account_asset/views/account_asset.xml b/addons/account_asset/views/account_asset_templates.xml similarity index 100% rename from addons/account_asset/views/account_asset.xml rename to addons/account_asset/views/account_asset_templates.xml diff --git a/addons/account_asset/views/account_asset_view.xml b/addons/account_asset/views/account_asset_views.xml similarity index 100% rename from addons/account_asset/views/account_asset_view.xml rename to addons/account_asset/views/account_asset_views.xml diff --git a/addons/account_asset/views/account_asset_invoice_view.xml b/addons/account_asset/views/account_invoice_views.xml similarity index 100% rename from addons/account_asset/views/account_asset_invoice_view.xml rename to addons/account_asset/views/account_invoice_views.xml diff --git a/addons/account_asset/wizard/__init__.py b/addons/account_asset/wizard/__init__.py index 0425aadb5d8..21a4fb76a53 100644 --- a/addons/account_asset/wizard/__init__.py +++ b/addons/account_asset/wizard/__init__.py @@ -1,4 +1,4 @@ # -*- coding: utf-8 -*- -import account_asset_change_duration -import wizard_asset_compute +import asset_depreciation_confirmation_wizard +import asset_modify diff --git a/addons/account_asset/wizard/wizard_asset_compute.py b/addons/account_asset/wizard/asset_depreciation_confirmation_wizard.py similarity index 100% rename from addons/account_asset/wizard/wizard_asset_compute.py rename to addons/account_asset/wizard/asset_depreciation_confirmation_wizard.py diff --git a/addons/account_asset/wizard/wizard_asset_compute_view.xml b/addons/account_asset/wizard/asset_depreciation_confirmation_wizard_views.xml similarity index 100% rename from addons/account_asset/wizard/wizard_asset_compute_view.xml rename to addons/account_asset/wizard/asset_depreciation_confirmation_wizard_views.xml diff --git a/addons/account_asset/wizard/account_asset_change_duration.py b/addons/account_asset/wizard/asset_modify.py similarity index 100% rename from addons/account_asset/wizard/account_asset_change_duration.py rename to addons/account_asset/wizard/asset_modify.py diff --git a/addons/account_asset/wizard/account_asset_change_duration_view.xml b/addons/account_asset/wizard/asset_modify_views.xml similarity index 100% rename from addons/account_asset/wizard/account_asset_change_duration_view.xml rename to addons/account_asset/wizard/asset_modify_views.xml From d43cdd696ccd8e6f2c477a2e756f9a300120cbce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Thu, 4 Aug 2016 11:50:45 +0200 Subject: [PATCH 5/7] =?UTF-8?q?[SPL]=20account=5Fasset:=20split=20files=20?= =?UTF-8?q?according=20to=20models=C3=A9?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- addons/account_asset/__openerp__.py | 1 + addons/account_asset/models/__init__.py | 4 +++- addons/account_asset/models/account.py | 23 +++++++++++++++++++ addons/account_asset/models/account_asset.py | 20 ---------------- .../account_asset/models/account_invoice.py | 16 ------------- addons/account_asset/models/product.py | 19 +++++++++++++++ .../views/account_asset_views.xml | 14 +---------- addons/account_asset/views/product_views.xml | 16 +++++++++++++ 8 files changed, 63 insertions(+), 50 deletions(-) create mode 100644 addons/account_asset/models/account.py create mode 100644 addons/account_asset/models/product.py create mode 100644 addons/account_asset/views/product_views.xml diff --git a/addons/account_asset/__openerp__.py b/addons/account_asset/__openerp__.py index a59e1b13aba..5ec4d3e4c65 100644 --- a/addons/account_asset/__openerp__.py +++ b/addons/account_asset/__openerp__.py @@ -29,6 +29,7 @@ Keeps track of depreciations, and creates corresponding journal entries. 'views/account_asset_views.xml', 'views/account_invoice_views.xml', 'views/account_asset_templates.xml', + 'views/product_views.xml', 'report/account_asset_report_views.xml', 'data/account_asset_data.xml', ], diff --git a/addons/account_asset/models/__init__.py b/addons/account_asset/models/__init__.py index a34a91f91b1..458b4b1b230 100644 --- a/addons/account_asset/models/__init__.py +++ b/addons/account_asset/models/__init__.py @@ -1,5 +1,7 @@ # -*- coding: utf-8 -*- # Part of Odoo. See LICENSE file for full copyright and licensing details. +import account import account_asset -import account_asset_invoice +import account_invoice +import product diff --git a/addons/account_asset/models/account.py b/addons/account_asset/models/account.py new file mode 100644 index 00000000000..f2ee6075f74 --- /dev/null +++ b/addons/account_asset/models/account.py @@ -0,0 +1,23 @@ +# -*- coding: utf-8 -*- + +from openerp import api, fields, models + + +class AccountMove(models.Model): + _inherit = 'account.move' + + asset_depreciation_ids = fields.One2many('account.asset.depreciation.line', 'move_id', string='Assets Depreciation Lines', ondelete="restrict") + + @api.multi + def button_cancel(self): + for move in self: + for line in move.asset_depreciation_ids: + line.move_posted_check = False + return super(AccountMove, self).button_cancel() + + @api.multi + def post(self): + for move in self: + for depreciation_line in move.asset_depreciation_ids: + depreciation_line.post_lines_and_close_asset() + return super(AccountMove, self).post() diff --git a/addons/account_asset/models/account_asset.py b/addons/account_asset/models/account_asset.py index 4575adcd3f5..1587731342b 100644 --- a/addons/account_asset/models/account_asset.py +++ b/addons/account_asset/models/account_asset.py @@ -573,23 +573,3 @@ class AccountAssetDepreciationLine(models.Model): msg = _("You cannot delete posted installment lines.") raise UserError(msg) return super(AccountAssetDepreciationLine, self).unlink() - - -class AccountMove(models.Model): - _inherit = 'account.move' - - asset_depreciation_ids = fields.One2many('account.asset.depreciation.line', 'move_id', string='Assets Depreciation Lines', ondelete="restrict") - - @api.multi - def button_cancel(self): - for move in self: - for line in move.asset_depreciation_ids: - line.move_posted_check = False - return super(AccountMove, self).button_cancel() - - @api.multi - def post(self): - for move in self: - for depreciation_line in move.asset_depreciation_ids: - depreciation_line.post_lines_and_close_asset() - return super(AccountMove, self).post() diff --git a/addons/account_asset/models/account_invoice.py b/addons/account_asset/models/account_invoice.py index 81bc658ac98..c188260e33c 100644 --- a/addons/account_asset/models/account_invoice.py +++ b/addons/account_asset/models/account_invoice.py @@ -103,19 +103,3 @@ class AccountInvoiceLine(models.Model): elif invoice.type == 'in_invoice': self.asset_category_id = self.product_id.product_tmpl_id.asset_category_id.id super(AccountInvoiceLine, self)._set_additional_fields(invoice) - - -class ProductTemplate(models.Model): - _inherit = 'product.template' - asset_category_id = fields.Many2one('account.asset.category', string='Asset Type', company_dependent=True, ondelete="restrict") - deferred_revenue_category_id = fields.Many2one('account.asset.category', string='Deferred Revenue Type', company_dependent=True, ondelete="restrict") - - - @api.multi - def _get_asset_accounts(self): - res = super(ProductTemplate, self)._get_asset_accounts() - if self.asset_category_id: - res['stock_input'] = self.property_account_expense_id - if self.deferred_revenue_category_id: - res['stock_output'] = self.property_account_income_id - return res \ No newline at end of file diff --git a/addons/account_asset/models/product.py b/addons/account_asset/models/product.py new file mode 100644 index 00000000000..10177f4f37d --- /dev/null +++ b/addons/account_asset/models/product.py @@ -0,0 +1,19 @@ +# -*- coding: utf-8 -*- + +from openerp import api, fields, models + + +class ProductTemplate(models.Model): + _inherit = 'product.template' + + asset_category_id = fields.Many2one('account.asset.category', string='Asset Type', company_dependent=True, ondelete="restrict") + deferred_revenue_category_id = fields.Many2one('account.asset.category', string='Deferred Revenue Type', company_dependent=True, ondelete="restrict") + + @api.multi + def _get_asset_accounts(self): + res = super(ProductTemplate, self)._get_asset_accounts() + if self.asset_category_id: + res['stock_input'] = self.property_account_expense_id + if self.deferred_revenue_category_id: + res['stock_output'] = self.property_account_income_id + return res diff --git a/addons/account_asset/views/account_asset_views.xml b/addons/account_asset/views/account_asset_views.xml index b4d5f7ec837..1a54a50880a 100644 --- a/addons/account_asset/views/account_asset_views.xml +++ b/addons/account_asset/views/account_asset_views.xml @@ -235,19 +235,7 @@ - - - Product Template (form) - product.template - - - - - - - + Assets diff --git a/addons/account_asset/views/product_views.xml b/addons/account_asset/views/product_views.xml new file mode 100644 index 00000000000..57f8c00c27a --- /dev/null +++ b/addons/account_asset/views/product_views.xml @@ -0,0 +1,16 @@ + + + + + Product Template (form) + product.template + + + + + + + + \ No newline at end of file From 62a1c97d37fbf6c61cd64187bf6b33342e021316 Mon Sep 17 00:00:00 2001 From: "Denis Vermylen (dve)" Date: Mon, 1 Aug 2016 09:59:43 +0200 Subject: [PATCH 6/7] [MIG] account_asset: Migrate to new API --- addons/account_asset/__init__.py | 1 + addons/account_asset/__openerp__.py | 8 +------- addons/account_asset/models/account.py | 1 + addons/account_asset/models/account_asset.py | 7 ++++--- addons/account_asset/models/account_invoice.py | 11 +++++------ addons/account_asset/models/product.py | 1 + addons/account_asset/report/__init__.py | 1 + addons/account_asset/report/account_asset_report.py | 10 ++++++---- addons/account_asset/test/account_asset_demo_test.xml | 2 +- addons/account_asset/tests/__init__.py | 3 +-- addons/account_asset/tests/test_account_asset.py | 9 +++++---- addons/account_asset/views/account_asset_views.xml | 1 + addons/account_asset/views/account_invoice_views.xml | 2 +- addons/account_asset/wizard/__init__.py | 1 + .../wizard/asset_depreciation_confirmation_wizard.py | 4 +++- addons/account_asset/wizard/asset_modify.py | 8 +++++--- 16 files changed, 38 insertions(+), 32 deletions(-) diff --git a/addons/account_asset/__init__.py b/addons/account_asset/__init__.py index ee052fe0c50..8f7bf4b27dd 100644 --- a/addons/account_asset/__init__.py +++ b/addons/account_asset/__init__.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# Part of Odoo. See LICENSE file for full copyright and licensing details. import models import wizard diff --git a/addons/account_asset/__openerp__.py b/addons/account_asset/__openerp__.py index 5ec4d3e4c65..20737a9887f 100644 --- a/addons/account_asset/__openerp__.py +++ b/addons/account_asset/__openerp__.py @@ -1,8 +1,8 @@ # -*- coding: utf-8 -*- +# Part of Odoo. See LICENSE file for full copyright and licensing details. { 'name': 'Assets Management', - 'version': '1.0', 'depends': ['account_accountant'], 'description': """ Assets management @@ -17,10 +17,6 @@ Keeps track of depreciations, and creates corresponding journal entries. 'demo': [ 'data/account_asset_demo.yml', ], - # 'test': [ - # '../account/test/account_minimal_test.xml', - # 'test/account_asset_demo_test.xml', - # ], 'data': [ 'security/account_asset_security.xml', 'security/ir.model.access.csv', @@ -36,6 +32,4 @@ Keeps track of depreciations, and creates corresponding journal entries. 'qweb': [ "static/src/xml/account_asset_template.xml", ], - 'installable': True, - 'application': False, } diff --git a/addons/account_asset/models/account.py b/addons/account_asset/models/account.py index f2ee6075f74..a0e7f76d459 100644 --- a/addons/account_asset/models/account.py +++ b/addons/account_asset/models/account.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# Part of Odoo. See LICENSE file for full copyright and licensing details. from openerp import api, fields, models diff --git a/addons/account_asset/models/account_asset.py b/addons/account_asset/models/account_asset.py index 1587731342b..e681f5ac37d 100644 --- a/addons/account_asset/models/account_asset.py +++ b/addons/account_asset/models/account_asset.py @@ -1,11 +1,12 @@ # -*- coding: utf-8 -*- +# Part of Odoo. See LICENSE file for full copyright and licensing details. from datetime import date, datetime from dateutil.relativedelta import relativedelta -from openerp import api, fields, models, _ -from openerp.exceptions import UserError, ValidationError -from openerp.tools import DEFAULT_SERVER_DATE_FORMAT as DF +from odoo import api, fields, models, _ +from odoo.exceptions import UserError, ValidationError +from odoo.tools import DEFAULT_SERVER_DATE_FORMAT as DF class AccountAssetCategory(models.Model): diff --git a/addons/account_asset/models/account_invoice.py b/addons/account_asset/models/account_invoice.py index c188260e33c..7f4782dfb25 100644 --- a/addons/account_asset/models/account_invoice.py +++ b/addons/account_asset/models/account_invoice.py @@ -1,12 +1,12 @@ # -*- coding: utf-8 -*- +# Part of Odoo. See LICENSE file for full copyright and licensing details. from datetime import datetime from dateutil.relativedelta import relativedelta -from openerp import api, fields, models -from openerp.exceptions import Warning -from openerp.tools.translate import _ -import openerp.addons.decimal_precision as dp -from openerp.tools import DEFAULT_SERVER_DATE_FORMAT as DF +from odoo import api, fields, models +from odoo.tools import DEFAULT_SERVER_DATE_FORMAT as DF + +import odoo.addons.decimal_precision as dp class AccountInvoice(models.Model): @@ -85,7 +85,6 @@ class AccountInvoiceLine(models.Model): self.onchange_asset_category_id() return result - @api.onchange('product_id') def _onchange_product_id(self): vals = super(AccountInvoiceLine, self)._onchange_product_id() diff --git a/addons/account_asset/models/product.py b/addons/account_asset/models/product.py index 10177f4f37d..42472f88e5d 100644 --- a/addons/account_asset/models/product.py +++ b/addons/account_asset/models/product.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# Part of Odoo. See LICENSE file for full copyright and licensing details. from openerp import api, fields, models diff --git a/addons/account_asset/report/__init__.py b/addons/account_asset/report/__init__.py index c60e4c9e043..8f70e34da0e 100644 --- a/addons/account_asset/report/__init__.py +++ b/addons/account_asset/report/__init__.py @@ -1,3 +1,4 @@ # -*- coding: utf-8 -*- +# Part of Odoo. See LICENSE file for full copyright and licensing details. import account_asset_report diff --git a/addons/account_asset/report/account_asset_report.py b/addons/account_asset/report/account_asset_report.py index 1cafe349079..d743f64c6fb 100644 --- a/addons/account_asset/report/account_asset_report.py +++ b/addons/account_asset/report/account_asset_report.py @@ -1,5 +1,7 @@ # -*- coding: utf-8 -*- -from openerp import fields, models, tools +# Part of Odoo. See LICENSE file for full copyright and licensing details. + +from odoo import api, fields, models class AssetAssetReport(models.Model): @@ -24,9 +26,9 @@ class AssetAssetReport(models.Model): unposted_value = fields.Float(string='Unposted Amount', readonly=True) company_id = fields.Many2one('res.company', string='Company', readonly=True) - def init(self, cr): - tools.drop_view_if_exists(cr, 'asset_asset_report') - cr.execute(""" + @api.model_cr + def init(self): + self._cr.execute(""" create or replace view asset_asset_report as ( select min(dl.id) as id, diff --git a/addons/account_asset/test/account_asset_demo_test.xml b/addons/account_asset/test/account_asset_demo_test.xml index c85a45707cd..c9e85df7323 100644 --- a/addons/account_asset/test/account_asset_demo_test.xml +++ b/addons/account_asset/test/account_asset_demo_test.xml @@ -1,4 +1,4 @@ - + diff --git a/addons/account_asset/wizard/__init__.py b/addons/account_asset/wizard/__init__.py index 21a4fb76a53..e793ab075f7 100644 --- a/addons/account_asset/wizard/__init__.py +++ b/addons/account_asset/wizard/__init__.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# Part of Odoo. See LICENSE file for full copyright and licensing details. import asset_depreciation_confirmation_wizard import asset_modify diff --git a/addons/account_asset/wizard/asset_depreciation_confirmation_wizard.py b/addons/account_asset/wizard/asset_depreciation_confirmation_wizard.py index a7925dc4475..00b3fd3e36e 100644 --- a/addons/account_asset/wizard/asset_depreciation_confirmation_wizard.py +++ b/addons/account_asset/wizard/asset_depreciation_confirmation_wizard.py @@ -1,5 +1,7 @@ # -*- coding: utf-8 -*- -from openerp import api, fields, models, _ +# Part of Odoo. See LICENSE file for full copyright and licensing details. + +from odoo import api, fields, models, _ class AssetDepreciationConfirmationWizard(models.TransientModel): diff --git a/addons/account_asset/wizard/asset_modify.py b/addons/account_asset/wizard/asset_modify.py index 8b5f2d06d78..9f8ce7cd497 100644 --- a/addons/account_asset/wizard/asset_modify.py +++ b/addons/account_asset/wizard/asset_modify.py @@ -1,9 +1,11 @@ # -*- coding: utf-8 -*- +# Part of Odoo. See LICENSE file for full copyright and licensing details. + from lxml import etree -from openerp import api, fields, models -from openerp.osv.orm import setup_modifiers -from openerp.tools.translate import _ +from odoo import api, fields, models, _ +from odoo.osv.orm import setup_modifiers + class AssetModify(models.TransientModel): _name = 'asset.modify' From 5a859b8d389c6911bcb37db0b95668b6bad1a55b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Thu, 4 Aug 2016 12:59:26 +0200 Subject: [PATCH 7/7] [FIX][IMP] account_asset: method_time / prorata thingy - on account.asset.asset form view, field method_time, in 'Depreciation Information' page: use radio widget instead (without it, you couldn't change the field) - on account.asset.category form view: prorata field hidden when required, and set to false when method_time is on 'Ending Date'. (It was previously possible for the prorata to be true while the method_time was 'Ending Date', which is invalid) --- addons/account_asset/models/account_asset.py | 5 +++++ addons/account_asset/views/account_asset_views.xml | 7 ++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/addons/account_asset/models/account_asset.py b/addons/account_asset/models/account_asset.py index e681f5ac37d..a1606eecef8 100644 --- a/addons/account_asset/models/account_asset.py +++ b/addons/account_asset/models/account_asset.py @@ -50,6 +50,11 @@ class AccountAssetCategory(models.Model): else: self.method_period = 12 + @api.onchange('method_time') + def _onchange_method_time(self): + if self.method_time != 'number': + self.prorata = False + class AccountAssetAsset(models.Model): _name = 'account.asset.asset' diff --git a/addons/account_asset/views/account_asset_views.xml b/addons/account_asset/views/account_asset_views.xml index 5dbfb2b9f1b..9fc6b426868 100644 --- a/addons/account_asset/views/account_asset_views.xml +++ b/addons/account_asset/views/account_asset_views.xml @@ -58,7 +58,7 @@ - + @@ -177,10 +177,7 @@ -