From 64008bdcabe2b2583319e42d7a69a813878982a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Theys?= Date: Tue, 13 Aug 2019 16:35:28 +0000 Subject: [PATCH] [FIX] sale_product_matrix: fix traceback with no_variants attributes To reproduce the issue: - configure a product with no_variant attributes - select "grid" mode - add this product to a sales order - fill the grid - confirm -> Traceback closes odoo/odoo#35701 Signed-off-by: Damien Bouvy (dbo) --- addons/sale_product_matrix/models/sale_order.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/addons/sale_product_matrix/models/sale_order.py b/addons/sale_product_matrix/models/sale_order.py index 724b87f2dfc..ef46303ea0e 100644 --- a/addons/sale_product_matrix/models/sale_order.py +++ b/addons/sale_product_matrix/models/sale_order.py @@ -96,14 +96,11 @@ class SaleOrder(models.Model): if not default_so_line_vals: OrderLine = self.env['sale.order.line'] default_so_line_vals = OrderLine.default_get(OrderLine._fields.keys()) - pnvav = [] # product no variant attribute values - for nvav in no_variant_attribute_values: - pnvav.append((4, nvav)) new_lines.append((0, 0, dict( default_so_line_vals, product_id=product.id, product_uom_qty=qty, - product_no_variant_attribute_value_ids=pnvav) + product_no_variant_attribute_value_ids=no_variant_attribute_values.ids) )) if new_lines: self.update(dict(order_line=new_lines))