From 63d0fea17608fd3ad0b8ab9e2829ee4d4253d172 Mon Sep 17 00:00:00 2001
From: "Benjamin Frantzen (bfr)" <bfr@odoo.com>
Date: Wed, 8 Apr 2020 07:07:13 +0000
Subject: [PATCH] [FIX] account: reference field appear on account.move form

- Specifically, it did not appear for misc operations & credit notes
- Currency only appear if group_multi_currency
- Fix label for journal_id appearing based on group

closes odoo/odoo#49671

X-original-commit: 62e54cb8960cd84484d462dc8c7d7c1e89a9eacd
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
---
 addons/account/views/account_move_views.xml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/addons/account/views/account_move_views.xml b/addons/account/views/account_move_views.xml
index 62ad2bfc10b..24271b3f917 100644
--- a/addons/account/views/account_move_views.xml
+++ b/addons/account/views/account_move_views.xml
@@ -612,6 +612,7 @@
                                 <label for="ref" string="Bill Reference"
                                        attrs="{'invisible':[('move_type', 'not in', ('in_invoice', 'in_receipt', 'in_refund'))]}" />
                                 <field name="ref" nolabel="1" attrs="{'invisible':[('move_type', 'not in', ('in_invoice', 'in_receipt', 'in_refund'))]}" />
+                                <field name="ref" attrs="{'invisible':[('move_type', 'in', ('in_invoice', 'in_receipt', 'in_refund', 'out_invoice', 'out_refund'))]}"/>
                                 <field name="payment_reference"
                                        attrs="{'invisible': ['|',('move_type', 'not in', ('out_invoice', 'out_refund', 'in_invoice', 'in_refund', 'out_receipt', 'in_receipt')), ('state', '=', 'draft')], 'readonly': [('state', '!=', 'draft')]}"/>
                                 <field name="partner_bank_id"
@@ -657,6 +658,7 @@
                                 </div>
 
                                 <label for="journal_id"
+                                       groups="account.group_account_readonly"
                                        invisible="context.get('default_journal_id') and context.get('move_type', 'entry') != 'entry'"/>
                                 <div class="d-flex" invisible="context.get('default_journal_id') and context.get('move_type', 'entry') != 'entry'">
                                     <field name="journal_id"
@@ -664,12 +666,12 @@
                                         options="{'no_create': True}"
                                         attrs="{'readonly': [('posted_before', '=', True)]}"/>
                                     <span class="oe_inline o_form_label mx-3 oe_read_only"
-                                        groups="account.group_account_readonly"> in </span>
+                                        groups="account.group_account_readonly,base.group_multi_currency"> in </span>
                                     <!-- Bigger margin on the left because in edit mode the external link button covers the text -->
                                     <span class="oe_inline o_form_label mr-3 ml-5 oe_edit_only"
-                                        groups="account.group_account_readonly"> in </span>
+                                        groups="account.group_account_readonly,base.group_multi_currency"> in </span>
                                     <field name="currency_id"
-                                        groups="account.group_account_readonly"
+                                        groups="account.group_account_readonly,base.group_multi_currency"
                                         attrs="{'readonly': [('posted_before', '=', True)]}"/>
                                 </div>
                             </group>