From 62f6dc8af373b5ff1958def6d7bc15bde1cd4dfa Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Mon, 21 Jun 2021 16:52:31 +0000
Subject: [PATCH] [IMP] sale: clean product sale warning onchange part

Simplify the code, and do not instantiate useless variables when not
needed.
---
 addons/sale/models/sale_order_line.py | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/addons/sale/models/sale_order_line.py b/addons/sale/models/sale_order_line.py
index a6c0fa86c58..d858c298916 100644
--- a/addons/sale/models/sale_order_line.py
+++ b/addons/sale/models/sale_order_line.py
@@ -625,20 +625,16 @@ class SaleOrderLine(models.Model):
             vals['price_unit'] = self.env['account.tax']._fix_tax_included_price_company(self._get_display_price(product), product.taxes_id, self.tax_id, self.company_id)
         self.update(vals)
 
-        title = False
-        message = False
-        result = {}
-        warning = {}
         if product.sale_line_warn != 'no-message':
-            title = _("Warning for %s", product.name)
-            message = product.sale_line_warn_msg
-            warning['title'] = title
-            warning['message'] = message
-            result = {'warning': warning}
             if product.sale_line_warn == 'block':
                 self.product_id = False
 
-        return result
+            return {
+                'warning': {
+                    'title': _("Warning for %s", product.name),
+                    'message': product.sale_line_warn_msg,
+                }
+            }
 
     @api.onchange('product_uom', 'product_uom_qty')
     def product_uom_change(self):