From 62b736be2dc896c6c52e0ccb992ed0d406c6a081 Mon Sep 17 00:00:00 2001
From: tsm-odoo <tsm@odoo.com>
Date: Fri, 17 Mar 2023 10:16:58 +0000
Subject: [PATCH] [FIX] mail: download logs

- disable when no logs available
- log file contains undefined in its name

Part-of: odoo/odoo#115677
---
 addons/mail/static/src/rtc/call_settings.js  | 21 ++++++++++----------
 addons/mail/static/src/rtc/call_settings.xml |  2 +-
 addons/mail/static/src/rtc/rtc_service.js    |  2 --
 3 files changed, 12 insertions(+), 13 deletions(-)

diff --git a/addons/mail/static/src/rtc/call_settings.js b/addons/mail/static/src/rtc/call_settings.js
index 7b71fb0fecf..025e7fe4eba 100644
--- a/addons/mail/static/src/rtc/call_settings.js
+++ b/addons/mail/static/src/rtc/call_settings.js
@@ -62,16 +62,17 @@ export class CallSettings extends Component {
     }
 
     onClickDownloadLogs() {
-        const data = window.JSON.stringify(Object.fromEntries(this.rtc.state.logs));
-        const blob = new window.Blob([data], { type: "application/json" });
-        const url = window.URL.createObjectURL(blob);
-        const a = document.createElement("a");
-        a.href = url;
-        a.download = `RtcLogs_Channel_${this.rtc.state.logs.channelId}_Session_${
-            this.rtc.state.logs.selfSessionId
-        }_${luxon.DateTime.now().toFormat("yyyy-ll-dd_HH-mm")}.json`;
-        a.click();
-        window.URL.revokeObjectURL(url);
+        const data = JSON.stringify(Object.fromEntries(this.rtc.state.logs));
+        const blob = new Blob([data], { type: "application/json" });
+        const downloadLink = document.createElement("a");
+        const channelId = this.rtc.state.logs.get("channelId");
+        const sessionId = this.rtc.state.logs.get("selfSessionId");
+        const now = luxon.DateTime.now().toFormat("yyyy-ll-dd_HH-mm");
+        downloadLink.download = `RtcLogs_Channel_${channelId}_Session_${sessionId}_${now}.json`;
+        const url = URL.createObjectURL(blob);
+        downloadLink.href = url;
+        downloadLink.click();
+        URL.revokeObjectURL(url);
     }
 
     onClickRegisterKeyButton() {
diff --git a/addons/mail/static/src/rtc/call_settings.xml b/addons/mail/static/src/rtc/call_settings.xml
index 0b702b11313..fb18b5533e6 100644
--- a/addons/mail/static/src/rtc/call_settings.xml
+++ b/addons/mail/static/src/rtc/call_settings.xml
@@ -98,7 +98,7 @@
                     </label>
                 </div>
                 <div t-if="userSettings.logRtc" class="mb-3 d-flex align-items-center flex-wrap">
-                    <button class="btn btn-primary" t-on-click="onClickDownloadLogs">Download logs</button>
+                    <button class="btn btn-primary" t-att-disabled="rtc.state.logs.size === 0" t-on-click="onClickDownloadLogs">Download logs</button>
                 </div>
             </div>
         </div>
diff --git a/addons/mail/static/src/rtc/rtc_service.js b/addons/mail/static/src/rtc/rtc_service.js
index 5821462f20e..ca26a8e646a 100644
--- a/addons/mail/static/src/rtc/rtc_service.js
+++ b/addons/mail/static/src/rtc/rtc_service.js
@@ -1464,8 +1464,6 @@ export const rtcService = {
                 }
             }
         });
-        // debugging. remove this
-        window.rtc = rtc;
         return rtc;
     },
 };