From a02c514038afe4bc48211338bd642fd8a35b47d2 Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Mon, 20 Sep 2010 13:09:37 +0530
Subject: [PATCH 01/19] [REM] mrp_repair: Shortcuts removed from wizard
 buttons.

bzr revid: uco@tinyerp.com-20100920073937-er2gv772cm2m9oyr
---
 addons/mrp_repair/wizard/mrp_repair_cancel_view.xml       | 4 ++--
 addons/mrp_repair/wizard/mrp_repair_make_invoice_view.xml | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/mrp_repair/wizard/mrp_repair_cancel_view.xml b/addons/mrp_repair/wizard/mrp_repair_cancel_view.xml
index 811551aedbf..e307580be7b 100644
--- a/addons/mrp_repair/wizard/mrp_repair_cancel_view.xml
+++ b/addons/mrp_repair/wizard/mrp_repair_cancel_view.xml
@@ -14,8 +14,8 @@
 				    <newline/>
 				    <group col="2" colspan="4">
                 		<button icon="gtk-stop" special="cancel"
-                			string="_No" />
-                		<button name="cancel_repair" string="_Yes"
+                			string="No" />
+                		<button name="cancel_repair" string="Yes"
                 			colspan="1" type="object" icon="gtk-ok" />
                 	</group>
                 </form>
diff --git a/addons/mrp_repair/wizard/mrp_repair_make_invoice_view.xml b/addons/mrp_repair/wizard/mrp_repair_make_invoice_view.xml
index 62edf984b20..982ee5d4bc0 100644
--- a/addons/mrp_repair/wizard/mrp_repair_make_invoice_view.xml
+++ b/addons/mrp_repair/wizard/mrp_repair_make_invoice_view.xml
@@ -15,8 +15,8 @@
                     <newline/>  
                     <group col="2" colspan="4">                        
                 		<button icon="gtk-stop" special="cancel"
-                			string="_Cancel" />
-                		<button name="make_invoices" string="Create _Invoice"
+                			string="Cancel" />
+                		<button name="make_invoices" string="Create Invoice"
                 			colspan="1" type="object" icon="terp-dolar" />
                 	</group>
                 </form>

From 95d4cfd7f529ff6d869c150bdd137bfeaa3f5fea Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Mon, 20 Sep 2010 14:38:26 +0530
Subject: [PATCH 02/19] [IMP] point_of_sale: Report improved.

bzr revid: uco@tinyerp.com-20100920090826-r7hoy19n9ne7njqs
---
 addons/point_of_sale/report/pos_receipt.rml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/point_of_sale/report/pos_receipt.rml b/addons/point_of_sale/report/pos_receipt.rml
index e722687f094..46a19714234 100644
--- a/addons/point_of_sale/report/pos_receipt.rml
+++ b/addons/point_of_sale/report/pos_receipt.rml
@@ -104,7 +104,7 @@
         <para style="terp_default_Centre_9">E-mail : [[ address and address.email ]]</para>
         <para style="terp_default_Centre_9">Shop : [[ o.shop_id.name ]]</para>
         <para style="terp_default_Centre_9">Vendeur : [[ o.user_salesman_id.name ]]</para>
-        <para style="terp_default_Centre_9">Date : [[ formatLang(o.date_order,date = True) ]]</para>
+        <para style="terp_default_Centre_9">Date : [[ formatLang(o.date_order,date_time = True) ]]</para>
         <para style="P4">
             <font color="white"> </font>
         </para>

From 8ba31fc711e01b9ae48ad6b3fe26b34ea1bd8d4a Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Mon, 20 Sep 2010 14:54:10 +0530
Subject: [PATCH 03/19] [FIX] mrp_repair: Repair order Quotation/Order report
 error corrected.

bzr revid: uco@tinyerp.com-20100920092410-v6othao2y8tofyn3
---
 addons/mrp_repair/report/order.py  |  2 +-
 addons/mrp_repair/report/order.rml | 14 +++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/addons/mrp_repair/report/order.py b/addons/mrp_repair/report/order.py
index 298e1f237ff..9ed63548e18 100644
--- a/addons/mrp_repair/report/order.py
+++ b/addons/mrp_repair/report/order.py
@@ -48,7 +48,7 @@ class order(report_sxw.rml_parse):
             res_partner_address = pooler.get_pool(self.cr.dbname).get('res.partner.address')
             addresses = res_partner.address_get(self.cr, self.uid, [partner.id], [type])
             adr_id = addresses and addresses[type] or False
-            return adr_id and res_partner_address.read(self.cr, self.uid, [adr_id])[0] or False
+            return adr_id and res_partner_address.read(self.cr, self.uid, [adr_id])[0] or {}
 
 report_sxw.report_sxw('report.repair.order','mrp.repair','addons/mrp_repair/report/order.rml',parser=order)
 
diff --git a/addons/mrp_repair/report/order.rml b/addons/mrp_repair/report/order.rml
index c71abb614cf..b3c1855260b 100644
--- a/addons/mrp_repair/report/order.rml
+++ b/addons/mrp_repair/report/order.rml
@@ -175,7 +175,7 @@
           <para style="P3">
             <font color="white"> </font>
           </para>
-          <para style="P13">Invoice address</para>
+          <para style="P13">Invoice address :</para>
           <para style="P3">[[ o.partner_id and o.partner_id.property_payment_term.name ]]</para>
           <para style="P3">[[ o.partner_invoice_id.street ]]</para>
           <para style="P3">[[ o.partner_invoice_id.street2 or removeParentNode('para') ]]</para>
@@ -189,12 +189,12 @@
           </para>
         </td>
         <td>
-          <para style="P3">[[ o.partner_id.name ]]</para>
-          <para style="P3">[[ o.partner_id and adr_get(o.partner_id, 'default')['street'] ]]</para>
-          <para style="P3">[[ o.partner_id and adr_get(o.partner_id, 'default')['street2'] or removeParentNode('para') ]]</para>
-          <para style="P3">[[ o.partner_id and adr_get(o.partner_id, 'default')['zip'] ]][[ o.partner_id and adr_get(o.partner_id, 'default')['city'] ]]</para>
-          <para style="P3">[[ (o.partner_id and adr_get(o.partner_id, 'default')['state_id'] and adr_get(o.partner_id, 'default')['state_id'][1]) or removeParentNode('para') ]]</para>
-          <para style="P3">[[ o.partner_id and adr_get(o.partner_id, 'default')['country_id'] and adr_get(o.partner_id, 'default')['country_id'][1] ]]</para>
+          <para style="P3">[[ o.partner_id.name or removeParentNode('para') ]]</para>
+          <para style="P3">[[ o.partner_id and adr_get(o.partner_id, 'default').get('street','') or removeParentNode('para') ]]</para>
+          <para style="P3">[[ o.partner_id and adr_get(o.partner_id, 'default').get('street2','') or removeParentNode('para') ]]</para>
+          <para style="P3">[[ o.partner_id and adr_get(o.partner_id, 'default').get('zip','') or removeParentNode('para') ]][[ o.partner_id and adr_get(o.partner_id, 'default').get('city','') or removeParentNode('para') ]]</para>
+          <para style="P3">[[ (o.partner_id and adr_get(o.partner_id, 'default').get('state_id','') and adr_get(o.partner_id, 'default').get('state_id',[])[1]) or removeParentNode('para') ]]</para>
+          <para style="P3">[[ o.partner_id and adr_get(o.partner_id, 'default').get('country_id','') and adr_get(o.partner_id, 'default').get('country_id',[])[1] or removeParentNode('para') ]]</para>
           <para style="P3">
             <font color="white"> </font>
           </para>

From 787b398e4e8bc3b786d85fae608beef85b28f6a0 Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Tue, 21 Sep 2010 12:21:06 +0530
Subject: [PATCH 04/19] [IMP] auction: View improvements. Tooltips corrected.

bzr revid: uco@tinyerp.com-20100921065106-7nk61eaduimku3dq
---
 addons/auction/auction.py       |  41 ++++++------
 addons/auction/auction_view.xml | 109 ++++++++++++++++++--------------
 2 files changed, 84 insertions(+), 66 deletions(-)

diff --git a/addons/auction/auction.py b/addons/auction/auction.py
index 5ea2441e6fd..cd468d56d8a 100644
--- a/addons/auction/auction.py
+++ b/addons/auction/auction.py
@@ -37,7 +37,8 @@ class auction_artists(osv.osv):
     _columns = {
         'name': fields.char('Artist/Author Name', size=64, required=True),
         'pseudo': fields.char('Pseudo', size=64),
-        'birth_death_dates':fields.char('Birth / Death dates', size=64),
+        'birth_date':fields.date('Birth date'),
+        'death_date':fields.date('Death date'),
         'biography': fields.text('Biography'),
     }
 auction_artists()
@@ -72,14 +73,14 @@ class auction_dates(osv.osv):
 
     _columns = {
         'name': fields.char('Auction Name', size=64, required=True),
-        'expo1': fields.date('First Exposition Day', required=True, help="Beginning Exposition Date For Auction"),
-        'expo2': fields.date('Last Exposition Day', required=True, help="Last Exposition Date For Auction"),
-        'auction1': fields.date('First Auction Day', required=True, help="Start Date Of Auction"),
-        'auction2': fields.date('Last Auction Day', required=True, help="End Date Of Auction"),
-        'journal_id': fields.many2one('account.journal', 'Buyer Journal', required=True, help="Account Journal For Buyer"),
-        'journal_seller_id': fields.many2one('account.journal', 'Seller Journal', required=True, help="Account Journal For Seller"),
-        'buyer_costs': fields.many2many('account.tax', 'auction_buyer_taxes_rel', 'auction_id', 'tax_id', 'Buyer Costs', help="Account Tax For Buyer"),
-        'seller_costs': fields.many2many('account.tax', 'auction_seller_taxes_rel', 'auction_id', 'tax_id', 'Seller Costs', help="Account Tax For Seller"),
+        'expo1': fields.date('First Exposition Day', required=True, help="Beginning exposition date for auction"),
+        'expo2': fields.date('Last Exposition Day', required=True, help="Last exposition date for auction"),
+        'auction1': fields.date('First Auction Day', required=True, help="Start date of auction"),
+        'auction2': fields.date('Last Auction Day', required=True, help="End date of auction"),
+        'journal_id': fields.many2one('account.journal', 'Buyer Journal', required=True, help="Account journal for buyer"),
+        'journal_seller_id': fields.many2one('account.journal', 'Seller Journal', required=True, help="Account journal for seller"),
+        'buyer_costs': fields.many2many('account.tax', 'auction_buyer_taxes_rel', 'auction_id', 'tax_id', 'Buyer Costs', help="Account tax for buyer"),
+        'seller_costs': fields.many2many('account.tax', 'auction_seller_taxes_rel', 'auction_id', 'tax_id', 'Seller Costs', help="Account tax for seller"),
         'acc_income': fields.many2one('account.account', 'Income Account', required=True),
         'acc_expense': fields.many2one('account.account', 'Expense Account', required=True),
         'adj_total': fields.function(_adjudication_get, method=True, string='Total Adjudication', store=True),
@@ -355,15 +356,15 @@ class auction_lots(osv.osv):
 
     _columns = {
         'bid_lines':fields.one2many('auction.bid_line', 'lot_id', 'Bids'),
-        'auction_id': fields.many2one('auction.dates', 'Auction', select=1, help="Auction For Object"),
-        'bord_vnd_id': fields.many2one('auction.deposit', 'Depositer Inventory', required=True, help="Provide Deposit Information: seller, Withdrawned Method, Object, Deposit Costs"),
-        'name': fields.char('Title', size=64, required=True, help='Auction Object Name'),
+        'auction_id': fields.many2one('auction.dates', 'Auction', select=1, help="Auction for object"),
+        'bord_vnd_id': fields.many2one('auction.deposit', 'Depositer Inventory', required=True, help="Provide deposit information: seller, Withdrawned Method, Object, Deposit Costs"),
+        'name': fields.char('Title', size=64, required=True, help='Auction object name'),
         'name2': fields.char('Short Description (2)', size=64),
         'lot_type': fields.selection(_type_get, 'Object category', size=64),
-        'author_right': fields.many2one('account.tax', 'Author rights', help="Account Tax For Author Commission"),
+        'author_right': fields.many2one('account.tax', 'Author rights', help="Account tax for author commission"),
         'lot_est1': fields.float('Minimum Estimation', help="Minimum Estimate Price"),
         'lot_est2': fields.float('Maximum Estimation', help="Maximum Estimate Price"),
-        'lot_num': fields.integer('List Number', required=True, select=1, help="List Number In Depositer Inventory"),
+        'lot_num': fields.integer('List Number', required=True, select=1, help="List number in depositer inventory"),
         'create_uid': fields.many2one('res.users', 'Created by', readonly=True),
         'history_ids':fields.one2many('auction.lot.history', 'lot_id', 'Auction history'),
         'lot_local':fields.char('Location', size=64, help="Auction Location"),
@@ -380,15 +381,15 @@ class auction_lots(osv.osv):
         'ach_login': fields.char('Buyer Username', size=64),
         'ach_uid': fields.many2one('res.partner', 'Buyer'),
         'seller_id': fields.related('bord_vnd_id','partner_id', type='many2one', relation='res.partner', string='Seller', readonly=True),
-        'ach_emp': fields.boolean('Taken Away', readonly=True, help="When state is Taken Away, This field is Marked as True"),
-        'is_ok': fields.boolean('Buyer\'s payment', help="When Buyer Pay For Bank statement', This field is Marked"),
+        'ach_emp': fields.boolean('Taken Away', readonly=True, help="When state is Taken Away, this field is marked as True"),
+        'is_ok': fields.boolean('Buyer\'s payment', help="When buyer pay for bank statement', this field is marked"),
         'ach_inv_id': fields.many2one('account.invoice', 'Buyer Invoice', readonly=True, states={'draft':[('readonly', False)]}),
         'sel_inv_id': fields.many2one('account.invoice', 'Seller Invoice', readonly=True, states={'draft':[('readonly', False)]}),
         'vnd_lim': fields.float('Seller limit'),
         'vnd_lim_net': fields.boolean('Net limit ?', readonly=True),
         'image': fields.binary('Image', help="Object Image"),
-        'paid_vnd':fields.function(_getprice, string='Seller Paid', method=True, type='boolean', store=True, multi="paid_vnd", help="When state of Seller Invoice is 'Paid', This field is selected as True."),
-        'paid_ach':fields.function(_getprice, string='Buyer Invoice Reconciled', method=True, type='boolean', store=True, multi="paid_ach", help="When state of Buyer Invoice is 'Paid', This field is selected as True."),
+        'paid_vnd':fields.function(_getprice, string='Seller Paid', method=True, type='boolean', store=True, multi="paid_vnd", help="When state of Seller Invoice is 'Paid', this field is selected as True."),
+        'paid_ach':fields.function(_getprice, string='Buyer Invoice Reconciled', method=True, type='boolean', store=True, multi="paid_ach", help="When state of Buyer Invoice is 'Paid', this field is selected as True."),
         'state': fields.selection((
             ('draft', 'Draft'),
             ('unsold', 'Unsold'),
@@ -404,7 +405,7 @@ class auction_lots(osv.osv):
         'gross_revenue':fields.function(_getprice, method=True, string='Gross revenue', store=True, multi="gross_revenue", help="Buyer Price - Seller Price"),
         'gross_margin':fields.function(_getprice, method=True, string='Gross Margin (%)', store=True, multi="gross_margin", help="(Gross Revenue*100.0)/ Object Price"),
         'costs':fields.function(_getprice, method=True, string='Indirect costs', store=True, multi="costs", help="Deposit cost"),
-        'statement_id': fields.many2many('account.bank.statement.line', 'auction_statement_line_rel', 'auction_id', 'statement', 'Payment', help="Bank statement Line For Given Buyer"),
+        'statement_id': fields.many2many('account.bank.statement.line', 'auction_statement_line_rel', 'auction_id', 'statement', 'Payment', help="Bank statement line for given buyer"),
         'net_revenue':fields.function(_getprice, method=True, string='Net revenue', store=True, multi="net_revenue", help="Buyer Price - Seller Price - Indirect Cost"),
         'net_margin':fields.function(_getprice, method=True, string='Net Margin (%)', store=True, multi="net_margin", help="(Net Revenue * 100)/ Object Price"),
     }
@@ -761,7 +762,7 @@ class auction_bid(osv.osv):
     _order = 'id desc'
     _columns = {
         'partner_id': fields.many2one('res.partner', 'Buyer Name', required=True),
-        'contact_tel':fields.char('Contact', size=64),
+        'contact_tel':fields.char('Contact Number', size=64),
         'name': fields.char('Bid ID', size=64, required=True),
         'auction_id': fields.many2one('auction.dates', 'Auction Date', required=True),
         'bid_lines': fields.one2many('auction.bid_line', 'bid_id', 'Bid'),
diff --git a/addons/auction/auction_view.xml b/addons/auction/auction_view.xml
index f91f77429ca..c01efdb1f5f 100644
--- a/addons/auction/auction_view.xml
+++ b/addons/auction/auction_view.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <openerp>
 <data>
-    <menuitem name="Auction Management" id="auction_menu_root" icon="terp-purchase" sequence="26" groups="base.group_system"/>
+    <menuitem name="Auction" id="auction_menu_root" icon="terp-purchase" sequence="26" groups="base.group_system"/>
     <menuitem name="Configuration" parent="auction_menu_root" id="auction_config_menu" sequence="7"/>
     <menuitem name="Tools Bar Codes" id="auction_outils_menu" parent="auction_menu_root" sequence="5" />
     <menuitem name="Deliveries Management" action="action_auction_taken" id="menu_wizard_emporte" parent="auction_outils_menu"/>
@@ -14,9 +14,10 @@
         <field name="type">tree</field>
         <field name="arch" type="xml">
             <tree string="Artists">
-            <field name="name"/>
-                <field name="birth_death_dates"/>
-                <field name="biography"/>
+	            <field name="name"/>
+	            <field name="birth_date"/>
+	            <field name="death_date"/>
+	            <field name="biography"/>
             </tree>
         </field>
     </record>
@@ -26,12 +27,16 @@
         <field name="type">form</field>
         <field name="arch" type="xml">
             <form string="Artists">
-                <field colspan="4" name="name" select="1"/>
-                <field colspan="4" name="pseudo" select="1"/>
-                    <newline/>
-                <field colspan="4" name="birth_death_dates"/>
-                    <newline/>
-                <field colspan="4" name="biography"/>
+                <separator string="Author/Artist" colspan="4"/>
+                <group colspan="4" col="6">
+	                <field name="name" colspan="4" string="Name"/>
+	                <newline/>
+	                <field name="pseudo"/>
+	                <field name="birth_date"/>
+	                <field name="death_date"/>
+                </group>
+                <separator string="Biography" colspan="4"/>
+                <field name="biography" nolabel="1" colspan="4"/>
             </form>
         </field>
     </record>
@@ -105,27 +110,39 @@
                 <field name="name" colspan="2" select="1"/>
                 <notebook colspan="4">
                     <page string="Auction Dates">
-                        <separator string="Exposition Dates" colspan="4"/>
-                        <field name="expo1"/>
-                        <field name="expo2"/>
-                        <separator string="Auction Dates" colspan="4"/>
-                        <field name="auction1" select="1"/>
-                        <field name="auction2" select="1"/>
+                        <group colspan="4" col="4">
+                            <group colspan="2" col="2">
+		                        <separator string="Exposition Dates" colspan="4"/>
+		                        <field name="expo1"/>
+		                        <field name="expo2"/>
+		                    </group>
+		                    <group colspan="2" col="2">
+				                <separator string="Auction Dates" colspan="4"/>
+		                        <field name="auction1" select="1"/>
+		                        <field name="auction2" select="1"/>
+		                    </group>
+                        </group>
                         <separator string="" colspan="4"/>
                         <field name="state"/>
                         <button name="close" states="draft" string="Create Invoices" type="object" colspan="2" icon="gtk-yes"/>
                     </page>
                     <page string="Accounting" >
-                        <separator string="Accounting" colspan="4"/>
-                        <field name="acc_expense" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]"/>
-                        <field name="acc_income" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]"/>
-                        <separator string="Analytic" colspan="4"/>
-                        <field name="journal_id"/>
-                        <field name="journal_seller_id"/>
-                        <field name="account_analytic_id" groups="base.group_extended"/>
+                        <group colspan="4" col="4">
+                            <group colspan="2" col="2">
+		                        <separator string="Accounting" colspan="4"/>
+		                        <field name="acc_expense" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]"/>
+		                        <field name="acc_income" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]"/>
+	                        </group>
+	                        <group colspan="2" col="2">
+		                        <separator string="Analytic" colspan="4"/>
+		                        <field name="journal_id"/>
+		                        <field name="journal_seller_id"/>
+		                        <field name="account_analytic_id" groups="base.group_extended"/>
+		                    </group>
+                        </group>
                     </page>
                     <page string="Commissions">
-                        <group col="4" colspan="4">
+                        <group col="4" colspan="4" expand="1">
                             <group col="2" colspan="4">
                                <separator string="Buyer Commissions" colspan="4"/>
                                 <field name="buyer_costs" domain="[('parent_id','=',False),('domain','=','auction'),('type_tax_use','&lt;&gt;','sale')]" nolabel="1" colspan="4"/>
@@ -332,13 +349,10 @@
                             </form>
                         </field>
                     </page>
-                    <page string="Note">
-                        <field name="obj_desc" colspan="4" nolabel="1"/>
-                    </page>
                     <page string="History" groups="base.group_extended">
                             <group colspan="2" col="2">
                                 <field name="statement_id" domain="[('state','=','draft')]" colspan="4" nolabel="1"
-                                    widget="one2many_list">
+                                    height="575" width="285" widget="one2many_list">
                                     <tree string="Buyer's Payment History">
                                         <field name="statement_id"/>
                                         <field name="amount"/>
@@ -352,14 +366,12 @@
                                         <field name="account_id"/>
                                         <field name="type"/>
                                         <field name="statement_id"/>
-                                        <field name="reconcile_id"/>
                                         <field name="amount"/>
-                                        <field name="reconcile_amount"/>
                                     </form>
                                 </field>
                             </group>
                             <group colspan="2" col="2">
-                               <field name="history_ids" colspan="4" readonly="1" nolabel="1">
+                               <field name="history_ids" colspan="4" readonly="1" nolabel="1" height="575">
                                   <tree string="History">
                                      <field name="name"/>
                                      <field name="lot_id"/>
@@ -369,6 +381,9 @@
                                </field>
                             </group>
                     </page>
+                    <page string="Notes">
+                        <field name="obj_desc" colspan="4" nolabel="1"/>
+                    </page>
                 </notebook>
            </form>
         </field>
@@ -450,8 +465,7 @@
         src_model="auction.lots"
         id="act_auction_lot_open_bid"/>
 
-    <menuitem name="Objects" parent="auction_menu_root" id="auction_objects_menu" sequence="2"/>
-    <menuitem name="Objects" action="action_all_objects" parent="auction_objects_menu" id="auction_all_objects_menu"/>
+    <menuitem name="Objects" action="action_all_objects" parent="auction_date_menu" id="auction_all_objects_menu"/>
 
     <record model="ir.ui.view" id="view_deposit_border_form">
         <field name="name">auction.deposit.form</field>
@@ -459,14 +473,15 @@
         <field name="type">form</field>
         <field name="arch" type="xml">
             <form string="Deposit Border Form">
-               <field name="name" select="1"/>
-               <field name="date_dep" select="1"/>
-               <field name="partner_id" select="1"/>
-               <field name="method"/>
-               <newline/>
-               <field name="tax_id" domain="[('domain','=','auction'),('parent_id','=',False),('type_tax_use','&lt;&gt;','purchase')]"/>
-               <field name="transfer"/>
-               <newline/>
+                <group colspan="4" col="6">
+	               <field name="name" string="Reference"/>
+	               <field name="date_dep"/>
+	               <field name="partner_id"/>
+	               <newline/>
+	               <field name="method"/>
+	               <field name="tax_id" domain="[('domain','=','auction'),('parent_id','=',False),('type_tax_use','&lt;&gt;','purchase')]"/>
+	               <field name="transfer"/>
+	            </group>
                <notebook colspan="4">
                 <page string="General Information">
                  <field name="lot_id" colspan="4" mode="tree,graph" nolabel="1">
@@ -640,11 +655,13 @@
         <field name="model">auction.bid</field>
         <field name="arch" type="xml">
             <form string="Bids">
-                <field name="name" select="1"/>
-                 <field name="auction_id" select="1"/>
-                <newline/>
-                <field name="partner_id" select="1" on_change="onchange_contact(partner_id)"/>
-                <field  name="contact_tel"/>
+                <group colspan="4" col="6">
+	                <field name="name"/>
+	                <field name="auction_id"/>
+	                <field name="contact_tel"/>
+	                <newline/>
+	                <field name="partner_id" on_change="onchange_contact(partner_id)" colspan="4"/>
+                </group>
                 <field name="bid_lines" colspan="4" nolabel="1">
                     <tree string="Bids Lines" editable="bottom">
                         <field name="lot_id" domain="[('auction_id','=',parent.auction_id)]"/>

From ab0d9433c4b5a4323de387c2642dc3a48c3501b5 Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Tue, 21 Sep 2010 17:44:29 +0530
Subject: [PATCH 05/19] [ADD] auction: Added two fields to maintain invoice
 history of seller and buyer.

bzr revid: uco@tinyerp.com-20100921121429-r76je2pfwumyuib0
---
 addons/auction/auction.py       | 27 +++++++++++++++++++++++
 addons/auction/auction_view.xml | 39 ++++++++++++++++++++++++++++++++-
 2 files changed, 65 insertions(+), 1 deletion(-)

diff --git a/addons/auction/auction.py b/addons/auction/auction.py
index cd468d56d8a..4fb99a2efbf 100644
--- a/addons/auction/auction.py
+++ b/addons/auction/auction.py
@@ -70,6 +70,31 @@ class auction_dates(osv.osv):
         reads = self.read(cr, uid, ids, ['name', 'auction1'], context)
         name = [(r['id'], '['+r['auction1']+'] '+ r['name']) for r in reads]
         return name
+    
+    def _get_buyer_invoice(self, cr, uid, ids, name, arg, context={}):
+        lots_obj = self.pool.get('auction.lots')
+        result = {}
+        for data in self.browse(cr, uid, ids):
+            inv_ids = []
+            lots_ids = lots_obj.search(cr, uid, [('auction_id','=',data.id),('ach_inv_id','!=',False)])
+            for lot in lots_obj.browse(cr, uid, lots_ids):
+                if lot.ach_inv_id:
+                    inv_ids.append(lot.ach_inv_id.id)
+            result[data.id] = inv_ids
+        return result
+    
+    def _get_seller_invoice(self, cr, uid, ids, name, arg, context={}):
+        lots_obj = self.pool.get('auction.lots')
+        lots_ids = lots_obj.search(cr, uid, [('auction_id','in',ids)])
+        result = {}
+        for data in self.browse(cr, uid, ids):
+            inv_ids = []
+            lots_ids = lots_obj.search(cr, uid, [('auction_id','=',data.id),('sel_inv_id','!=',False)])
+            for lot in lots_obj.browse(cr, uid, lots_ids):
+                if lot.sel_inv_id:
+                    inv_ids.append(lot.sel_inv_id.id)
+            result[data.id] = inv_ids
+        return result
 
     _columns = {
         'name': fields.char('Auction Name', size=64, required=True),
@@ -87,6 +112,8 @@ class auction_dates(osv.osv):
         'state': fields.selection((('draft', 'Draft'), ('closed', 'Closed')), 'State', select=1, readonly=True,
                                   help='When auction starts the state is \'Draft\'.\n At the end of auction, the state becomes \'Closed\'.'),
         'account_analytic_id': fields.many2one('account.analytic.account', 'Analytic Account', required=True),
+        'buyer_invoice_history': fields.function(_get_buyer_invoice, relation='account.invoice', method=True, string="Buyer Invoice", type='many2many'),
+        'seller_invoice_history': fields.function(_get_seller_invoice, relation='account.invoice', method=True, string="Seller Invoice", type='many2many'),
     }
 
     _defaults = {
diff --git a/addons/auction/auction_view.xml b/addons/auction/auction_view.xml
index c01efdb1f5f..1ec39f8c0f0 100644
--- a/addons/auction/auction_view.xml
+++ b/addons/auction/auction_view.xml
@@ -17,7 +17,6 @@
 	            <field name="name"/>
 	            <field name="birth_date"/>
 	            <field name="death_date"/>
-	            <field name="biography"/>
             </tree>
         </field>
     </record>
@@ -153,6 +152,44 @@
                              </group>
                         </group>
                     </page>
+                    <page string="History">
+                        <group colspan="4" col="4">
+                            <group colspan="2" col="2">
+                                <separator string="Buyer Invoices" colspan="2"/>
+                                <field name="buyer_invoice_history" nolabel="1" widget="one2many_list"
+                                        height="400">
+                                    <tree colors="blue:state in ('draft');black:state in ('proforma','proforma2','open');gray:state in ('cancel')" string="Invoice">
+					                    <field name="date_invoice"/>
+					                    <field name="number"/>
+					                    <field name="partner_id" groups="base.group_user"/>
+					                    <field name="name"/>
+					                    <field name="company_id" groups="base.group_multi_company" widget="selection"/>
+					                    <field name="user_id"/>
+					                    <field name="date_due"/>
+					                    <field name="origin"/>
+                                        <field name="state"/>
+                                    </tree>
+                                </field>
+                            </group>
+                            <group colspan="2" col="2">
+                                <separator string="Seller Invoices" colspan="2"/>
+                                <field name="seller_invoice_history" nolabel="1" widget="one2many_list"
+                                        height="400">
+                                    <tree colors="blue:state in ('draft');black:state in ('proforma','proforma2','open');gray:state in ('cancel')" string="Invoice">
+                                        <field name="date_invoice"/>
+                                        <field name="number"/>
+                                        <field name="partner_id" groups="base.group_user"/>
+                                        <field name="name"/>
+                                        <field name="company_id" groups="base.group_multi_company" widget="selection"/>
+                                        <field name="user_id"/>
+                                        <field name="date_due"/>
+                                        <field name="origin"/>
+                                        <field name="state"/>
+                                    </tree>
+                                </field>
+                            </group>
+                        </group>
+                    </page>
                 </notebook>
             </form>
         </field>

From 91e5b3a0583bc0583cd14df175229899a2bb4c70 Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Tue, 21 Sep 2010 17:47:11 +0530
Subject: [PATCH 06/19] [REF] auction: Field name changed according to new
 changes.

bzr revid: uco@tinyerp.com-20100921121711-3tvhrcxbys9avm3b
---
 addons/auction/auction_demo.xml   | 6 ++++--
 addons/auction/report/artists.xml | 3 ++-
 addons/auction/test/auction.yml   | 3 ++-
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/addons/auction/auction_demo.xml b/addons/auction/auction_demo.xml
index a26e5355cde..94ee1ec98a2 100644
--- a/addons/auction/auction_demo.xml
+++ b/addons/auction/auction_demo.xml
@@ -144,12 +144,14 @@
 
     <record model="auction.artists" id="auction_art_1">
         <field name="name">Philippe Lavilier</field>
-        <field name="birth_death_dates">1345-1450</field>
+        <field name="birth_date">1345-08-10</field>
+        <field name="death_date">1450-10-21</field>
     </record>
 
     <record model="auction.artists" id="auction_art_2">
         <field name="name">POREAU OSWALD</field>
-        <field name="birth_death_dates">1877-1955</field>
+        <field name="birth_date">1877-03-12</field>
+        <field name="death_date">1955-09-11</field>
     </record>
 
         <!-- demo data for the account tax code-->
diff --git a/addons/auction/report/artists.xml b/addons/auction/report/artists.xml
index 0c63f338051..360930f9f0c 100644
--- a/addons/auction/report/artists.xml
+++ b/addons/auction/report/artists.xml
@@ -3,7 +3,8 @@
 <artists>
 	<artist type="fields" name="name,id">
 		<name type="field" name="name"></name>
-		<birth_death_dates type="field" name="birth_death_dates"></birth_death_dates>
+		<birth_date type="field" name="birth_date"></birth_date>
+		<death_date type="field" name="death_date"></death_date>
 		<biography type="field" name="biography"></biography>
 	</artist>
 </artists>
diff --git a/addons/auction/test/auction.yml b/addons/auction/test/auction.yml
index 6d07f5fc0a5..8ef1e72ede3 100644
--- a/addons/auction/test/auction.yml
+++ b/addons/auction/test/auction.yml
@@ -21,7 +21,8 @@
   I create a new artist for an object. 
 - 
   !record {model: auction.artists, id: auction_artists_vincentvangogh0}:
-    birth_death_dates: 1853-1900
+    birth_date: "1853-03-30"
+    death_date: "1890-07-29"
     name: Vincent van Gogh
  
 - 

From 3b0db681ab6008dbd2e0d2a78a9a3d1fbeb00695 Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Tue, 21 Sep 2010 17:48:57 +0530
Subject: [PATCH 07/19] [IMP] auction: View improvements. Wizard improved.

bzr revid: uco@tinyerp.com-20100921121857-000n5w01kep9spym
---
 addons/auction/wizard/auction_lots_make_invoice_view.xml | 3 ++-
 addons/auction/wizard/auction_pay_buy_view.xml           | 3 ++-
 addons/auction/wizard/auction_taken.py                   | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/addons/auction/wizard/auction_lots_make_invoice_view.xml b/addons/auction/wizard/auction_lots_make_invoice_view.xml
index ddd82ac3cda..56903865e5f 100644
--- a/addons/auction/wizard/auction_lots_make_invoice_view.xml
+++ b/addons/auction/wizard/auction_lots_make_invoice_view.xml
@@ -15,7 +15,8 @@
                 		 <label string="(Keep empty for automatic number)" colspan="2"/>
                     </group>
                     <separator string="" colspan="4"/>
-                    <group colspan="4" col="6">
+                    <group colspan="2" col="2"/>
+                    <group colspan="2" col="2">
                     	<button icon="gtk-close" special="cancel" string="Close"/>
                     	<button icon="gtk-yes" string="Create invoices" name="makeInvoices" type="object"/>
                    </group>
diff --git a/addons/auction/wizard/auction_pay_buy_view.xml b/addons/auction/wizard/auction_pay_buy_view.xml
index d4ba91cad84..f7059d1374e 100644
--- a/addons/auction/wizard/auction_pay_buy_view.xml
+++ b/addons/auction/wizard/auction_pay_buy_view.xml
@@ -30,7 +30,8 @@
                     <field name="statement_id3"  domain="[('state','=','draft')]"/>
                   </group>
                   <separator string="" colspan="4" />
-                  <group colspan="4" col="6">
+                  <group colspan="2" col="2"/>
+                  <group colspan="2" col="2">
                    	<button icon="gtk-close" special="cancel" string="Close"/>
                    	<button icon="gtk-yes"  string="Pay" name="pay_and_reconcile" type="object"/>
                   </group>
diff --git a/addons/auction/wizard/auction_taken.py b/addons/auction/wizard/auction_taken.py
index 6beadc6a312..7db905cd576 100644
--- a/addons/auction/wizard/auction_taken.py
+++ b/addons/auction/wizard/auction_taken.py
@@ -53,7 +53,7 @@ class auction_taken(osv.osv_memory):
           lot_obj = self.pool.get('auction.lots')
           for current in self.browse(cr, uid, ids, context):
               for lot in current.lot_ids:
-                  lot_obj.write(cr, uid, lot.id, {'state':'taken_away'})
+                  lot_obj.write(cr, uid, lot.id, {'state':'taken_away', 'ach_emp': True})
               return {'lot_ids': []}
 
 auction_taken()

From d34059a6222ba7d4ca687a56f90e7833eacfcbbd Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Tue, 21 Sep 2010 19:38:11 +0530
Subject: [PATCH 08/19] [FIX] mrp_repair: Report error corrected in better way.

bzr revid: uco@tinyerp.com-20100921140811-8g1e4y70zqlp9b80
---
 addons/mrp_repair/mrp_repair.py    | 11 +++++++++++
 addons/mrp_repair/report/order.py  |  9 ---------
 addons/mrp_repair/report/order.rml | 10 +++++-----
 3 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/addons/mrp_repair/mrp_repair.py b/addons/mrp_repair/mrp_repair.py
index ddcd2ccb501..146fbb32f03 100644
--- a/addons/mrp_repair/mrp_repair.py
+++ b/addons/mrp_repair/mrp_repair.py
@@ -93,12 +93,23 @@ class mrp_repair(osv.osv):
             cur = repair.pricelist_id.currency_id
             res[id] = cur_obj.round(cr, uid, cur, untax.get(id, 0.0) + tax.get(id, 0.0))
         return res
+    
+    def _get_default_address(self, cr, uid, ids, field_name, arg, context):
+        res = {}
+        partner_obj = self.pool.get('res.partner')
+        for data in self.browse(cr, uid, ids):
+            adr_id = False
+            if data.partner_id:
+                adr_id = partner_obj.address_get(cr, uid, [data.partner_id.id], ['default'])['default']
+            res[data.id] = adr_id
+        return res
 
     _columns = {
         'name': fields.char('Repair Reference',size=24, required=True),
         'product_id': fields.many2one('product.product', string='Product to Repair', required=True, readonly=True, states={'draft':[('readonly',False)]}),
         'partner_id' : fields.many2one('res.partner', 'Partner', select=True, help='This field allow you to choose the parner that will be invoiced and delivered'),
         'address_id': fields.many2one('res.partner.address', 'Delivery Address', domain="[('partner_id','=',partner_id)]"),
+        'default_address_id': fields.function(_get_default_address, method=True, type="many2one", relation="res.partner.address"),
         'prodlot_id': fields.many2one('stock.production.lot', 'Lot Number', select=True, domain="[('product_id','=',product_id)]"),
         'state': fields.selection([
             ('draft','Quotation'),
diff --git a/addons/mrp_repair/report/order.py b/addons/mrp_repair/report/order.py
index 9ed63548e18..3257ba3df7a 100644
--- a/addons/mrp_repair/report/order.py
+++ b/addons/mrp_repair/report/order.py
@@ -30,10 +30,8 @@ class order(report_sxw.rml_parse):
         self.localcontext.update({
             'time': time,
             'total': self.total,
-            'adr_get' : self._adr_get
         })
 
-
     def total(self, repair):
         total = 0.0
         for operation in repair.operations:
@@ -43,13 +41,6 @@ class order(report_sxw.rml_parse):
         total = total + repair.amount_tax
         return total
 
-    def _adr_get(self, partner, type):
-            res_partner = pooler.get_pool(self.cr.dbname).get('res.partner')
-            res_partner_address = pooler.get_pool(self.cr.dbname).get('res.partner.address')
-            addresses = res_partner.address_get(self.cr, self.uid, [partner.id], [type])
-            adr_id = addresses and addresses[type] or False
-            return adr_id and res_partner_address.read(self.cr, self.uid, [adr_id])[0] or {}
-
 report_sxw.report_sxw('report.repair.order','mrp.repair','addons/mrp_repair/report/order.rml',parser=order)
 
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
diff --git a/addons/mrp_repair/report/order.rml b/addons/mrp_repair/report/order.rml
index b3c1855260b..149a2650bfd 100644
--- a/addons/mrp_repair/report/order.rml
+++ b/addons/mrp_repair/report/order.rml
@@ -190,11 +190,11 @@
         </td>
         <td>
           <para style="P3">[[ o.partner_id.name or removeParentNode('para') ]]</para>
-          <para style="P3">[[ o.partner_id and adr_get(o.partner_id, 'default').get('street','') or removeParentNode('para') ]]</para>
-          <para style="P3">[[ o.partner_id and adr_get(o.partner_id, 'default').get('street2','') or removeParentNode('para') ]]</para>
-          <para style="P3">[[ o.partner_id and adr_get(o.partner_id, 'default').get('zip','') or removeParentNode('para') ]][[ o.partner_id and adr_get(o.partner_id, 'default').get('city','') or removeParentNode('para') ]]</para>
-          <para style="P3">[[ (o.partner_id and adr_get(o.partner_id, 'default').get('state_id','') and adr_get(o.partner_id, 'default').get('state_id',[])[1]) or removeParentNode('para') ]]</para>
-          <para style="P3">[[ o.partner_id and adr_get(o.partner_id, 'default').get('country_id','') and adr_get(o.partner_id, 'default').get('country_id',[])[1] or removeParentNode('para') ]]</para>
+          <para style="P3">[[ o.default_address_id and o.default_address_id.street or removeParentNode('para') ]]</para>
+          <para style="P3">[[ o.default_address_id and o.default_address_id.street2 or removeParentNode('para') ]]</para>
+          <para style="P3">[[ o.default_address_id and o.default_address_id.zip or removeParentNode('para') ]][[ o.default_address_id and o.default_address_id.city or removeParentNode('para') ]]</para>
+          <para style="P3">[[ o.default_address_id and o.default_address_id.state_id and o.default_address_id.state_id.name or removeParentNode('para') ]]</para>
+          <para style="P3">[[ o.default_address_id and o.default_address_id.country_id and o.default_address_id.country_id.name or removeParentNode('para') ]]</para>
           <para style="P3">
             <font color="white"> </font>
           </para>

From c842650ff486e33b5392c627cf295de9f6964dfe Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Wed, 22 Sep 2010 12:47:45 +0530
Subject: [PATCH 09/19] [IMP] auction: Undo the changes in field name. Title
 corrected.

bzr revid: uco@tinyerp.com-20100922071745-59hzyzfkprrq665w
---
 addons/auction/auction.py             | 3 +--
 addons/auction/auction_demo.xml       | 6 ++----
 addons/auction/auction_view.xml       | 6 ++----
 addons/auction/board_auction_view.xml | 2 +-
 addons/auction/report/artists.xml     | 3 +--
 addons/auction/test/auction.yml       | 3 +--
 6 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/addons/auction/auction.py b/addons/auction/auction.py
index 4fb99a2efbf..1a61355f382 100644
--- a/addons/auction/auction.py
+++ b/addons/auction/auction.py
@@ -37,8 +37,7 @@ class auction_artists(osv.osv):
     _columns = {
         'name': fields.char('Artist/Author Name', size=64, required=True),
         'pseudo': fields.char('Pseudo', size=64),
-        'birth_date':fields.date('Birth date'),
-        'death_date':fields.date('Death date'),
+        'birth_death_dates':fields.char('Lifespan', size=64),
         'biography': fields.text('Biography'),
     }
 auction_artists()
diff --git a/addons/auction/auction_demo.xml b/addons/auction/auction_demo.xml
index 94ee1ec98a2..a26e5355cde 100644
--- a/addons/auction/auction_demo.xml
+++ b/addons/auction/auction_demo.xml
@@ -144,14 +144,12 @@
 
     <record model="auction.artists" id="auction_art_1">
         <field name="name">Philippe Lavilier</field>
-        <field name="birth_date">1345-08-10</field>
-        <field name="death_date">1450-10-21</field>
+        <field name="birth_death_dates">1345-1450</field>
     </record>
 
     <record model="auction.artists" id="auction_art_2">
         <field name="name">POREAU OSWALD</field>
-        <field name="birth_date">1877-03-12</field>
-        <field name="death_date">1955-09-11</field>
+        <field name="birth_death_dates">1877-1955</field>
     </record>
 
         <!-- demo data for the account tax code-->
diff --git a/addons/auction/auction_view.xml b/addons/auction/auction_view.xml
index 1ec39f8c0f0..d149fc89f1c 100644
--- a/addons/auction/auction_view.xml
+++ b/addons/auction/auction_view.xml
@@ -15,8 +15,7 @@
         <field name="arch" type="xml">
             <tree string="Artists">
 	            <field name="name"/>
-	            <field name="birth_date"/>
-	            <field name="death_date"/>
+	            <field name="birth_death_dates"/>
             </tree>
         </field>
     </record>
@@ -31,8 +30,7 @@
 	                <field name="name" colspan="4" string="Name"/>
 	                <newline/>
 	                <field name="pseudo"/>
-	                <field name="birth_date"/>
-	                <field name="death_date"/>
+	                <field name="birth_death_dates"/>
                 </group>
                 <separator string="Biography" colspan="4"/>
                 <field name="biography" nolabel="1" colspan="4"/>
diff --git a/addons/auction/board_auction_view.xml b/addons/auction/board_auction_view.xml
index 8865550949e..56ed41e2ca5 100644
--- a/addons/auction/board_auction_view.xml
+++ b/addons/auction/board_auction_view.xml
@@ -111,7 +111,7 @@
             sequence="1"
             id="menu_board_auction_open"  icon="terp-graph" parent="menu_board_auction"/>
         
-        <menuitem name="Auction Management" id="auction.auction_menu_root" icon="terp-purchase" sequence="26" groups="base.group_system" action="open_board_auction"/>
+        <menuitem name="Auction" id="auction.auction_menu_root" icon="terp-purchase" sequence="26" groups="base.group_system" action="open_board_auction"/>
 
     </data>
 </openerp>
diff --git a/addons/auction/report/artists.xml b/addons/auction/report/artists.xml
index 360930f9f0c..0c63f338051 100644
--- a/addons/auction/report/artists.xml
+++ b/addons/auction/report/artists.xml
@@ -3,8 +3,7 @@
 <artists>
 	<artist type="fields" name="name,id">
 		<name type="field" name="name"></name>
-		<birth_date type="field" name="birth_date"></birth_date>
-		<death_date type="field" name="death_date"></death_date>
+		<birth_death_dates type="field" name="birth_death_dates"></birth_death_dates>
 		<biography type="field" name="biography"></biography>
 	</artist>
 </artists>
diff --git a/addons/auction/test/auction.yml b/addons/auction/test/auction.yml
index 8ef1e72ede3..6d07f5fc0a5 100644
--- a/addons/auction/test/auction.yml
+++ b/addons/auction/test/auction.yml
@@ -21,8 +21,7 @@
   I create a new artist for an object. 
 - 
   !record {model: auction.artists, id: auction_artists_vincentvangogh0}:
-    birth_date: "1853-03-30"
-    death_date: "1890-07-29"
+    birth_death_dates: 1853-1900
     name: Vincent van Gogh
  
 - 

From c19c1fd5e35237cb69bf11ad0d32b55bab93e8d5 Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Wed, 22 Sep 2010 17:36:14 +0530
Subject: [PATCH 10/19] [IMP] point_of_sale: Improved view of Return and
 exchange goods wizard.

bzr revid: uco@tinyerp.com-20100922120614-ihnf2l7ilz0nc39v
---
 .../point_of_sale/wizard/pos_add_product.xml  | 21 ++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/addons/point_of_sale/wizard/pos_add_product.xml b/addons/point_of_sale/wizard/pos_add_product.xml
index 966a21baa4b..ac5fd1c6f65 100644
--- a/addons/point_of_sale/wizard/pos_add_product.xml
+++ b/addons/point_of_sale/wizard/pos_add_product.xml
@@ -4,25 +4,32 @@
         <!--  Add  Product -->
         
 		<record id="view_add_product" model="ir.ui.view">
-            <field name="name">Add  Product</field>
+            <field name="name">Add Product</field>
             <field name="model">pos.add.product</field>
             <field name="type">form</field>
             <field name="arch" type="xml">
                 <form string="Add product :">
-				    <group col="2" colspan="4">
+				    <group col="6" colspan="4">
 				    	<field name="product_id"/>
 				    	<field name="quantity"/>
-                		<button icon='gtk-cancel' name="close_action"
-                			string="Close" type="object"  />
-                		<button name="select_product" string="Continue"
-                			colspan="1" type="object" icon="gtk-ok" />
+				    	<separator string="" colspan="4"/>
+				    	<newline/>
+				    	<group colspan="4" col="4">
+				    	    <label string="" colspan="1"/>
+					    	<button icon="gtk-stop" special="cancel"
+	                            string="Cancel"/>
+	                		<button icon="gtk-ok" name="close_action"
+	                			string="Save &amp; Close" type="object"/>
+	                		<button name="select_product" string="Save &amp; New"
+	                			colspan="1" type="object" icon="gtk-add"/>
+	                    </group>
                 	</group>
                 </form>
             </field>
         </record>
 
         <record id="action_add_product" model="ir.actions.act_window">
-            <field name="name">Add  Product</field>
+            <field name="name">Add Product</field>
             <field name="type">ir.actions.act_window</field>
             <field name="res_model">pos.add.product</field>
             <field name="view_type">form</field>

From 9a1ccd6f6a0be405b5f5142244a3a71d2a48d17d Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Wed, 22 Sep 2010 18:49:01 +0530
Subject: [PATCH 11/19] [FIX] point_of_sale: Report error corrected.

bzr revid: uco@tinyerp.com-20100922131901-pcepmy97f75dpygv
---
 addons/point_of_sale/report/all_closed_cashbox_of_the_day.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/point_of_sale/report/all_closed_cashbox_of_the_day.py b/addons/point_of_sale/report/all_closed_cashbox_of_the_day.py
index dcbba147b59..fce080dfd0b 100644
--- a/addons/point_of_sale/report/all_closed_cashbox_of_the_day.py
+++ b/addons/point_of_sale/report/all_closed_cashbox_of_the_day.py
@@ -67,7 +67,7 @@ class all_closed_cashbox_of_the_day(report_sxw.rml_parse):
 
     def _get_bal(self,data):
         res = {}
-        sql =""" select sum(pieces*number) as bal from singer_statement where starting_id = %d """%(data['id'])
+        sql =""" select sum(pieces*number) as bal from account_cashbox_line where starting_id = %d """%(data['id'])
         self.cr.execute(sql)
         res = self.cr.dictfetchall()
         if res :
@@ -115,7 +115,7 @@ class all_closed_cashbox_of_the_day(report_sxw.rml_parse):
         res = self.cr.dictfetchall()
         for r in res :
             total_ending_bal += (r['net_total'] or 0.0)
-            sql1 =""" select sum(pieces*number) as bal from singer_statement where starting_id = %d"""%(r['id'])
+            sql1 =""" select sum(pieces*number) as bal from account_cashbox_line where starting_id = %d"""%(r['id'])
             self.cr.execute(sql1)
             data = self.cr.dictfetchall()
             if data[0]['bal']:

From c00d1711754e7d763e8e6085c9566c32b21eb8da Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Thu, 23 Sep 2010 16:35:37 +0530
Subject: [PATCH 12/19] [IMP] point_of_sale: 'Return Picking' wizard corrected.

bzr revid: uco@tinyerp.com-20100923110537-se0su7963fdel66c
---
 .../point_of_sale/wizard/pos_add_product.py   |  2 +-
 addons/point_of_sale/wizard/pos_return.py     | 24 ++++++++++++-------
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/addons/point_of_sale/wizard/pos_add_product.py b/addons/point_of_sale/wizard/pos_add_product.py
index c0604fc0bee..d3ac9c8c394 100644
--- a/addons/point_of_sale/wizard/pos_add_product.py
+++ b/addons/point_of_sale/wizard/pos_add_product.py
@@ -29,7 +29,7 @@ class add_product(osv.osv_memory):
 
     _columns = {
         'product_id': fields.many2one('product.product', 'Product', required=True),
-        'quantity': fields.float('Quantity ', required=True),
+        'quantity': fields.float('Quantity', required=True),
     }
     _defaults = {
         'quantity': lambda *a: 1,
diff --git a/addons/point_of_sale/wizard/pos_return.py b/addons/point_of_sale/wizard/pos_return.py
index cbfe4c5365a..84f02011f5a 100644
--- a/addons/point_of_sale/wizard/pos_return.py
+++ b/addons/point_of_sale/wizard/pos_return.py
@@ -296,7 +296,6 @@ class add_product(osv.osv_memory):
                 picking_obj.force_assign(cr, uid, [new_picking], context)
                 order_obj.write(cr,uid,active_id,{'picking_id':new_picking})
 
-
         return {
             'name': _('Add Product'),
             'view_type': 'form',
@@ -326,6 +325,9 @@ class add_product(osv.osv_memory):
         return_id=return_boj.search(cr,uid,[])
         data=return_boj.read(cr,uid,return_id,[])[0]
         wf_service = netsvc.LocalService("workflow")
+        self_data = self.read(cr, uid, ids)[0]
+        order_obj.add_product(cr, uid, active_ids[0], self_data['product_id'], self_data['quantity'], context=context)
+        
         for order_id in order_obj.browse(cr, uid, active_ids, context=context):
             prop_ids =property_obj.search(cr, uid, [('name', '=', 'property_stock_customer')])
             val = property_obj.browse(cr, uid, prop_ids[0]).value_reference
@@ -345,10 +347,18 @@ class add_product(osv.osv_memory):
                         })
             for line in order_id.lines:
                 key=('return%s') %line.id
-                if line.id  and  data.has_key(key):
-                    new_move=stock_move_obj.create(cr, uid, {
-                        'product_qty': data['return%s' %line.id ],
-                        'product_uos_qty': uom_obj._compute_qty(cr, uid, data['return%s' %line.id], line.product_id.uom_id.id),
+                if line.id: 
+                    if data.has_key(key):
+                        qty = data['return%s' %line.id]
+                        lines_obj.write(cr,uid,[line.id], {
+                                'qty_rfd':(line.qty or 0.0) + data['return%s' %line.id],
+                                'qty':line.qty-(data['return%s' %line.id] or 0.0)
+                        })
+                    else:
+                        qty = line.qty
+                    stock_move_obj.create(cr, uid, {
+                        'product_qty': qty,
+                        'product_uos_qty': uom_obj._compute_qty(cr, uid, qty, line.product_id.uom_id.id),
                         'picking_id':new_picking,
                         'product_uom':line.product_id.uom_id.id,
                         'location_id':location_id,
@@ -358,10 +368,6 @@ class add_product(osv.osv_memory):
                         'date':date_cur,
                         'date_planned':date_cur
                     })
-                    lines_obj.write(cr,uid,[line.id], {
-                                'qty_rfd':(line.qty or 0.0) + data['return%s' %line.id],
-                                'qty':line.qty-(data['return%s' %line.id] or 0.0)
-                            })
             wf_service.trg_validate(uid, 'stock.picking',new_picking,'button_confirm', cr)
             picking_obj.force_assign(cr, uid, [new_picking], context)
         obj=order_obj.browse(cr,uid, active_ids[0])

From 60d11142587d0d9c5e77d0afb394aa63435e194e Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Thu, 23 Sep 2010 17:44:36 +0530
Subject: [PATCH 13/19] [REF] mrp_repair, point_of_sale: Cleaning the code.

bzr revid: uco@tinyerp.com-20100923121436-35j9nenzuei3vl9d
---
 addons/mrp_repair/mrp_repair.py                |  7 +------
 addons/point_of_sale/wizard/pos_add_product.py |  1 -
 addons/point_of_sale/wizard/pos_return.py      | 18 ++----------------
 3 files changed, 3 insertions(+), 23 deletions(-)

diff --git a/addons/mrp_repair/mrp_repair.py b/addons/mrp_repair/mrp_repair.py
index 5868fa5c8e7..9c4a11cb9e0 100644
--- a/addons/mrp_repair/mrp_repair.py
+++ b/addons/mrp_repair/mrp_repair.py
@@ -19,12 +19,10 @@
 #
 ##############################################################################
 
-import time
 from osv import fields,osv
 import netsvc
 import mx.DateTime
-from mx.DateTime import RelativeDateTime, today, DateTime, localtime
-from tools import config
+from mx.DateTime import RelativeDateTime, today
 from tools.translate import _
 import decimal_precision as dp
 
@@ -286,7 +284,6 @@ class mrp_repair(osv.osv):
 
         if not lot:
             return data
-        lot_info = prodlot_obj.browse(cr, uid, lot)
         move_ids = move_obj.search(cr, uid, [('prodlot_id', '=', lot)])
 
         if not len(move_ids):
@@ -339,7 +336,6 @@ class mrp_repair(osv.osv):
         """ Cancels repair order.
         @return: True
         """
-        ok=True
         mrp_line_obj = self.pool.get('mrp.repair.line')
         for repair in self.browse(cr, uid, ids):
             mrp_line_obj.write(cr, uid, [l.id for l in repair.operations], {'state': 'cancel'})
@@ -520,7 +516,6 @@ class mrp_repair(osv.osv):
         repair_line_obj = self.pool.get('mrp.repair.line')
         seq_obj = self.pool.get('ir.sequence')
         pick_obj = self.pool.get('stock.picking')
-        company = self.pool.get('res.users').browse(cr, uid, uid).company_id
         for repair in self.browse(cr, uid, ids, context=context):
             for move in repair.operations:
                 move_id = move_obj.create(cr, uid, {
diff --git a/addons/point_of_sale/wizard/pos_add_product.py b/addons/point_of_sale/wizard/pos_add_product.py
index d3ac9c8c394..5735d2976a4 100644
--- a/addons/point_of_sale/wizard/pos_add_product.py
+++ b/addons/point_of_sale/wizard/pos_add_product.py
@@ -73,7 +73,6 @@ class add_product(osv.osv_memory):
 
         record_id = context and context.get('active_id', False)
         order_obj= self.pool.get('pos.order')
-        order_line_obj= self.pool.get('pos.order.line')
         obj=order_obj.browse(cr, uid, record_id)
         order_obj.write(cr, uid, [record_id], {'state':'done'})
         if obj.amount_total != obj.amount_paid:
diff --git a/addons/point_of_sale/wizard/pos_return.py b/addons/point_of_sale/wizard/pos_return.py
index 84f02011f5a..46e7fd8ca27 100644
--- a/addons/point_of_sale/wizard/pos_return.py
+++ b/addons/point_of_sale/wizard/pos_return.py
@@ -22,11 +22,7 @@
 import netsvc
 from osv import osv,fields
 from tools.translate import _
-from mx import DateTime
 import time
-import pos_box_entries
-import pos_add_product
-import pos_payment
 
 class pos_return(osv.osv_memory):
     _name = 'pos.return'
@@ -169,9 +165,7 @@ class pos_return(osv.osv_memory):
         wf_service = netsvc.LocalService("workflow")
         #Todo :Need to clean the code
         if active_id:
-            picking_ids = picking_obj.search(cr, uid, [('pos_order', 'in',[active_id]), ('state', '=', 'done')])
             data = self.read(cr, uid, ids)[0]
-            clone_list = []
             date_cur = time.strftime('%Y-%m-%d %H:%M:%S')
 
             for order_id in order_obj.browse(cr, uid, [active_id], context=context):
@@ -197,7 +191,7 @@ class pos_return(osv.osv_memory):
                             qty = data['return%s' %line.id]
                         except :
                             qty = line.qty
-                        new_move = stock_move_obj.create(cr, uid, {
+                        stock_move_obj.create(cr, uid, {
                             'product_qty': qty ,
                             'product_uos_qty': uom_obj._compute_qty(cr, uid, qty ,line.product_id.uom_id.id),
                             'picking_id': new_picking,
@@ -249,16 +243,11 @@ class add_product(osv.osv_memory):
             lines_obj = self.pool.get('pos.order.line')
             picking_obj = self.pool.get('stock.picking')
             stock_move_obj = self.pool.get('stock.move')
-            move_obj = self.pool.get('stock.move')
             property_obj= self.pool.get("ir.property")
-            invoice_obj= self.pool.get('account.invoice')
-            picking_ids = picking_obj.search(cr, uid, [('pos_order', 'in',[active_id]), ('state', '=', 'done')])
-            clone_list = []
             date_cur=time.strftime('%Y-%m-%d')
             uom_obj = self.pool.get('product.uom')
             prod_obj=self.pool.get('product.product')
             wf_service = netsvc.LocalService("workflow")
-            return_boj=self.pool.get('pos.return')
             order_obj.add_product(cr, uid, active_id, data['product_id'], data['quantity'], context=context)
 
             for order_id in order_obj.browse(cr, uid, [active_id], context=context):
@@ -279,7 +268,7 @@ class add_product(osv.osv_memory):
                                 'type':'out',
                                 'date':date_cur
                             })
-                new_move=stock_move_obj.create(cr, uid, {
+                stock_move_obj.create(cr, uid, {
                                 'product_qty': qty,
                                 'product_uos_qty': uom_obj._compute_qty(cr, uid, prod_id.uom_id.id, qty, prod_id.uom_id.id),
                                 'picking_id':new_picking,
@@ -314,11 +303,8 @@ class add_product(osv.osv_memory):
         lines_obj = self.pool.get('pos.order.line')
         picking_obj = self.pool.get('stock.picking')
         stock_move_obj = self.pool.get('stock.move')
-        move_obj = self.pool.get('stock.move')
         property_obj= self.pool.get("ir.property")
         invoice_obj=self.pool.get('account.invoice')
-        picking_ids = picking_obj.search(cr, uid, [('pos_order', 'in', active_ids), ('state', '=', 'done')])
-        clone_list = []
         date_cur=time.strftime('%Y-%m-%d %H:%M:%S')
         uom_obj = self.pool.get('product.uom')
         return_boj=self.pool.get('pos.return')

From fa9a98c6924b0cf1a8d56dbbe71f29ea910f682c Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Fri, 24 Sep 2010 11:05:35 +0530
Subject: [PATCH 14/19] [FIX] mrp: Corrected error on saving production order
 record.

bzr revid: uco@tinyerp.com-20100924053535-qnt5or0p9lpg1h15
---
 addons/mrp/mrp.py | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/addons/mrp/mrp.py b/addons/mrp/mrp.py
index 33828840eeb..1a71114c336 100644
--- a/addons/mrp/mrp.py
+++ b/addons/mrp/mrp.py
@@ -361,11 +361,12 @@ class many2many_domain(fields.many2many):
         for i in ids:
             res[i] = []
         valid_move_ids = move_obj.search(cr, user, self._domain) # move ids relative to domain argument
-        cr.execute("SELECT production_id, move_id from mrp_production_move_ids where production_id in %s and move_id in %s",
-            [tuple(ids), tuple(valid_move_ids)])
-        related_move_map = cr.fetchall()
-        related_move_dict = dict((k, list(set([v[1] for v in itr]))) for k, itr in groupby(related_move_map, itemgetter(0)))
-        res.update(related_move_dict)
+        if valid_move_ids:
+            cr.execute("SELECT production_id, move_id from mrp_production_move_ids where production_id in %s and move_id in %s",
+                [tuple(ids), tuple(valid_move_ids)])
+            related_move_map = cr.fetchall()
+            related_move_dict = dict((k, list(set([v[1] for v in itr]))) for k, itr in groupby(related_move_map, itemgetter(0)))
+            res.update(related_move_dict)
 
         return res
 

From 30ec71647b3e2c01b48c1efb1b36a5913371d3b4 Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Mon, 27 Sep 2010 11:37:12 +0530
Subject: [PATCH 15/19] [FIX] point_of_sale: Report corrected.

bzr revid: uco@tinyerp.com-20100927060712-c9ag98irq1mpuihf
---
 addons/point_of_sale/report/pos_payment_report_user.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/point_of_sale/report/pos_payment_report_user.py b/addons/point_of_sale/report/pos_payment_report_user.py
index dc829859c3e..c7f31ffcd6f 100644
--- a/addons/point_of_sale/report/pos_payment_report_user.py
+++ b/addons/point_of_sale/report/pos_payment_report_user.py
@@ -53,7 +53,7 @@ class pos_payment_report_user(report_sxw.rml_parse):
                          "and po.state='paid' and to_char(date_trunc('day',po.date_order),'YYYY-MM-DD')::date = current_date " \
                          "and po.user_id IN %s",(tuple(ids),))
         res=self.cr.fetchone()
-        res = res and res[0] or None
+        res = res and res[0] or 0.0
 
         return res
 

From 8326778771c63b2fafe34acfef8cbeabb95cc164 Mon Sep 17 00:00:00 2001
From: "uco (Open ERP)" <uco@tinyerp.com>
Date: Mon, 27 Sep 2010 11:45:56 +0530
Subject: [PATCH 16/19] [FIX] auction: Reports corrected

bzr revid: uco@tinyerp.com-20100927061556-xfncjfhw8ls13nuw
---
 addons/auction/report/auction_artists.rml     | 2 +-
 addons/auction/report/bids_lots.rml           | 4 ++--
 addons/auction/report/bids_phones_details.rml | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/auction/report/auction_artists.rml b/addons/auction/report/auction_artists.rml
index dfe81549245..1a0688825d4 100644
--- a/addons/auction/report/auction_artists.rml
+++ b/addons/auction/report/auction_artists.rml
@@ -62,7 +62,7 @@
           </para>
           <para style="P6">[[o.artist2_id and 'Artist2: '+o.artist2_id.name or False]]</para>
           <para style="P8">
-            <font face="Courier">[[o.artist_id2 and 'Biography: '+o.artist_id2.biography or False]]</font>
+            <font face="Courier">[[o.artist2_id and 'Biography: '+o.artist2_id.biography or False]]</font>
           </para>
         </td>
       </tr>
diff --git a/addons/auction/report/bids_lots.rml b/addons/auction/report/bids_lots.rml
index 9d688868d30..c2cad707a57 100644
--- a/addons/auction/report/bids_lots.rml
+++ b/addons/auction/report/bids_lots.rml
@@ -74,10 +74,10 @@
           <para style="P4">[[ o.ach_uid and o.ach_uid.name or False]]</para>
         </td>
         <td>
-          <para style="P5"><font>[[o.bid_lines[0] and o.bid_lines[0].bid_id.name or removeParentNode('font')]]</font></para>
+          <para style="P5"><font>[[ o.bid_lines and o.bid_lines[0] and o.bid_lines[0].bid_id.name or removeParentNode('font')]]</font></para>
         </td>
         <td>
-          <para style="P6"><font>[[o.bid_lines[0] and o.bid_lines[0].bid_id.contact_tel or removeParentNode('font')]]</font></para>
+          <para style="P6"><font>[[o.bid_lines and o.bid_lines[0] and o.bid_lines[0].bid_id.contact_tel or removeParentNode('font')]]</font></para>
         </td>
       </tr>
     </blockTable>
diff --git a/addons/auction/report/bids_phones_details.rml b/addons/auction/report/bids_phones_details.rml
index 17ba5f94b81..adf9e6a63b3 100644
--- a/addons/auction/report/bids_phones_details.rml
+++ b/addons/auction/report/bids_phones_details.rml
@@ -88,7 +88,7 @@
           <para style="P8">[[o.lot_est1]]-[[o.lot_est2]]</para>
         </td>
         <td>
-          <para style="P7"><font>[[o.bid_lines[0] and o.bid_lines[0].bid_id.contact_tel or removeParentNode('font')]]</font></para>
+          <para style="P7"><font>[[o.bid_lines and o.bid_lines[0] and o.bid_lines[0].bid_id.contact_tel or removeParentNode('font')]]</font></para>
         </td>
       </tr>
     </blockTable>

From 8817e1a28652fddf1debe589a82e2cd14ab77445 Mon Sep 17 00:00:00 2001
From: "Vir (Open ERP)" <vir@tinyerp.com>
Date: Mon, 27 Sep 2010 11:53:07 +0530
Subject: [PATCH 17/19] [IMP/MOD] account,crm_* : Extended filter option set
 before group by in search view

bzr revid: vir@tinyerp.com-20100927062307-gkdneuj86c3y2l71
---
 .../account_analytic_entries_report_view.xml  | 22 +++++------
 .../report/account_entries_report_view.xml    | 28 +++++++-------
 .../report/account_invoice_report_view.xml    | 22 +++++------
 addons/crm/crm_lead_view.xml                  | 30 +++++++--------
 addons/crm/crm_opportunity_view.xml           | 28 +++++++-------
 addons/crm/report/crm_lead_report_view.xml    | 32 ++++++++--------
 .../crm/report/crm_phonecall_report_view.xml  | 29 +++++++--------
 .../report/crm_claim_report_view.xml          | 37 +++++++++----------
 .../report/crm_fundraising_report_view.xml    | 33 ++++++++---------
 .../report/crm_helpdesk_report_view.xml       | 15 +++-----
 .../report/crm_lead_report_view.xml           | 27 +++++++-------
 11 files changed, 149 insertions(+), 154 deletions(-)

diff --git a/addons/account/report/account_analytic_entries_report_view.xml b/addons/account/report/account_analytic_entries_report_view.xml
index b837186f23c..1df0cf011fd 100644
--- a/addons/account/report/account_analytic_entries_report_view.xml
+++ b/addons/account/report/account_analytic_entries_report_view.xml
@@ -54,6 +54,17 @@
                     </field>
                 </group>
                 <newline/>
+                <group expand="0" string="Extended Filters..." groups="base.group_extended">
+                    <field name="currency_id" widget="selection"/>
+                    <field name="general_account_id" widget="selection"/>
+                    <field name="product_uom_id" widget="selection"/>
+                    <field name="journal_id" widget="selection"/>
+                    <separator orientation="vertical"/>
+                    <field name="name"/>
+                    <field name="account_id"/>
+                    <field name="company_id" widget="selection" groups="base.group_multi_company"/>
+                </group>
+                <newline/>
                 <group expand="1" string="Group By...">
                     <filter string="User" name="User" icon="terp-personal" context="{'group_by':'user_id'}"/>
                     <filter string="Currency" icon="terp-dolar" context="{'group_by':'currency_id'}"/>
@@ -70,17 +81,6 @@
                     <filter string="Month" icon="terp-go-month" context="{'group_by':'month'}"/>
                     <filter string="Year" icon="terp-go-year" context="{'group_by':'year'}"/>
                 </group>
-                <newline/>
-                <group expand="0" string="Extended Filters..." groups="base.group_extended">
-                    <field name="currency_id" widget="selection"/>
-                    <field name="general_account_id" widget="selection"/>
-                    <field name="product_uom_id" widget="selection"/>
-                    <field name="journal_id" widget="selection"/>
-                    <separator orientation="vertical"/>
-                    <field name="name"/>
-                    <field name="account_id"/>
-                    <field name="company_id" widget="selection" groups="base.group_multi_company"/>
-                </group>
             </search>
         </field>
     </record>
diff --git a/addons/account/report/account_entries_report_view.xml b/addons/account/report/account_entries_report_view.xml
index f6282046e00..f7dd6da49e3 100644
--- a/addons/account/report/account_entries_report_view.xml
+++ b/addons/account/report/account_entries_report_view.xml
@@ -56,7 +56,7 @@
                 <group colspan="10" col="12">
                     <filter icon="terp-go-year" string="This F.Year"
                             name="thisyear"
-                            domain="[('period_id','in','current_year')]"                        
+                            domain="[('period_id','in','current_year')]"
                             help="Journal Entries with period in current year"/>
                     <filter icon="terp-go-month" string="This Period"
                             name="period"
@@ -73,6 +73,19 @@
                     <field name="journal_id" widget="selection"/>
                     <field name="period_id"/>
                 </group>
+                <newline/>
+                 <group expand="0" string="Extended Filters..." groups="base.group_extended">
+                    <field name="fiscalyear_id"/>
+                    <separator orientation="vertical"/>
+                    <field name="product_id"/>
+                    <field name="partner_id"/>
+                    <separator orientation="vertical" groups="base.group_multi_company"/>
+                    <field name="company_id" groups="base.group_multi_company"/>
+                    <newline/>
+                    <field name="date_created"/>
+                    <field name="date"/>
+                    <field name="date_maturity"/>
+                 </group>
                 <newline/>
                 <group expand="1" string="Group By...">
                     <filter string="Partner" icon="terp-partner" context="{'group_by':'partner_id'}"/>
@@ -92,19 +105,6 @@
                     <filter string="Period" icon="terp-go-month" name="group_period" context="{'group_by':'period_id'}"/>
                     <filter string="Fiscal Year" icon="terp-go-year" context="{'group_by':'fiscalyear_id'}"/>
                  </group>
-                 <newline/>
-                 <group expand="0" string="Extended Filters..." groups="base.group_extended">
-                    <field name="fiscalyear_id"/>
-                    <separator orientation="vertical"/>
-                    <field name="product_id"/>
-                    <field name="partner_id"/>
-                    <separator orientation="vertical" groups="base.group_multi_company"/>
-                    <field name="company_id" groups="base.group_multi_company"/>
-                    <newline/>
-                    <field name="date_created"/>
-                    <field name="date"/>
-                    <field name="date_maturity"/>
-                 </group>
             </search>
         </field>
     </record>
diff --git a/addons/account/report/account_invoice_report_view.xml b/addons/account/report/account_invoice_report_view.xml
index 98dd3f64fb7..80985fb3d6a 100644
--- a/addons/account/report/account_invoice_report_view.xml
+++ b/addons/account/report/account_invoice_report_view.xml
@@ -97,6 +97,17 @@
                    <field name="categ_id" />
                 </group>
                 <newline/>
+                <group expand="0" string="Extended Filters..." groups="base.group_extended">
+                    <field name="product_id"/>
+                    <separator orientation="vertical"/>
+                    <field name="journal_id" widget="selection"/>
+                    <field name="account_id"/>
+                    <separator orientation="vertical"/>
+                    <field name="date_due"/>
+                    <separator orientation="vertical" groups="base.group_multi_company"/>
+                    <field name="company_id" groups="base.group_multi_company" widget="selection"/>
+                </group>
+                <newline/>
                 <group expand="1" string="Group By...">
                     <filter string="Partner" icon="terp-partner" context="{'group_by':'partner_id','residual_visible':True}"/>
                     <filter string="Salesman" name='user' icon="terp-personal" context="{'group_by':'user_id'}"/>
@@ -118,17 +129,6 @@
                     <filter string="Month" name="month" icon="terp-go-month" context="{'group_by':'month'}" help="Group by month of Invoice Date"/>
                     <filter string="Year" name="year" icon="terp-go-year" context="{'group_by':'year'}" help="Group by year of Invoice Date"/>
                 </group>
-                <newline/>
-                <group expand="0" string="Extended Filters..." groups="base.group_extended">
-                    <field name="product_id"/>
-                    <separator orientation="vertical"/>
-                    <field name="journal_id" widget="selection"/>
-                    <field name="account_id"/>
-                    <separator orientation="vertical"/>
-                    <field name="date_due"/>
-                    <separator orientation="vertical" groups="base.group_multi_company"/>
-                    <field name="company_id" groups="base.group_multi_company" widget="selection"/>
-                </group>
             </search>
         </field>
     </record>
diff --git a/addons/crm/crm_lead_view.xml b/addons/crm/crm_lead_view.xml
index f9a3a1fb629..41d41ef0502 100644
--- a/addons/crm/crm_lead_view.xml
+++ b/addons/crm/crm_lead_view.xml
@@ -31,7 +31,7 @@
         <menuitem action="crm_lead_categ_action"
             id="menu_crm_lead_categ" name="Categories"
             parent="base.menu_crm_config_lead" sequence="1"/>
-        
+
         <!--  Resource Type Form View -->
         <record id="crm_lead_resource_act" model="ir.actions.act_window">
             <field name="name">Lead Sources</field>
@@ -337,6 +337,20 @@
                         help="Show Sales Team"/>
                 </field>
                 <newline/>
+                <group expand="0" string="Extended Filters..." groups="base.group_extended">
+                      <field name="stage_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]"/>
+                      <field name="categ_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]"/>
+                      <separator orientation="vertical"/>
+                      <field name="country_id" context="{'invisible_country': False}">
+                          <filter icon="terp-personal+" context="{'invisible_country': False}" help="Show countries"/>
+                      </field>
+                      <separator orientation="vertical"/>
+                      <field name="company_id" widget="selection" groups="base.group_multi_company"/>
+                      <newline/>
+                      <field name="create_date" string="Creation Date"/>
+                      <field name="date_closed"/>
+                </group>
+                <newline/>
                 <group expand="0" string="Group By...">
                     <filter string="Stage" icon="terp-stage" domain="[]" context="{'group_by':'stage_id'}"/>
                     <filter string="State" icon="terp-stock_effects-object-colorize" domain="[]" context="{'group_by':'state'}"/>
@@ -354,20 +368,6 @@
                     <filter string="Creation" icon="terp-go-month"
                         domain="[]" context="{'group_by':'create_date'}" />
                 </group>
-                <newline/>
-                <group  expand="0" string="Extended Filters..." groups="base.group_extended">
-                      <field name="stage_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]"/>
-                      <field name="categ_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]"/>
-                      <separator orientation="vertical"/>
-                      <field name="country_id" context="{'invisible_country': False}">
-                          <filter icon="terp-personal+" context="{'invisible_country': False}" help="Show countries"/>
-                      </field>
-                      <separator orientation="vertical"/>
-                      <field name="company_id" widget="selection" groups="base.group_multi_company"/>
-                      <newline/>
-                      <field name="create_date" string="Creation Date"/>
-                      <field name="date_closed"/>
-                </group>
            </search>
         </field>
     </record>
diff --git a/addons/crm/crm_opportunity_view.xml b/addons/crm/crm_opportunity_view.xml
index e816e3f0b1d..8101a0bcfb2 100644
--- a/addons/crm/crm_opportunity_view.xml
+++ b/addons/crm/crm_opportunity_view.xml
@@ -311,6 +311,20 @@
                                 help="Show Sales Team"/>
                         </field>
                         <newline/>
+                        <group  expand="0" string="Extended Filters..." groups="base.group_extended">
+                              <field name="stage_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]"/>
+                              <field name="categ_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]"/>
+                              <separator orientation="vertical"/>
+                              <field name="country_id" context="{'invisible_country': False}">
+                                  <filter icon="terp-personal+" context="{'invisible_country': False}" help="Show countries"/>
+                              </field>
+                              <separator orientation="vertical"/>
+                              <field name="company_id" widget="selection" groups="base.group_multi_company"/>
+                              <newline/>
+                              <field name="create_date" string="Creation Date"/>
+                              <field name="date_closed"/>
+                        </group>
+                        <newline/>
                         <group expand="0" string="Group By..." colspan="16">
                             <filter string="Stage" icon="terp-stage" domain="[]"
                                 context="{'group_by':'stage_id'}" />
@@ -335,20 +349,6 @@
                                 help="Expected Closing" domain="[]"
                                 context="{'group_by':'date_deadline'}" />
                         </group>
-                        <newline/>
-                        <group  expand="0" string="Extended Filters..." groups="base.group_extended">
-                              <field name="stage_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]"/>
-                              <field name="categ_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]"/>
-                              <separator orientation="vertical"/>
-                              <field name="country_id" context="{'invisible_country': False}">
-                                  <filter icon="terp-personal+" context="{'invisible_country': False}" help="Show countries"/>
-                              </field>
-                              <separator orientation="vertical"/>
-                              <field name="company_id" widget="selection" groups="base.group_multi_company"/>
-                              <newline/>
-                              <field name="create_date" string="Creation Date"/>
-                              <field name="date_closed"/>
-                        </group>
                     </search>
                 </field>
             </record>
diff --git a/addons/crm/report/crm_lead_report_view.xml b/addons/crm/report/crm_lead_report_view.xml
index 42adda76dbe..1939965c0dc 100644
--- a/addons/crm/report/crm_lead_report_view.xml
+++ b/addons/crm/report/crm_lead_report_view.xml
@@ -110,7 +110,22 @@
                         </field>
                    </group>
                    <newline/>
-                   <group  expand="1" string="Group By...">
+                  <group expand="0" string="Extended Filters..." groups="base.group_extended">
+                      <field name="partner_id"/>
+                      <separator orientation="vertical"/>
+                      <field name="stage_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]" />
+                      <field name="categ_id" widget="selection"/>
+                      <field name="type_id" widget="selection"/>
+                      <field name="channel_id" widget="selection"/>
+                      <separator orientation="vertical"/>
+                      <field name="company_id" widget="selection" groups="base.group_multi_company"/>
+                      <newline/>
+                      <field name="creation_date"/>
+                      <field name="opening_date"/>
+                      <field name="date_closed"/>
+                  </group>
+                   <newline/>
+                   <group expand="1" string="Group By...">
                         <filter string="User" name="user" icon="terp-personal"
                             domain="[]" context="{'group_by':'user_id'}" />
                        <filter string="Partner" icon="terp-personal" context="{'group_by':'partner_id'}" />
@@ -144,21 +159,6 @@
                         <filter string="Year" icon="terp-go-year"
                             domain="[]" context="{'group_by':'name'}" />
                   </group>
-                  <newline/>
-                  <group  expand="0" string="Extended Filters..." groups="base.group_extended">
-                      <field name="partner_id"/>
-                      <separator orientation="vertical"/>
-                      <field name="stage_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]" />
-                      <field name="categ_id" widget="selection"/>
-                      <field name="type_id" widget="selection"/>
-                      <field name="channel_id" widget="selection"/>
-                      <separator orientation="vertical"/>
-                      <field name="company_id" widget="selection" groups="base.group_multi_company"/>
-                      <newline/>
-                      <field name="creation_date"/>
-                      <field name="opening_date"/>
-                      <field name="date_closed"/>
-                  </group>
                </search>
             </field>
         </record>
diff --git a/addons/crm/report/crm_phonecall_report_view.xml b/addons/crm/report/crm_phonecall_report_view.xml
index 69402603d17..8024ca78bd5 100644
--- a/addons/crm/report/crm_phonecall_report_view.xml
+++ b/addons/crm/report/crm_phonecall_report_view.xml
@@ -110,7 +110,20 @@
                            </field>
                    </group>
                    <newline/>
-                   <group  expand="1" string="Group By...">
+                   <group expand="0" string="Extended Filters..."  groups="base.group_extended">
+                      <field name="partner_id"/>
+                        <separator orientation="vertical"/>
+                        <field name="stage_id" widget="selection" domain="[('object_id.model', '=', 'crm.phonecall')]"/>
+                        <field name="categ_id" widget="selection" domain="[('object_id.model', '=', 'crm.phonecall')]"/>
+                        <separator orientation="vertical"/>
+                        <field name="company_id" groups="base.group_multi_company"/>
+                           <newline/>
+                        <field name="creation_date"/>
+                        <field name="opening_date"/>
+                        <field name="date_closed"/>
+                   </group>
+                   <newline/>
+                   <group expand="1" string="Group By...">
                         <filter string="User" name="User" icon="terp-personal"
                             domain="[]" context="{'group_by':'user_id'}" />
                        <filter string="Partner" icon="terp-personal" context="{'group_by':'partner_id'}" />
@@ -139,20 +152,6 @@
                         <filter string="Year" icon="terp-go-year"
                             domain="[]" context="{'group_by':'name'}" />
                   </group>
-
-                   <newline/>
-                   <group  expand="0" string="Extended Filters..."  groups="base.group_extended">
-                      <field name="partner_id"/>
-                        <separator orientation="vertical"/>
-                        <field name="stage_id" widget="selection" domain="[('object_id.model', '=', 'crm.phonecall')]"/>
-                        <field name="categ_id" widget="selection" domain="[('object_id.model', '=', 'crm.phonecall')]"/>
-                        <separator orientation="vertical"/>
-                        <field name="company_id" groups="base.group_multi_company"/>
-                           <newline/>
-                        <field name="creation_date"/>
-                        <field name="opening_date"/>
-                        <field name="date_closed"/>
-                   </group>
                </search>
             </field>
         </record>
diff --git a/addons/crm_claim/report/crm_claim_report_view.xml b/addons/crm_claim/report/crm_claim_report_view.xml
index 3a1e8f45f26..edb3dc2b6db 100644
--- a/addons/crm_claim/report/crm_claim_report_view.xml
+++ b/addons/crm_claim/report/crm_claim_report_view.xml
@@ -119,7 +119,24 @@
                			</field>
                    </group>
                    <newline/>
-                   <group  expand="0" string="Group By...">
+                   <group  expand="0" string="Extended Filters..." groups="base.group_extended">
+                         <filter icon="terp-dialog-close"
+                            string="Done"
+                            domain="[('state','=','done')]"/>
+                        <filter icon="gtk-cancel"
+                            string="Cancel"
+                            domain="[('state','=','cancel')]"/>
+                        <group>
+                            <separator orientation="vertical"/>
+                            <field name="stage_id" widget="selection" domain="[('object_id.model', '=', 'crm.claim')]"/>
+                            <field name="categ_id" widget="selection" domain="[('object_id.model', '=', 'crm.claim')]"/>
+                            <separator orientation="vertical"/>
+                            <field name="priority" />
+                            <field name="type_id" widget="selection" domain="[('object_id.model', '=', 'crm.claim')]"/>
+                        </group>
+                   </group>
+                   <newline/>
+                   <group  expand="1" string="Group By...">
                         <filter string="User" name="User" icon="terp-personal"
                             domain="[]" context="{'group_by':'user_id'}" />
 
@@ -157,25 +174,7 @@
                         <filter string="Year" icon="terp-go-year"
                             domain="[]" context="{'group_by':'name'}" />
                   </group>
-                   <newline/>
-                   <group  expand="0" string="Extended Filters..." groups="base.group_extended">
-                         <filter icon="terp-dialog-close"
-                    		string="Done"
-                    		domain="[('state','=','done')]"/>
 
-                    	<filter icon="gtk-cancel"
-                    		string="Cancel"
-                    		domain="[('state','=','cancel')]"/>
-
-                    	<group>
-		            	    <separator orientation="vertical"/>
-		            	    <field name="stage_id" widget="selection" domain="[('object_id.model', '=', 'crm.claim')]"/>
-			                <field name="categ_id" widget="selection" domain="[('object_id.model', '=', 'crm.claim')]"/>
-			                <separator orientation="vertical"/>
-			                <field name="priority" />
-			                <field name="type_id" widget="selection" domain="[('object_id.model', '=', 'crm.claim')]"/>
-		                </group>
-                   </group>
                </search>
             </field>
         </record>
diff --git a/addons/crm_fundraising/report/crm_fundraising_report_view.xml b/addons/crm_fundraising/report/crm_fundraising_report_view.xml
index 8e9f1611af6..989b364a488 100644
--- a/addons/crm_fundraising/report/crm_fundraising_report_view.xml
+++ b/addons/crm_fundraising/report/crm_fundraising_report_view.xml
@@ -118,7 +118,22 @@
                			</field>
                    </group>
                    <newline/>
-                   <group  expand="0" string="Group By...">
+                   <group  expand="0" string="Extended Filters..." groups="base.group_extended">
+                         <filter icon="terp-dialog-close"
+                            string="Done"
+                            domain="[('state','=','done')]"/>
+
+                        <filter icon="gtk-cancel"
+                            string="Cancel"
+                            domain="[('state','=','cancel')]"/>
+
+                        <group>
+                            <separator orientation="vertical"/>
+                            <field name="categ_id" widget="selection" domain="[('object_id.model', '=', 'crm.fundraising')]"/>
+                         </group>
+                   </group>
+                   <newline/>
+                   <group  expand="1" string="Group By...">
                         <filter string="User" name="User" icon="terp-personal"
                             domain="[]" context="{'group_by':'user_id'}" />
 
@@ -146,23 +161,7 @@
 
                         <filter string="Year" icon="terp-go-year"
                             domain="[]" context="{'group_by':'name'}" />
-
                   </group>
-                   <newline/>
-                   <group  expand="0" string="Extended Filters..." groups="base.group_extended">
-                         <filter icon="terp-dialog-close"
-                    		string="Done"
-                    		domain="[('state','=','done')]"/>
-
-                    	<filter icon="gtk-cancel"
-                    		string="Cancel"
-                    		domain="[('state','=','cancel')]"/>
-
-                    	<group>
-		            	    <separator orientation="vertical"/>
-			                <field name="categ_id" widget="selection" domain="[('object_id.model', '=', 'crm.fundraising')]"/>
-			             </group>
-                   </group>
                </search>
             </field>
         </record>
diff --git a/addons/crm_helpdesk/report/crm_helpdesk_report_view.xml b/addons/crm_helpdesk/report/crm_helpdesk_report_view.xml
index 2544a506fd5..1d494103dc3 100644
--- a/addons/crm_helpdesk/report/crm_helpdesk_report_view.xml
+++ b/addons/crm_helpdesk/report/crm_helpdesk_report_view.xml
@@ -114,7 +114,12 @@
                          <field name="user_id" widget="selection"/>
                    </group>
                    <newline/>
-                  <group expand="0" string="Group By...">
+                   <group expand="0" string="Extended Filters..."  groups="base.group_extended">
+                        <filter string="Priority" icon="terp-rating-rated"
+                            domain="[]" context="{'group_by':'priority'}" />
+                   </group>
+                   <newline/>
+                   <group expand="1" string="Group By...">
                         <filter string="User" icon="terp-personal"
                             domain="[]" context="{'group_by':'user_id'}"
                             default="1" />
@@ -141,15 +146,7 @@
 
                         <filter string="Year" icon="terp-go-year"
                             domain="[]" context="{'group_by':'name'}" />
-
                   </group>
-                    <newline/>
-                   <group expand="0" string="Extended Filters..."  groups="base.group_extended">
-                        <filter string="Priority" icon="terp-rating-rated"
-                            domain="[]" context="{'group_by':'priority'}" />
-                   </group>
-
-
                </search>
             </field>
         </record>
diff --git a/addons/crm_partner_assign/report/crm_lead_report_view.xml b/addons/crm_partner_assign/report/crm_lead_report_view.xml
index 3424fc44fbe..2d38cd8862b 100644
--- a/addons/crm_partner_assign/report/crm_lead_report_view.xml
+++ b/addons/crm_partner_assign/report/crm_lead_report_view.xml
@@ -31,6 +31,19 @@
                         <field name="partner_assigned_id"/>
                    </group>
                    <newline/>
+                   <group  expand="0" string="Extended Filters..." groups="base.group_extended">
+                      <field name="partner_id"/>
+                      <separator orientation="vertical"/>
+                      <field name="stage_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]" />
+                      <field name="categ_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]"/>
+                      <separator orientation="vertical"/>
+                      <field name="company_id" widget="selection" groups="base.group_multi_company"/>
+                      <newline/>
+                      <field name="creation_date"/>
+                      <field name="opening_date"/>
+                      <field name="date_closed"/>
+                   </group>
+                   <newline/>
                    <group  expand="1" string="Group By...">
                        <filter string="User" name="user" icon="terp-personal"
                             domain="[]" context="{'group_by':'user_id'}" />
@@ -69,19 +82,7 @@
                         <filter string="Year" icon="terp-go-year"
                             domain="[]" context="{'group_by':'name'}" />
                   </group>
-                  <newline/>
-                  <group  expand="0" string="Extended Filters..." groups="base.group_extended">
-                      <field name="partner_id"/>
-                      <separator orientation="vertical"/>
-                      <field name="stage_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]" />
-                      <field name="categ_id" widget="selection" domain="[('object_id.model', '=', 'crm.lead')]"/>
-                      <separator orientation="vertical"/>
-                      <field name="company_id" widget="selection" groups="base.group_multi_company"/>
-                      <newline/>
-                      <field name="creation_date"/>
-                      <field name="opening_date"/>
-                      <field name="date_closed"/>
-                  </group>
+
                </search>
             </field>
         </record>

From b9c2e86993e883675e081b9a0938b44bb8b04527 Mon Sep 17 00:00:00 2001
From: Panos Christeas <p_chr...@hol.gr>
Date: Mon, 27 Sep 2010 08:28:36 +0200
Subject: [PATCH 18/19] [FIX] account_analytic_analysis: added patch from Panos
 Christeas fixing a bug in _analysis_all and removing the use of 'sum' as a
 variable

bzr revid: olt@tinyerp.com-20100927062836-fuojzdp1jk31bdey
---
 .../account_analytic_analysis.py              | 16 +++---
 addons/point_of_sale/pos.py                   | 56 +++++++++++++++----
 2 files changed, 53 insertions(+), 19 deletions(-)

diff --git a/addons/account_analytic_analysis/account_analytic_analysis.py b/addons/account_analytic_analysis/account_analytic_analysis.py
index 6bd2f2138ec..5a393e1dd83 100644
--- a/addons/account_analytic_analysis/account_analytic_analysis.py
+++ b/addons/account_analytic_analysis/account_analytic_analysis.py
@@ -126,8 +126,8 @@ class account_analytic_account(osv.osv):
                             where account_analytic_line.account_id IN %s \
                                 and account_analytic_line.invoice_id is not null \
                             GROUP BY account_analytic_line.account_id",(parent_ids,))
-                    for account_id, sum in cr.fetchall():
-                        res[account_id] = sum
+                    for account_id, lid in cr.fetchall():
+                        res[account_id][f] = lid
                 for account in accounts:
                     for child in account.child_ids:
                         if res[account.id][f] < res.get(child.id, {}).get(f, ''):
@@ -141,8 +141,8 @@ class account_analytic_account(osv.osv):
                             where account_id IN %s \
                                 and invoice_id is null \
                             GROUP BY account_analytic_line.account_id" ,(parent_ids,))
-                    for account_id, sum in cr.fetchall():
-                        res[account_id][f] = sum
+                    for account_id, lwd in cr.fetchall():
+                        res[account_id][f] = lwd
                 for account in accounts:
                     for child in account.child_ids:
                         if res[account.id][f] < res.get(child.id, {}).get(f, ''):
@@ -160,8 +160,8 @@ class account_analytic_account(osv.osv):
                                 and invoice_id is null \
                                 AND to_invoice IS NOT NULL \
                             GROUP BY account_analytic_line.account_id;",(parent_ids,))
-                    for account_id, sum in cr.fetchall():
-                        res[account_id][f] = round(sum, dp)
+                    for account_id, sua in cr.fetchall():
+                        res[account_id][f] = round(sua, dp)
                 for account in accounts:
                     for child in account.child_ids:
                         if account.id != child.id:
@@ -180,8 +180,8 @@ class account_analytic_account(osv.osv):
                                 and account_analytic_journal.type='general' \
                             GROUP BY account_analytic_line.account_id",(parent_ids,))
                     ff =  cr.fetchall()
-                    for account_id, sum in ff:
-                        res[account_id][f] = round(sum, dp)
+                    for account_id, hq in ff:
+                        res[account_id][f] = round(hq, dp)
                 for account in accounts:
                     for child in account.child_ids:
                         if account.id != child.id:
diff --git a/addons/point_of_sale/pos.py b/addons/point_of_sale/pos.py
index 769d3a0460e..2db6b6e5531 100644
--- a/addons/point_of_sale/pos.py
+++ b/addons/point_of_sale/pos.py
@@ -619,7 +619,7 @@ class pos_order(osv.osv):
         pricelist = values['pricelist_id'] and values['pricelist_id'][0]
         product = values['partner_id'] and values['partner_id'][0]
 
-        price = line_obj.price_by_product(cr, uid, [],
+        price = line_obj.price_by_product_OLD(cr, uid, [],
                 pricelist, product_id, qty, product)
 
         order_line_id = line_obj.create(cr, uid, {
@@ -1015,7 +1015,7 @@ class pos_order_line(osv.osv):
     def _get_amount(self, cr, uid, ids, field_name, arg, context):
         res = {}
         for line in self.browse(cr, uid, ids):
-            price = self.price_by_product(cr, uid, ids, line.order_id.pricelist_id.id, line.product_id.id, line.qty, line.order_id.partner_id.id)
+            price = self.price_by_product_OLD(cr, uid, ids, line.order_id.pricelist_id.id, line.product_id.id, line.qty, line.order_id.partner_id.id)
             res[line.id]=price
         return res
 
@@ -1025,12 +1025,12 @@ class pos_order_line(osv.osv):
         for line in self.browse(cr, uid, ids):
             tax_amount = 0.0
             taxes = [t for t in line.product_id.taxes_id]
-	    if line.qty == 0.0:
-		continue
+            if line.qty == 0.0:
+                continue
             computed_taxes = account_tax_obj.compute_all(cr, uid, taxes, line.price_unit, line.qty)['taxes']
             for tax in computed_taxes:
                 tax_amount += tax['amount']
-            price = self.price_by_product(cr, uid, ids, line.order_id.pricelist_id.id, line.product_id.id, line.qty, line.order_id.partner_id.id)
+            price = self.price_by_product_OLD(cr, uid, ids, line.order_id.pricelist_id.id, line.product_id.id, line.qty, line.order_id.partner_id.id)
             if line.discount!=0.0:
                 res[line.id] = line.price_unit * line.qty * (1 - (line.discount or 0.0) / 100.0)
             else:
@@ -1041,15 +1041,49 @@ class pos_order_line(osv.osv):
     def _amount_line(self, cr, uid, ids, field_name, arg, context):
         res = {}
 
+        prices = self.price_by_product_NEW(cr, uid, ids)
         for line in self.browse(cr, uid, ids):
-            price = self.price_by_product(cr, uid, ids, line.order_id.pricelist_id.id, line.product_id.id, line.qty, line.order_id.partner_id.id)
+            price = prices[line.id]
             if line.discount!=0.0:
                 res[line.id] = line.price_unit * line.qty * (1 - (line.discount or 0.0) / 100.0)
             else:
                 res[line.id]=line.price_unit*line.qty
         return res
 
-    def price_by_product(self, cr, uid, ids, pricelist, product_id, qty=0, partner_id=False):
+    def price_by_product_NEW(self, cr, uid, ids, context=None):
+        if context is None:
+            context = {}
+
+        res = {}.fromkeys(ids, 0.0)
+        return res
+
+        for line in self.browse(cr, uid, ids):
+            pricelist = line.order_id.pricelist_id.id
+            product_id = line.product_id
+            qty = line.qty or 0
+            partner_id = line.order_id.partner_id.id or False
+
+            if not product_id:
+                res[line.id] = 0.0
+                continue
+            if not pricelist:
+                raise osv.except_osv(_('No Pricelist !'),
+                    _('You have to select a pricelist in the sale form !\n' \
+                    'Please set one before choosing a product.'))
+
+            uom_id = product_id.uom_po_id.id
+
+            price = self.pool.get('product.pricelist').price_get(cr, uid, [pricelist], product_id.id, qty or 1.0, partner_id, {'uom': uom_id})[pricelist]
+            unit_price = price or product_id.list_price
+            res[line.id] = unit_price
+            if unit_price is False:
+                raise osv.except_osv(_('No valid pricelist line found !'),
+                    _("Couldn't find a pricelist line matching this product" \
+                    " and quantity.\nYou have to change either the product," \
+                    " the quantity or the pricelist."))
+        return res
+
+    def price_by_product_OLD(self, cr, uid, ids, pricelist, product_id, qty=0, partner_id=False):
         if not product_id:
             return 0.0
         if not pricelist:
@@ -1057,7 +1091,7 @@ class pos_order_line(osv.osv):
                 _('You have to select a pricelist in the sale form !\n' \
                 'Please set one before choosing a product.'))
         p_obj = self.pool.get('product.product').browse(cr,uid,[product_id])[0]
-        uom_id=p_obj.uom_po_id.id
+        uom_id = p_obj.uom_po_id.id
         price = self.pool.get('product.pricelist').price_get(cr, uid,
             [pricelist], product_id, qty or 1.0, partner_id,{'uom': uom_id})[pricelist]
         unit_price=price or p_obj.list_price
@@ -1069,14 +1103,14 @@ class pos_order_line(osv.osv):
         return unit_price
 
     def onchange_product_id(self, cr, uid, ids, pricelist, product_id, qty=0, partner_id=False):
-        price = self.price_by_product(cr, uid, ids, pricelist, product_id, qty, partner_id)
+        price = self.price_by_product_OLD(cr, uid, ids, pricelist, product_id, qty, partner_id)
         self.write(cr,uid,ids,{'price_unit':price})
         pos_stot = (price * qty)
         return {'value': {'price_unit': price,'price_subtotal_incl': pos_stot}}
 
     def onchange_subtotal(self, cr, uid, ids, discount, price, pricelist,qty,partner_id, product_id,*a):
         prod_obj = self.pool.get('product.product')
-        price_f = self.price_by_product(cr, uid, ids, pricelist, product_id, qty, partner_id)
+        price_f = self.price_by_product_OLD(cr, uid, ids, pricelist, product_id, qty, partner_id)
         prod_id=''
         if product_id:
             prod_id=prod_obj.browse(cr,uid,product_id).disc_controle
@@ -1179,7 +1213,7 @@ class pos_order_line(osv.osv):
         # search price product
         product =product_obj.read(cr, uid, product_id)
         product_name = product[0]['name']
-        price = self.price_by_product(cr, uid, 0, pricelist_id[0]['pricelist_id'][0], product_id[0], 1)
+        price = self.price_by_product_OLD(cr, uid, 0, pricelist_id[0]['pricelist_id'][0], product_id[0], 1)
 
         order_line_ids = self.search(cr, uid, [('name','=',product_name),('order_id','=',order)])
         if order_line_ids:

From cf44617d4b4a5eb6212740174011fdb0d3ae48aa Mon Sep 17 00:00:00 2001
From: "olt@tinyerp.com" <>
Date: Mon, 27 Sep 2010 08:31:15 +0200
Subject: [PATCH 19/19] [FIX] revert

bzr revid: olt@tinyerp.com-20100927063115-q5w66ct4a58uugbb
---
 addons/point_of_sale/pos.py | 56 ++++++++-----------------------------
 1 file changed, 11 insertions(+), 45 deletions(-)

diff --git a/addons/point_of_sale/pos.py b/addons/point_of_sale/pos.py
index 2db6b6e5531..769d3a0460e 100644
--- a/addons/point_of_sale/pos.py
+++ b/addons/point_of_sale/pos.py
@@ -619,7 +619,7 @@ class pos_order(osv.osv):
         pricelist = values['pricelist_id'] and values['pricelist_id'][0]
         product = values['partner_id'] and values['partner_id'][0]
 
-        price = line_obj.price_by_product_OLD(cr, uid, [],
+        price = line_obj.price_by_product(cr, uid, [],
                 pricelist, product_id, qty, product)
 
         order_line_id = line_obj.create(cr, uid, {
@@ -1015,7 +1015,7 @@ class pos_order_line(osv.osv):
     def _get_amount(self, cr, uid, ids, field_name, arg, context):
         res = {}
         for line in self.browse(cr, uid, ids):
-            price = self.price_by_product_OLD(cr, uid, ids, line.order_id.pricelist_id.id, line.product_id.id, line.qty, line.order_id.partner_id.id)
+            price = self.price_by_product(cr, uid, ids, line.order_id.pricelist_id.id, line.product_id.id, line.qty, line.order_id.partner_id.id)
             res[line.id]=price
         return res
 
@@ -1025,12 +1025,12 @@ class pos_order_line(osv.osv):
         for line in self.browse(cr, uid, ids):
             tax_amount = 0.0
             taxes = [t for t in line.product_id.taxes_id]
-            if line.qty == 0.0:
-                continue
+	    if line.qty == 0.0:
+		continue
             computed_taxes = account_tax_obj.compute_all(cr, uid, taxes, line.price_unit, line.qty)['taxes']
             for tax in computed_taxes:
                 tax_amount += tax['amount']
-            price = self.price_by_product_OLD(cr, uid, ids, line.order_id.pricelist_id.id, line.product_id.id, line.qty, line.order_id.partner_id.id)
+            price = self.price_by_product(cr, uid, ids, line.order_id.pricelist_id.id, line.product_id.id, line.qty, line.order_id.partner_id.id)
             if line.discount!=0.0:
                 res[line.id] = line.price_unit * line.qty * (1 - (line.discount or 0.0) / 100.0)
             else:
@@ -1041,49 +1041,15 @@ class pos_order_line(osv.osv):
     def _amount_line(self, cr, uid, ids, field_name, arg, context):
         res = {}
 
-        prices = self.price_by_product_NEW(cr, uid, ids)
         for line in self.browse(cr, uid, ids):
-            price = prices[line.id]
+            price = self.price_by_product(cr, uid, ids, line.order_id.pricelist_id.id, line.product_id.id, line.qty, line.order_id.partner_id.id)
             if line.discount!=0.0:
                 res[line.id] = line.price_unit * line.qty * (1 - (line.discount or 0.0) / 100.0)
             else:
                 res[line.id]=line.price_unit*line.qty
         return res
 
-    def price_by_product_NEW(self, cr, uid, ids, context=None):
-        if context is None:
-            context = {}
-
-        res = {}.fromkeys(ids, 0.0)
-        return res
-
-        for line in self.browse(cr, uid, ids):
-            pricelist = line.order_id.pricelist_id.id
-            product_id = line.product_id
-            qty = line.qty or 0
-            partner_id = line.order_id.partner_id.id or False
-
-            if not product_id:
-                res[line.id] = 0.0
-                continue
-            if not pricelist:
-                raise osv.except_osv(_('No Pricelist !'),
-                    _('You have to select a pricelist in the sale form !\n' \
-                    'Please set one before choosing a product.'))
-
-            uom_id = product_id.uom_po_id.id
-
-            price = self.pool.get('product.pricelist').price_get(cr, uid, [pricelist], product_id.id, qty or 1.0, partner_id, {'uom': uom_id})[pricelist]
-            unit_price = price or product_id.list_price
-            res[line.id] = unit_price
-            if unit_price is False:
-                raise osv.except_osv(_('No valid pricelist line found !'),
-                    _("Couldn't find a pricelist line matching this product" \
-                    " and quantity.\nYou have to change either the product," \
-                    " the quantity or the pricelist."))
-        return res
-
-    def price_by_product_OLD(self, cr, uid, ids, pricelist, product_id, qty=0, partner_id=False):
+    def price_by_product(self, cr, uid, ids, pricelist, product_id, qty=0, partner_id=False):
         if not product_id:
             return 0.0
         if not pricelist:
@@ -1091,7 +1057,7 @@ class pos_order_line(osv.osv):
                 _('You have to select a pricelist in the sale form !\n' \
                 'Please set one before choosing a product.'))
         p_obj = self.pool.get('product.product').browse(cr,uid,[product_id])[0]
-        uom_id = p_obj.uom_po_id.id
+        uom_id=p_obj.uom_po_id.id
         price = self.pool.get('product.pricelist').price_get(cr, uid,
             [pricelist], product_id, qty or 1.0, partner_id,{'uom': uom_id})[pricelist]
         unit_price=price or p_obj.list_price
@@ -1103,14 +1069,14 @@ class pos_order_line(osv.osv):
         return unit_price
 
     def onchange_product_id(self, cr, uid, ids, pricelist, product_id, qty=0, partner_id=False):
-        price = self.price_by_product_OLD(cr, uid, ids, pricelist, product_id, qty, partner_id)
+        price = self.price_by_product(cr, uid, ids, pricelist, product_id, qty, partner_id)
         self.write(cr,uid,ids,{'price_unit':price})
         pos_stot = (price * qty)
         return {'value': {'price_unit': price,'price_subtotal_incl': pos_stot}}
 
     def onchange_subtotal(self, cr, uid, ids, discount, price, pricelist,qty,partner_id, product_id,*a):
         prod_obj = self.pool.get('product.product')
-        price_f = self.price_by_product_OLD(cr, uid, ids, pricelist, product_id, qty, partner_id)
+        price_f = self.price_by_product(cr, uid, ids, pricelist, product_id, qty, partner_id)
         prod_id=''
         if product_id:
             prod_id=prod_obj.browse(cr,uid,product_id).disc_controle
@@ -1213,7 +1179,7 @@ class pos_order_line(osv.osv):
         # search price product
         product =product_obj.read(cr, uid, product_id)
         product_name = product[0]['name']
-        price = self.price_by_product_OLD(cr, uid, 0, pricelist_id[0]['pricelist_id'][0], product_id[0], 1)
+        price = self.price_by_product(cr, uid, 0, pricelist_id[0]['pricelist_id'][0], product_id[0], 1)
 
         order_line_ids = self.search(cr, uid, [('name','=',product_name),('order_id','=',order)])
         if order_line_ids: