From 62590e7c60badfcc6cfcc18fcef3435ab42f7434 Mon Sep 17 00:00:00 2001 From: Antoine Guenet Date: Fri, 1 Jul 2022 07:40:58 +0000 Subject: [PATCH] [FIX] web, test_lint: add editor libs global constants to eslint config Odoo Editor uses chai/mocha for testing. Since it was moved into Odoo, we need chai's global constants to be recognized by eslint. The same thing applies to DOMPurify. Part-of: odoo/odoo#94516 --- .../static/src/js/editor/odoo-editor/src/OdooEditor.js | 1 + .../static/src/js/editor/odoo-editor/test/editor-test.js | 1 + odoo/addons/test_lint/tests/eslintrc | 8 +++++++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js b/addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js index de69c9de751..33efa429900 100644 --- a/addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js +++ b/addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js @@ -62,6 +62,7 @@ import { TablePicker } from './tablepicker/TablePicker.js'; export * from './utils/utils.js'; import { UNBREAKABLE_ROLLBACK_CODE, UNREMOVABLE_ROLLBACK_CODE } from './utils/constants.js'; +/* global DOMPurify */ const BACKSPACE_ONLY_COMMANDS = ['oDeleteBackward', 'oDeleteForward']; const BACKSPACE_FIRST_COMMANDS = BACKSPACE_ONLY_COMMANDS.concat(['oEnter', 'oShiftEnter']); diff --git a/addons/web_editor/static/src/js/editor/odoo-editor/test/editor-test.js b/addons/web_editor/static/src/js/editor/odoo-editor/test/editor-test.js index f424851dc55..b081311b8e2 100644 --- a/addons/web_editor/static/src/js/editor/odoo-editor/test/editor-test.js +++ b/addons/web_editor/static/src/js/editor/odoo-editor/test/editor-test.js @@ -12,6 +12,7 @@ import './spec/fontAwesome.test.js'; import './spec/autostep.test.js'; import './spec/urlRegex.test.js'; import './spec/collab.test.js'; +/* global mocha */ mocha.run(failures => { if (failures) { diff --git a/odoo/addons/test_lint/tests/eslintrc b/odoo/addons/test_lint/tests/eslintrc index a98d1b65fff..98a199c69ac 100644 --- a/odoo/addons/test_lint/tests/eslintrc +++ b/odoo/addons/test_lint/tests/eslintrc @@ -35,6 +35,12 @@ "moment": "readonly", "py": "readonly", "ClipboardJS": "readonly", - "globalThis": "readonly" + "globalThis": "readonly", + "module": "readonly", + "chai": "readonly", + "describe": "readonly", + "it": "readonly", + "mocha": "readonly", + "DOMPurify": "readonly" } }