From 6246ec0f466bf220133085dd530fe4c07f1e57f2 Mon Sep 17 00:00:00 2001 From: "Abdelouahab (abla)" Date: Wed, 23 Mar 2022 12:20:18 +0000 Subject: [PATCH] [FIX] google_calendar : fix default reminder To reproduce ============ - Sync Google Calendar to Odoo - Create an event in GCaledar without setting a notification In Odoo Notification reminder is set Purpose ======= we use default reminder given by Google which is notification 30 minutes before even if the event doesn't have a reminder. Specification ============= To solve the issue we use empty reminder instead of the default given by google if no reminder is set. opw-2792364 closes odoo/odoo#87592 X-original-commit: a25d38dd252a657ea44c822a227e415337003672 Signed-off-by: Arnaud Joset Signed-off-by: abla001 --- addons/google_calendar/models/calendar.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/addons/google_calendar/models/calendar.py b/addons/google_calendar/models/calendar.py index ffafbd77b84..82b3fb95ef1 100644 --- a/addons/google_calendar/models/calendar.py +++ b/addons/google_calendar/models/calendar.py @@ -76,7 +76,13 @@ class Meeting(models.Model): if google_event.is_cancelled(): return {'active': False} - alarm_commands = self._odoo_reminders_commands(google_event.reminders.get('overrides') or default_reminders) + # default_reminders is never () it is set to google's default reminder (30 min before) + # we need to check 'useDefault' for the event to determine if we have to use google's + # default reminder or not + reminder_command = google_event.reminders.get('overrides') + if not reminder_command: + reminder_command = google_event.reminders.get('useDefault') and default_reminders or () + alarm_commands = self._odoo_reminders_commands(reminder_command) attendee_commands, partner_commands = self._odoo_attendee_commands(google_event) related_event = self.search([('google_id', '=', google_event.id)], limit=1) name = google_event.summary or related_event and related_event.name or _("(No title)")