From 6175c09724648c0a2b22ef109bcd0529fc131cd0 Mon Sep 17 00:00:00 2001
From: Kartik Chavda <kcv@odoo.com>
Date: Fri, 24 Feb 2023 06:56:55 +0000
Subject: [PATCH] [IMP] sale_project: hide SOL field

Before this commit SOL field on task visible when user no
sale access and field is set but SOL field is readonly when
user has no sale access there is not point showing readonly
empty field.

This commit hide SOL field when user has no sale access and
field is not set.

task-3186438

closes odoo/odoo#115474

Related: odoo/enterprise#38186
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
---
 addons/sale_project/views/project_task_views.xml              | 4 ++--
 .../sale_timesheet/views/sale_timesheet_portal_templates.xml  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/addons/sale_project/views/project_task_views.xml b/addons/sale_project/views/project_task_views.xml
index 39e9cc013f0..35fdad2b848 100644
--- a/addons/sale_project/views/project_task_views.xml
+++ b/addons/sale_project/views/project_task_views.xml
@@ -78,7 +78,7 @@
                 <button class="oe_stat_button"
                         type="object" name="action_view_so" icon="fa-dollar"
                         attrs="{'invisible': [('sale_order_id', '=', False)]}"
-                        groups="sales_team.group_sale_salesman_all_leads">
+                        groups="sales_team.group_sale_salesman">
                         <div class="o_stat_info">
                             <span class="o_stat_text">Sales Order</span>
                         </div>
@@ -90,7 +90,7 @@
             </xpath>
             <xpath expr="//field[@name='partner_id']" position="after">
                 <field name="sale_order_id" attrs="{'invisible': True}" groups="sales_team.group_sale_salesman"/>
-                <field name="sale_line_id" groups="!sales_team.group_sale_salesman" string="Sales Order Item" options='{"no_open": True}' readonly="1" context="{'create': False, 'edit': False, 'delete': False}" attrs="{'invisible': ['|', ('allow_billable', '=', False), ('project_root_id', '=', False)]}"/>
+                <field name="sale_line_id" groups="!sales_team.group_sale_salesman" string="Sales Order Item" options='{"no_open": True}' readonly="1" context="{'create': False, 'edit': False, 'delete': False}" attrs="{'invisible': ['|', '|', ('allow_billable', '=', False), ('project_root_id', '=', False), ('sale_line_id', '=', False)]}"/>
                 <field name="sale_line_id" groups="sales_team.group_sale_salesman" string="Sales Order Item" options='{"no_create": True}' readonly="0" context="{'create': False, 'edit': False, 'delete': False, 'with_price_unit': True}" placeholder="Non-billable" attrs="{'invisible': ['|', ('allow_billable', '=', False), ('project_root_id', '=', False)]}"/>
                 <field name="allow_billable" invisible="1"/>
             </xpath>
diff --git a/addons/sale_timesheet/views/sale_timesheet_portal_templates.xml b/addons/sale_timesheet/views/sale_timesheet_portal_templates.xml
index 68d668de2e3..64c5f055306 100644
--- a/addons/sale_timesheet/views/sale_timesheet_portal_templates.xml
+++ b/addons/sale_timesheet/views/sale_timesheet_portal_templates.xml
@@ -106,7 +106,7 @@
 
     <template id="portal_my_task_inherit" inherit_id="project.portal_my_task">
         <xpath expr="//div[@name='portal_my_task_second_column']" position="inside">
-            <t t-if="task.project_id.allow_billable">
+            <t t-if="task.project_id.allow_billable and env.user.has_group('sales_team.group_sale_salesman')">
                 <div t-if="task.sale_order_id"><strong>Sales Order:</strong>
                     <span t-if="so_accessible"><a t-attf-href="{{ task.sale_order_id.access_url }}" t-field="task.sale_order_id"></a></span>
                     <span t-else="" t-field="task.sale_order_id"></span>