From 61569e9bf705c63b632e9015aacfe5d89e86c371 Mon Sep 17 00:00:00 2001
From: "Rohitkumar (roku)" <roku@odoo.com>
Date: Fri, 25 Mar 2022 12:21:24 +0000
Subject: [PATCH] [IMP] sale_project: fix the SO access error even user has
 correct sales rights

Before this commit, When user has sale order all docuements right, project user right
and try to open a sale order linked with private project then it raises an
access rights error when a user clicks on sales orders in a project, even
though the user has the correct rights due to invalid access on project_ids
field also only project manager was able to see the project stat button on sale order.

so in this commit, make the project stat button visible to project user
and fix the access error on private project for project user.

task-2792884

closes odoo/odoo#91167

X-original-commit: f4e371a4b0903cea92c947b3afc36deee05237da
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
---
 addons/sale_project/models/sale_order.py       | 3 +++
 addons/sale_project/views/sale_order_views.xml | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/addons/sale_project/models/sale_order.py b/addons/sale_project/models/sale_order.py
index ad9346916a7..3434446e614 100644
--- a/addons/sale_project/models/sale_order.py
+++ b/addons/sale_project/models/sale_order.py
@@ -35,10 +35,13 @@ class SaleOrder(models.Model):
 
     @api.depends('order_line.product_id', 'order_line.project_id')
     def _compute_project_ids(self):
+        is_project_manager = self.user_has_groups('project.group_project_manager')
         for order in self:
             projects = order.order_line.mapped('product_id.project_id')
             projects |= order.order_line.mapped('project_id')
             projects |= order.project_id
+            if not is_project_manager:
+                projects = projects._filter_access_rules('read')
             order.project_ids = projects
             order.project_count = len(projects)
 
diff --git a/addons/sale_project/views/sale_order_views.xml b/addons/sale_project/views/sale_order_views.xml
index d3d09e235a8..2edd6d7d7f6 100644
--- a/addons/sale_project/views/sale_order_views.xml
+++ b/addons/sale_project/views/sale_order_views.xml
@@ -8,7 +8,7 @@
         <field name="priority">10</field>
         <field name="arch" type="xml">
             <xpath expr="//button[@name='action_view_invoice']" position="before">
-                <button type="object" name="action_view_project_ids" class="oe_stat_button" icon="fa-puzzle-piece" attrs="{'invisible': ['|', ('state', 'in', ['draft', 'sent']), ('project_ids', '=', [])]}" groups="project.group_project_manager">
+                <button type="object" name="action_view_project_ids" class="oe_stat_button" icon="fa-puzzle-piece" attrs="{'invisible': ['|', ('state', 'in', ['draft', 'sent']), ('project_ids', '=', [])]}" groups="project.group_project_user">
                     <field name="project_ids" invisible="1"/>
                     <field name="project_count" widget="statinfo" string="Projects"/>
                 </button>