From 608ea7f85d7bae2dfc3fde80d477c1514fa7e262 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Wed, 28 Aug 2019 09:58:38 +0000 Subject: [PATCH] [FIX] website_slides: lessen concurrent update by waiting slide completion PURPOSE Test frontend and UI tools of eLearning. SPECIFICATIONS When switching through slides using the fullscreen player it is quite common to have concurrent updates on slide.slide.partner model as it is used to store the viewed and completed. By correctly waiting for the completion to be done we lessen potential concurrent errors. LINKS Task ID 1937768 --- .../static/src/js/slides_course_fullscreen_player.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/addons/website_slides/static/src/js/slides_course_fullscreen_player.js b/addons/website_slides/static/src/js/slides_course_fullscreen_player.js index c014c5280fc..47e5700da31 100644 --- a/addons/website_slides/static/src/js/slides_course_fullscreen_player.js +++ b/addons/website_slides/static/src/js/slides_course_fullscreen_player.js @@ -444,7 +444,7 @@ odoo.define('website_slides.fullscreen', function (require) { this._toggleSidebar(); } return this._super.apply(this, arguments).then(function () { - self._onChangeSlide(); // trigger manually once DOM ready, since slide content is not rendered server side + return self._onChangeSlide(); // trigger manually once DOM ready, since slide content is not rendered server side }); }, /** @@ -595,6 +595,7 @@ odoo.define('website_slides.fullscreen', function (require) { } }).then(function (data){ self._markAsCompleted(slideId, data.channel_completion); + return Promise.resolve(); }); } return Promise.resolve(); @@ -620,7 +621,7 @@ odoo.define('website_slides.fullscreen', function (require) { return self._renderSlide(); }).then(function() { if (slide._autoSetDone && !session.is_website_user) { // no useless RPC call - self._setCompleted(slide.id); + return self._setCompleted(slide.id); } }); },