From 5f7e6b4183d37b569006f5fb01bf93d9be136336 Mon Sep 17 00:00:00 2001 From: mafo-odoo Date: Thu, 18 Aug 2022 13:55:27 +0000 Subject: [PATCH] [FIX] web : drag and drop for kanban does not open record Steps to reproduce: -Install Project -Activate kanban view for projects in the settings -On firefix do a drag and drop of a project between two stages Current behavior: You are redirect to the project record Expected behavior: The project changed stage but there is no redirection Solution: The check for the drag&drop case only happen inside the openRecord function but the record should not be open in this situation and hence the check should happen before the function is called in onGlobalClick. opw-2952389 closes odoo/odoo#99120 X-original-commit: 977ef91693f22a5fab2b71d4dadf99046853ca9d Signed-off-by: Aaron Bohy (aab) Signed-off-by: Fockedey Martin (mafo) --- .../static/src/legacy/js/views/kanban/kanban_record.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/addons/web/static/src/legacy/js/views/kanban/kanban_record.js b/addons/web/static/src/legacy/js/views/kanban/kanban_record.js index 2b9c154c0e1..828fd89f839 100644 --- a/addons/web/static/src/legacy/js/views/kanban/kanban_record.js +++ b/addons/web/static/src/legacy/js/views/kanban/kanban_record.js @@ -240,11 +240,6 @@ var KanbanRecord = Widget.extend(WidgetAdapterMixin, { }); return; } - if (this.$el.hasClass('o_currently_dragged')) { - // this record is currently being dragged and dropped, so we do not - // want to open it. - return; - } var editMode = this.$el.hasClass('oe_kanban_global_click_edit'); this.trigger_up('open_record', { id: this.db_id, @@ -695,6 +690,11 @@ var KanbanRecord = Widget.extend(WidgetAdapterMixin, { if ($(event.target).parents('.o_dropdown_kanban').length) { return; } + if (this.$el.hasClass('o_currently_dragged')) { + // this record is currently being dragged and dropped, so we do not + // want to open it. + return; + } var trigger = true; var elem = event.target; var ischild = true;