From 5f11a12fd4274f213f4aedb70bdc85414acfb707 Mon Sep 17 00:00:00 2001
From: mano-odoo <mano@odoo.com>
Date: Wed, 6 Mar 2024 17:46:20 +0100
Subject: [PATCH] [FIX] account, *: unify alert margins above form sheets

*: account_edi, hr_work_entry_contract, l10n_ch, l10n_latam_check,
mail_bot_hr, sale, sms, survey, website_slides, pos_online_payment

This commit follows the margin variable introduced in the
`form_controller.scss` file. It removes the margin customizations
applied on the alerts which are rendered above a form sheet to let the
CSS rule handle the spacing.

task-3577058

closes odoo/odoo#156927

Related: odoo/enterprise#58282
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
---
 addons/account/views/account_move_views.xml   | 24 +++++++++----------
 addons/account/views/partner_view.xml         |  4 ++--
 .../account_edi/views/account_move_views.xml  |  8 +++----
 .../crm_iap_lead_mining_request_views.xml     |  2 +-
 .../views/hr_work_entry_views.xml             |  2 +-
 addons/l10n_ch/views/account_payment_view.xml |  2 +-
 .../views/account_payment_view.xml            |  2 +-
 addons/mail_bot_hr/views/res_users_views.xml  |  2 +-
 .../views/pos_payment_method_views.xml        |  2 +-
 addons/sale/views/sale_order_views.xml        |  2 +-
 addons/sms/wizard/sms_composer_views.xml      |  4 ++--
 addons/survey/views/survey_question_views.xml |  2 +-
 .../views/slide_question_views.xml            |  2 +-
 .../wizard/slide_channel_invite_views.xml     |  2 +-
 14 files changed, 30 insertions(+), 30 deletions(-)

diff --git a/addons/account/views/account_move_views.xml b/addons/account/views/account_move_views.xml
index 6f2f00aece2..40dbff04af7 100644
--- a/addons/account/views/account_move_views.xml
+++ b/addons/account/views/account_move_views.xml
@@ -720,7 +720,7 @@
                                 invisible="not to_check" data-hotkey="k" />
                         <field name="state" widget="statusbar" statusbar_visible="draft,posted"/>
                     </header>
-                    <div class="alert alert-warning mb-0" role="alert"
+                    <div class="alert alert-warning" role="alert"
                          invisible="state != 'draft' or not duplicated_ref_ids">
                         Warning: this bill might be a duplicate of
                         <button name="open_duplicated_ref_bill_view"
@@ -729,54 +729,54 @@
                                 class="btn btn-link p-0"
                         />
                     </div>
-                    <div class="alert alert-info mb-0" role="alert" invisible="not is_being_sent">
+                    <div class="alert alert-info" role="alert" invisible="not is_being_sent">
                         This invoice is being sent in the background.
                     </div>
                     <!-- Invoice outstanding credits -->
                     <div groups="account.group_account_invoice,account.group_account_readonly"
-                         class="alert alert-warning mb-0" role="alert"
+                         class="alert alert-warning" role="alert"
                          invisible="state != 'draft' or not tax_lock_date_message">
                         <field name="tax_lock_date_message" nolabel="1"/>
                     </div>
                     <div groups="account.group_account_invoice,account.group_account_readonly"
-                         class="alert alert-info mb-0" role="alert"
+                         class="alert alert-info" role="alert"
                          invisible="move_type not in ('out_invoice', 'out_receipt') or not invoice_has_outstanding or payment_state not in ('not_paid', 'partial')">
                         You have <bold><a class="alert-link" href="#outstanding" role="button">outstanding credits</a></bold> for this customer. You can allocate them to mark this invoice as paid.
                     </div>
                     <div groups="account.group_account_invoice,account.group_account_readonly"
-                         class="alert alert-info mb-0" role="alert"
+                         class="alert alert-info" role="alert"
                          invisible="move_type not in ('in_invoice', 'in_receipt') or not invoice_has_outstanding or payment_state not in ('not_paid', 'partial')">
                         You have <bold><a class="alert-link" href="#outstanding" role="button">outstanding debits</a></bold> for this vendor. You can allocate them to mark this bill as paid.
                     </div>
                     <div groups="account.group_account_invoice,account.group_account_readonly"
-                         class="alert alert-info mb-0" role="alert"
+                         class="alert alert-info" role="alert"
                          invisible="move_type != 'out_refund' or not invoice_has_outstanding or payment_state not in ('not_paid', 'partial')">
                         You have <bold><a class="alert-link" href="#outstanding" role="button">outstanding debits</a></bold> for this customer. You can allocate them to mark this credit note as paid.
                     </div>
                     <div groups="account.group_account_invoice,account.group_account_readonly"
-                         class="alert alert-info mb-0" role="alert"
+                         class="alert alert-info" role="alert"
                          invisible="move_type != 'in_refund' or not invoice_has_outstanding or payment_state not in ('not_paid', 'partial')">
                         You have <bold><a class="alert-link" href="#outstanding" role="button">outstanding credits</a></bold> for this vendor. You can allocate them to mark this credit note as paid.
                     </div>
-                    <div class="alert alert-info mb-0" role="alert"
+                    <div class="alert alert-info" role="alert"
                          invisible="state != 'draft' or auto_post != 'at_date'">
                         This move is configured to be posted automatically at the accounting date: <field name="date" readonly="1"/>.
                     </div>
-                    <div class="alert alert-info mb-0" role="alert"
+                    <div class="alert alert-info" role="alert"
                          invisible="state != 'draft' or auto_post == 'no' or auto_post == 'at_date'">
                          <field name="auto_post" readonly="1"/> auto-posting enabled. Next accounting date: <field name="date" readonly="1"/>.<span invisible="not auto_post_until"> The recurrence will end on <field name="auto_post_until" readonly="1"/> (included).</span>
                     </div>
                     <div groups="account.group_account_invoice,account.group_account_readonly"
-                         class="alert alert-warning mb-0" role="alert"
+                         class="alert alert-warning" role="alert"
                          invisible="partner_credit_warning == ''">
                         <field name="partner_credit_warning"/>
                     </div>
                     <!-- Currency consistency -->
-                    <div class="alert alert-warning mb-0" role="alert"
+                    <div class="alert alert-warning" role="alert"
                          invisible="not display_inactive_currency_warning or move_type not in ('in_invoice', 'in_refund', 'in_receipt')">
                         In order to validate this bill, you must <button class="oe_link" type="object" name="action_activate_currency" style="padding: 0; vertical-align: baseline;">activate the currency of the bill</button>. The journal entries need to be computed by Odoo before being posted in your company's currency.
                     </div>
-                    <div class="alert alert-warning mb-0" role="alert"
+                    <div class="alert alert-warning" role="alert"
                          invisible="not display_inactive_currency_warning or move_type not in ('out_invoice', 'out_refund', 'out_receipt')">
                         In order to validate this invoice, you must <button class="oe_link" type="object" name="action_activate_currency" style="padding: 0; vertical-align: baseline;">activate the currency of the invoice</button>. The journal entries need to be computed by Odoo before being posted in your company's currency.
                     </div>
diff --git a/addons/account/views/partner_view.xml b/addons/account/views/partner_view.xml
index 8b219f91865..3176d3d9f7c 100644
--- a/addons/account/views/partner_view.xml
+++ b/addons/account/views/partner_view.xml
@@ -7,7 +7,7 @@
             <field name="arch" type="xml">
                 <form string="Fiscal Position">
                     <div groups="account.group_account_manager"
-                         class="alert alert-info mb-0"
+                         class="alert alert-info"
                          role="alert"
                          invisible="not foreign_vat_header_mode">
                         <div invisible="foreign_vat_header_mode not in ('templates_found', 'no_template')">
@@ -187,7 +187,7 @@
                     <field name="fiscal_country_codes" invisible="1"/>
                 </xpath>
                 <xpath expr="//sheet" position="before">
-                    <div groups="account.group_account_invoice,account.group_account_readonly" class="alert alert-warning" role="alert" style="margin-bottom:0px;"
+                    <div groups="account.group_account_invoice,account.group_account_readonly" class="alert alert-warning" role="alert"
                          invisible="duplicated_bank_account_partners_count == 0">
                         One or more Bank Accounts set on this partner are also used by other <bold><button class="alert-link" type="object" name="action_view_partner_with_same_bank" role="button" string="Partners" style="padding: 0;vertical-align: baseline;"/></bold>. Please make sure that this is a wanted behavior.
                     </div>
diff --git a/addons/account_edi/views/account_move_views.xml b/addons/account_edi/views/account_move_views.xml
index f1015eb68ad..f8d3b40f481 100644
--- a/addons/account_edi/views/account_move_views.xml
+++ b/addons/account_edi/views/account_move_views.xml
@@ -85,14 +85,14 @@
                 <xpath expr="//header" position="after">
                     <field name="edi_blocking_level" invisible="1" />
                     <field name="edi_error_count" invisible="1" />
-                    <div class="alert alert-info" role="alert" style="margin-bottom:0px;"
+                    <div class="alert alert-info" role="alert"
                         invisible="edi_web_services_to_process in ['', False] or state == 'draft'">
                          <div>The invoice will soon be sent to
                              <field name="edi_web_services_to_process" class="w-auto"/> -
                              <button name="button_process_edi_web_services" type="object" class="oe_link ps-0 text-decoration-underline" string="Process now"/>
                          </div>
                     </div>
-                    <div class="alert alert-danger" role="alert" style="margin-bottom:0px;"
+                    <div class="alert alert-danger" role="alert"
                         invisible="edi_error_count == 0 or edi_blocking_level != 'error'">
                         <div class="o_row">
                             <field name="edi_error_message" />
@@ -100,14 +100,14 @@
                             <button name="action_retry_edi_documents_error" type="object" class="oe_link oe_inline" string="Retry" />
                         </div>
                     </div>
-                    <div class="alert alert-warning" role="alert" style="margin-bottom:0px;"
+                    <div class="alert alert-warning" role="alert"
                         invisible="edi_error_count == 0 or edi_blocking_level != 'warning'">
                         <div class="o_row">
                             <field name="edi_error_message" />
                             <button name="%(account_edi.action_open_edi_documents)d" string="⇒ See errors" type="action" class="oe_link" invisible="edi_error_count == 1" />
                         </div>
                     </div>
-                    <div class="alert alert-info" role="alert" style="margin-bottom:0px;"
+                    <div class="alert alert-info" role="alert"
                         invisible="edi_error_count == 0 or edi_blocking_level != 'info'">
                         <div class="o_row">
                             <field name="edi_error_message" />
diff --git a/addons/crm_iap_mine/views/crm_iap_lead_mining_request_views.xml b/addons/crm_iap_mine/views/crm_iap_lead_mining_request_views.xml
index b97e72df908..2e7fea8cd8d 100644
--- a/addons/crm_iap_mine/views/crm_iap_lead_mining_request_views.xml
+++ b/addons/crm_iap_mine/views/crm_iap_lead_mining_request_views.xml
@@ -10,7 +10,7 @@
                     <button name="action_submit" type="object" string="Retry" class="oe_highlight" invisible="context.get('is_modal') or state != 'error'"/>
                     <field name="state" widget="statusbar" statusbar_visible="draft,done" invisible="context.get('is_modal')"/>
                 </header>
-                <div class="alert alert-danger text-center my-0" role="alert" invisible="not error_type">
+                <div class="alert alert-danger text-center" role="alert" invisible="not error_type">
                     <field name="error_type" invisible="1"/>
                     <field name="lead_type" invisible="1"/>
                     <span invisible="error_type != 'credits'">
diff --git a/addons/hr_work_entry_contract/views/hr_work_entry_views.xml b/addons/hr_work_entry_contract/views/hr_work_entry_views.xml
index bcddd2969f3..fbc82a71df3 100644
--- a/addons/hr_work_entry_contract/views/hr_work_entry_views.xml
+++ b/addons/hr_work_entry_contract/views/hr_work_entry_views.xml
@@ -18,7 +18,7 @@
         <field name="arch" type="xml">
             <xpath expr="//sheet" position="before">
                 <div invisible="state != 'conflict'">
-                    <div class="alert alert-warning mb-0" role="alert" invisible="work_entry_type_id" name="work_entry_undefined">
+                    <div class="alert alert-warning" role="alert" invisible="work_entry_type_id" name="work_entry_undefined">
                         This work entry cannot be validated. The work entry type is undefined.
                     </div>
                 </div>
diff --git a/addons/l10n_ch/views/account_payment_view.xml b/addons/l10n_ch/views/account_payment_view.xml
index 3d40fc267b7..a3499fcb46b 100644
--- a/addons/l10n_ch/views/account_payment_view.xml
+++ b/addons/l10n_ch/views/account_payment_view.xml
@@ -7,7 +7,7 @@
             <field name="inherit_id" ref="account.view_account_payment_form"/>
             <field name="arch" type="xml">
                 <header position="after">
-                    <div class="alert alert-warning" role="alert" style="margin-bottom:0px;" invisible="not l10n_ch_reference_warning_msg">
+                    <div class="alert alert-warning" role="alert" invisible="not l10n_ch_reference_warning_msg">
                         <field name="l10n_ch_reference_warning_msg"/>
                     </div>
                 </header>
diff --git a/addons/l10n_latam_check/views/account_payment_view.xml b/addons/l10n_latam_check/views/account_payment_view.xml
index 044b92b4713..2e366d79757 100644
--- a/addons/l10n_latam_check/views/account_payment_view.xml
+++ b/addons/l10n_latam_check/views/account_payment_view.xml
@@ -64,7 +64,7 @@
         <field name="inherit_id" ref="account_check_printing.view_account_payment_form_inherited" />
         <field name="arch" type="xml">
             <sheet position="before">
-                <div class="alert alert-danger mb-0" role="alert"
+                <div class="alert alert-danger" role="alert"
                         invisible="not l10n_latam_check_warning_msg">
                     <field name="l10n_latam_check_warning_msg" nolabel="1"/>
                 </div>
diff --git a/addons/mail_bot_hr/views/res_users_views.xml b/addons/mail_bot_hr/views/res_users_views.xml
index 62665f61d6b..aeb3f531b3e 100644
--- a/addons/mail_bot_hr/views/res_users_views.xml
+++ b/addons/mail_bot_hr/views/res_users_views.xml
@@ -33,7 +33,7 @@
                    ref="hr.res_users_view_form_profile" />
             <field name="arch" type="xml">
                 <sheet position="before">
-                    <widget name="notification_alert" class="mb-0" />
+                    <widget name="notification_alert" />
                 </sheet>
             </field>
         </record>
diff --git a/addons/pos_online_payment/views/pos_payment_method_views.xml b/addons/pos_online_payment/views/pos_payment_method_views.xml
index d86ac6ff03c..b4de1d21367 100644
--- a/addons/pos_online_payment/views/pos_payment_method_views.xml
+++ b/addons/pos_online_payment/views/pos_payment_method_views.xml
@@ -7,7 +7,7 @@
         <field name="arch" type="xml">
             <xpath expr="//form/sheet" position="before">
                 <field name="has_an_online_payment_provider" invisible="1"/>
-                <div class="alert alert-danger mb-0" role="alert" invisible="not is_online_payment or has_an_online_payment_provider">
+                <div class="alert alert-danger" role="alert" invisible="not is_online_payment or has_an_online_payment_provider">
                     You have not activated any <bold><a type="action" name="%(payment.action_payment_provider)d" class="alert-link" role="button">payment provider</a></bold> to allow online payments.
                 </div>
             </xpath>
diff --git a/addons/sale/views/sale_order_views.xml b/addons/sale/views/sale_order_views.xml
index 07de02fbe58..67b96e3a5af 100644
--- a/addons/sale/views/sale_order_views.xml
+++ b/addons/sale/views/sale_order_views.xml
@@ -282,7 +282,7 @@
                 <field name="state" widget="statusbar" statusbar_visible="draft,sent,sale"/>
             </header>
             <div
-                 class="alert alert-warning mb-0" role="alert"
+                 class="alert alert-warning" role="alert"
                  invisible="partner_credit_warning == ''">
                 <field name="partner_credit_warning"/>
             </div>
diff --git a/addons/sms/wizard/sms_composer_views.xml b/addons/sms/wizard/sms_composer_views.xml
index 27e9a7546d8..31bf71541ec 100644
--- a/addons/sms/wizard/sms_composer_views.xml
+++ b/addons/sms/wizard/sms_composer_views.xml
@@ -6,7 +6,7 @@
         <field name="arch" type="xml">
             <form string="Send an SMS">
                 <!-- Single mode information (invalid number) -->
-                <div colspan="2" class="alert alert-danger text-center mb-0" role="alert"
+                <div class="alert alert-danger text-center" role="alert"
                     invisible="not res_model_description or not comment_single_recipient or recipient_single_valid">
                     <p class="my-0">
                         <strong>Invalid number:</strong>
@@ -17,7 +17,7 @@
                 </div>
 
                 <!-- Mass mode information (res_ids versus active domain) -->
-                <div colspan="2" class="alert alert-info text-center mb-0" role="alert"
+                <div class="alert alert-info text-center" role="alert"
                         invisible="comment_single_recipient or recipient_invalid_count == 0">
                     <p class="my-0">
                         <field class="oe_inline fw-bold" name="recipient_invalid_count"/> out of
diff --git a/addons/survey/views/survey_question_views.xml b/addons/survey/views/survey_question_views.xml
index 40c2f949f55..5dfcac545a2 100644
--- a/addons/survey/views/survey_question_views.xml
+++ b/addons/survey/views/survey_question_views.xml
@@ -8,7 +8,7 @@
         <field name="arch" type="xml">
             <form string="Survey Question" create="false" class="o_survey_question_view_form">
                 <field name="is_placed_before_trigger" invisible="1"/>
-                <div class="alert alert-warning mb-0 text-center" role="alert" invisible="not is_placed_before_trigger">
+                <div class="alert alert-warning text-center" role="alert" invisible="not is_placed_before_trigger">
                     ⚠️ This question is positioned before some or all of its triggers and could be skipped.
                 </div>
                 <field name="is_page" invisible="1"/>
diff --git a/addons/website_slides/views/slide_question_views.xml b/addons/website_slides/views/slide_question_views.xml
index 0b3d9fb7962..94f91501ca6 100644
--- a/addons/website_slides/views/slide_question_views.xml
+++ b/addons/website_slides/views/slide_question_views.xml
@@ -6,7 +6,7 @@
         <field name="arch" type="xml">
             <form string="Quiz">
                 <div invisible="answers_validation_error == ''">
-                    <div class="alert alert-info my-1 mx-2" role="alert" aria-label="Validation error">
+                    <div class="alert alert-info" role="alert" aria-label="Validation error">
                         <i class="fa fa-info-circle" aria-hidden="true"/>
                         <field name="answers_validation_error" class="ms-2" readonly="1"/>
                     </div>
diff --git a/addons/website_slides/wizard/slide_channel_invite_views.xml b/addons/website_slides/wizard/slide_channel_invite_views.xml
index f21a027ccf7..2b010673323 100644
--- a/addons/website_slides/wizard/slide_channel_invite_views.xml
+++ b/addons/website_slides/wizard/slide_channel_invite_views.xml
@@ -6,7 +6,7 @@
             <field name="model">slide.channel.invite</field>
             <field name="arch" type="xml">
                 <form string="Compose Email" class="o_mail_composer_form">
-                    <div class="alert alert-warning text-center mb-0" role="alert" invisible="channel_published or not channel_id">
+                    <div class="alert alert-warning text-center" role="alert" invisible="channel_published or not channel_id">
                         This course is not published. Attendees may not be able to access its contents.
                     </div>
                     <sheet>