[ADD] sale_management: Separate sales menu items from sale app

Purpose
=======

Don't display sales app icon in Odoo homepage when installing ecommerce (only website should be visible)
it's confusing to have sales icon  -> where do I manage my sales? In sales or in website? -> in website

Specfication
============

We need one new modules to add Sales menus to the homepage. Currently they come with "sale". So when installing "website_sale", we get them (because sale and account are dependencies of website_sale). We don't want that anymore. Along with that you need to replace modules in Apps menu:
sales menu items must be in the new sale_management module, no longer in sale

- create new app "sale_management"
- Currently 3 app icons when installing ecommerce (Sales, Invoicing, Website) -> too many icons, where to start? -> GOAL: Only 2 icons > Website, Invoicing
- new module to display Sales Icon (like account_accountant): "sale_management"
- move menu items to sale_management
- sale, sale_management: move app description, rewrite the manifest file
- sale, sale_management: move tour from sale > sale_management
- Changes in some dependency module "sale" > "sale_management" modules: event_sale, mrp_repair, pos_sale, report_intrastat, sale_crm, sale_expense, sale_stock, sale_timesheet, website_quote

Menu items to move 'sale' --> 'sale_management'
===============================================

Sales
	Quotations
        Sales Orders
Invoicing
	Orders to invoice
        Orders to Upsell
Catalog
	Products
        Product Variants
        Pricelists
Reporting
	sales
Configuration
	Settings
        Products -Attributes, Attribute Values, Internal Categories

addons/event_sale/__manifest__.py

@@ -18,7 +18,7 @@ that product, you will be able to choose an existing event of that category and
 when you confirm your sales order it will automatically create a registration for
 this event.
 """,
-    'depends': ['event', 'sale'],
+    'depends': ['event', 'sale_management'],
     'data': [
         'views/event_views.xml',
         'views/product_views.xml',

addons/mrp_repair/__manifest__.py

@@ -21,7 +21,7 @@ The following topics are covered by this module:
     * Repair quotation report
     * Notes for the technician and for the final customer
 """,
-    'depends': ['stock', 'sale', 'account'],
+    'depends': ['stock', 'sale_management', 'account'],
     'website': 'https://www.odoo.com/page/manufacturing',
     'data': [
         'security/ir.model.access.csv',

addons/pos_sale/__manifest__.py

@@ -14,7 +14,7 @@
 
 This module adds a custom Sales Channel for the point of sale to be able to view and manage your point of sale sales with more ease.
 """,
-    'depends': ['point_of_sale', 'sale'],
+    'depends': ['point_of_sale', 'sale_management'],
     'data': [
         'data/pos_sale_data.xml',
         'security/pos_sale_security.xml',

addons/report_intrastat/__manifest__.py

@@ -10,7 +10,7 @@ A module that adds intrastat reports.
 
 This module gives the details of the goods traded between the countries of
 European Union.""",
-    'depends': ['base', 'product', 'delivery', 'stock', 'sale', 'purchase'],
+    'depends': ['base', 'product', 'delivery', 'stock', 'sale_management', 'purchase'],
     'data': [
         'data/report_intrastat_data.xml',
         'report/report_intrastat_invoice_template.xml',

addons/sale/__manifest__.py

@@ -3,49 +3,16 @@
 
 {
     'name': 'Sales',
-    'version': '1.0',
+    'version': '1.1',
     'category': 'Sales',
-    'sequence': 15,
+    'summary': 'Sales internal machinery',
-    'summary': 'Quotations, Sales Orders, Invoicing',
     'description': """
-Manage sales quotations and orders
+This module contains all the common features of Sales Management and eCommerce.
-==================================
-
-This application allows you to manage your sales goals in an effective and efficient manner by keeping track of all sales orders and history.
-
-It handles the full sales workflow:
-
-* **Quotation** -> **Sales order** -> **Invoice**
-
-Preferences (only with Warehouse Management installed)
-------------------------------------------------------
-
-If you also installed the Warehouse Management, you can deal with the following preferences:
-
-* Shipping: Choice of delivery at once or partial delivery
-* Invoicing: choose how invoices will be paid
-* Incoterms: International Commercial terms
-
-You can choose flexible invoicing methods:
-
-* *On Demand*: Invoices are created manually from Sales Orders when needed
-* *On Delivery Order*: Invoices are generated from picking (delivery)
-* *Before Delivery*: A Draft invoice is created and must be paid before delivery
-
-With this module you can personnalize the sales order and invoice report with
-categories, subtotals or page-breaks.
-
-The Dashboard for the Sales Manager will include
-------------------------------------------------
-* My Quotations
-* Monthly Turnover (Graph)
     """,
-    'website': 'https://www.odoo.com/page/crm',
+    'depends': ['sales_team', 'account', 'procurement'],
-    'depends': ['sales_team', 'account', 'procurement', 'web_tour'],
     'data': [
         'data/ir_sequence_data.xml',
         'data/sale_data.xml',
-        'data/sale_tour.xml',
         'report/sale_report.xml',
         'data/mail_template_data.xml',
         'report/sale_report_views.xml',
@@ -68,5 +35,4 @@ The Dashboard for the Sales Manager will include
     'css': ['static/src/css/sale.css'],
     'installable': True,
     'auto_install': False,
-    'application': True,
+}
-}

addons/sale/tests/__init__.py

@@ -3,4 +3,3 @@
 from . import test_sale_to_invoice
 from . import test_sale_order
 from . import test_product_id_change
-from . import test_sale_ui

addons/sale/views/sale_templates.xml

@@ -4,7 +4,6 @@
         <template id="assets_backend" name="project assets" inherit_id="sales_team.assets_backend">
             <xpath expr="." position="inside">
                 <script type="text/javascript" src="/sale/static/src/js/sale.js"></script>
-                <script type="text/javascript" src="/sale/static/src/js/tour.js"></script>
             </xpath>
         </template>
 </odoo>

addons/sale/views/sale_views.xml

@@ -10,6 +10,10 @@
             id="sales_team.menu_base_partner"
             web_icon="sale,static/description/icon.png"/>
 
+        <record id="sales_team.menu_base_partner" model="ir.ui.menu">
+            <field name="active" eval="False"/>
+        </record>
+
         <menuitem
             id= "menu_sales_config"
             parent= "sales_team.menu_sale_config"
@@ -25,7 +29,6 @@
         <menuitem action="product.attribute_action" id="menu_attribute_action" parent="sale.prod_config_main" sequence="1" groups="product.group_product_variant"/>
         <menuitem action="product.variants_action" id="menu_variants_action" parent="sale.prod_config_main" sequence="2" groups="product.group_product_variant"/>
         <menuitem id="menu_products" action="product.product_normal_action_sell" parent="product_menu_catalog" groups="product.group_product_variant" sequence="2"/>
-        <menuitem action="product.product_category_action_form" name="Internal Categories" id="menu_product_category_action_form" parent="sale.prod_config_main" sequence="4"/>
         <menuitem id="next_id_16" name="Units of Measure" parent="sale.prod_config_main" sequence="6" groups="product.group_uom"/>
         <menuitem action="product.product_uom_form_action" id="menu_product_uom_form_action" parent="sale.prod_config_main" sequence="7" groups="product.group_uom"/>
         <menuitem action="product.product_uom_categ_form_action" id="menu_product_uom_categ_form_action" parent="sale.prod_config_main" sequence="8" groups="product.group_uom"/>

addons/sale_crm/__manifest__.py

@@ -17,7 +17,7 @@ We suggest you to install this module, if you installed both the sale and the cr
 modules.
     """,
     'website': 'https://www.odoo.com/page/crm',
-    'depends': ['sale', 'crm'],
+    'depends': ['sale_management', 'crm'],
     'data': [
         'security/ir.model.access.csv',
         'views/partner_views.xml',

addons/sale_expense/__manifest__.py

@@ -15,7 +15,7 @@ This module does not add any feature, despite a few demo data to
 test the features easily.
 """,
     'website': 'https://www.odoo.com/page/warehouse',
-    'depends': ['sale', 'hr_expense'],
+    'depends': ['sale_management', 'hr_expense'],
     'data': [
         'views/product_view.xml',
     ],

addons/sale_management/__init__.py

@@ -0,0 +1,2 @@
+# -*- coding: utf-8 -*-
+# Part of Odoo. See LICENSE file for full copyright and licensing details.

addons/sale_management/__manifest__.py

@@ -0,0 +1,51 @@
+# -*- coding: utf-8 -*-
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+{
+    'name': 'Sales Management',
+    'version': '1.0',
+    'category': 'Sales',
+    'sequence': 15,
+    'summary': 'Quotations, Sales Orders, Invoicing',
+    'description': """
+Manage sales quotations and orders
+==================================
+
+This application allows you to manage your sales goals in an effective and efficient manner by keeping track of all sales orders and history.
+
+It handles the full sales workflow:
+
+* **Quotation** -> **Sales order** -> **Invoice**
+
+Preferences (only with Warehouse Management installed)
+------------------------------------------------------
+
+If you also installed the Warehouse Management, you can deal with the following preferences:
+
+* Shipping: Choice of delivery at once or partial delivery
+* Invoicing: choose how invoices will be paid
+* Incoterms: International Commercial terms
+
+You can choose flexible invoicing methods:
+
+* *On Demand*: Invoices are created manually from Sales Orders when needed
+* *On Delivery Order*: Invoices are generated from picking (delivery)
+* *Before Delivery*: A Draft invoice is created and must be paid before delivery
+
+With this module you can personnalize the sales order and invoice report with
+categories, subtotals or page-breaks.
+
+The Dashboard for the Sales Manager will include
+------------------------------------------------
+* My Quotations
+* Monthly Turnover (Graph)
+    """,
+    'website': 'https://www.odoo.com/page/sales',
+    'depends': ['sale'],
+    'data': [
+        'data/sale_management_tour.xml',
+        'views/sale_management_views.xml',
+        'views/sale_management_templates.xml',
+    ],
+    'application': True,
+}

addons/sale_management/static/src/js/tour.js

@@ -10,7 +10,7 @@ tour.register('sale_tour', {
     url: "/web",
 }, [tour.STEPS.MENU_MORE, {
     trigger: '.o_app[data-menu-xmlid="sales_team.menu_base_partner"], .oe_menu_toggler[data-menu-xmlid="sales_team.menu_base_partner"]',
-    content: _t('Organize your sales activities with the <b>Sales app</b>.'),
+    content: _t('Organize your sales activities with the <b>Sales Management app</b>.'),
     position: 'bottom',
 }, {
     trigger: ".oe_kanban_action_button",

addons/sale_management/tests/__init__.py

@@ -0,0 +1,4 @@
+# -*- coding: utf-8 -*-
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from . import test_sale_ui

addons/sale_management/views/sale_management_templates.xml

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+        <!-- inherits from sales_team.assets_backend to override certain attributes defined in sales_team -->
+        <template id="assets_backend" name="project assets" inherit_id="sales_team.assets_backend">
+            <xpath expr="." position="inside">
+                <script type="text/javascript" src="/sale_management/static/src/js/tour.js"></script>
+            </xpath>
+        </template>
+</odoo>

addons/sale_management/views/sale_management_views.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <record id="sales_team.menu_base_partner" model="ir.ui.menu">
+        <field name="active" eval="True"/>
+    </record>
+</odoo>

addons/sale_margin/__manifest__.py

@@ -12,7 +12,7 @@ This module adds the 'Margin' on sales order.
 This gives the profitability by calculating the difference between the Unit
 Price and Cost Price.
     """,
-    'depends':['sale'],
+    'depends':['sale_management'],
     'demo':['data/sale_margin_demo.xml'],
     'data':['security/ir.model.access.csv','views/sale_margin_view.xml'],
     'uninstall_hook': "uninstall_hook",

addons/sale_stock/__manifest__.py

@@ -25,7 +25,7 @@ You can choose flexible invoicing methods:
 * *Before Delivery*: A Draft invoice is created and must be paid before delivery
 """,
     'website': 'https://www.odoo.com/page/warehouse',
-    'depends': ['sale', 'stock_account'],
+    'depends': ['sale_management', 'stock_account'],
     'data': [
         'security/sale_stock_security.xml',
         'security/ir.model.access.csv',

addons/sale_timesheet/__manifest__.py

@@ -14,7 +14,7 @@ according to the order/contract you work on. This allows to
 have real delivered quantities in sales orders.
 """,
     'website': 'https://www.odoo.com/page/warehouse',
-    'depends': ['sale', 'hr_timesheet'],
+    'depends': ['sale_management', 'hr_timesheet'],
     'data': [
         'data/sale_timesheet_data.xml',
         'views/account_invoice_views.xml',

addons/website_quote/__manifest__.py

@@ -11,7 +11,7 @@ Odoo Sale Quote Roller
 =========================
 
         """,
-    'depends': ['website', 'sale', 'mail', 'payment', 'website_portal_sale', 'website_mail'],
+    'depends': ['website', 'sale_management', 'mail', 'payment', 'website_portal_sale', 'website_mail'],
     'data': [
         'data/website_quote_data.xml',
         'report/sale_order_reports.xml',