From 5d5ff83a07b4efc3be066a668aac6db5eafea441 Mon Sep 17 00:00:00 2001
From: Yolann Sabaux <yosa@odoo.com>
Date: Thu, 8 Sep 2022 13:22:51 +0000
Subject: [PATCH] [FIX] account: fix double display of invoice
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Steps to reproduce:
- Create a vendor bill with payment terms "30% Now, Balance 60 Days"
- register a partial payment and select "Mark as fully paid"
- open the payment and print the payment receipt

Issue:
the lines are printed twice

Addendum:
In Master (post saas-15.3), the `_get_reconciled_invoices_partials` returns a tuple:
https://github.com/odoo/odoo/blob/45e540b624268e65060f6b1aeaf2d87d7220b620/addons/account/models/account_move.py#L2475-L2493

opw-2964480

closes odoo/odoo#99997

X-original-commit: 9525c112e4048583e9b347b5703a416563085421
Signed-off-by: William André (wan) <wan@odoo.com>
---
 addons/account/views/report_payment_receipt_templates.xml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/addons/account/views/report_payment_receipt_templates.xml b/addons/account/views/report_payment_receipt_templates.xml
index 7500f6e8ab1..ca16b233fd4 100644
--- a/addons/account/views/report_payment_receipt_templates.xml
+++ b/addons/account/views/report_payment_receipt_templates.xml
@@ -43,9 +43,10 @@
                         </tr>
                     </thead>
                     <tbody>
-                        <t t-foreach="o.move_id._get_reconciled_invoices_partials()[0]" t-as="rec">
+                        <t t-set="partials" t-value="o.move_id._get_reconciled_invoices_partials()[0]"/>
+                        <t t-set="invoices" t-value="{partial[2].move_id for partial in partials}"/>
+                        <t t-foreach="invoices" t-as="inv">
                             <!-- MOVE -->
-                            <t t-set="inv" t-value="rec[2].move_id"/>
                             <t t-if="inv.move_type != 'entry'">
                                 <tr>
                                     <td><span t-field="inv.invoice_date"/></td>