From 5d44df1c0a4bf56e313645d7265918dce6c2d556 Mon Sep 17 00:00:00 2001
From: Fabien Pinckaers <fp@openerp.com>
Date: Sat, 18 Aug 2018 16:17:50 +0200
Subject: [PATCH] [IMP] *: tabindex on a[type='action'] for BS style fix

---
 .../views/account_journal_dashboard_view.xml     |  2 +-
 addons/gamification/views/challenge.xml          |  2 +-
 .../views/im_livechat_channel_views.xml          |  2 +-
 addons/project/views/project_views.xml           |  2 +-
 addons/sale/static/src/js/tour.js                |  2 +-
 .../views/hr_timesheet_templates.xml             | 16 ++++++++--------
 6 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/addons/account/views/account_journal_dashboard_view.xml b/addons/account/views/account_journal_dashboard_view.xml
index 5ae40689e8d..d146c69739e 100644
--- a/addons/account/views/account_journal_dashboard_view.xml
+++ b/addons/account/views/account_journal_dashboard_view.xml
@@ -328,7 +328,7 @@
                 This is the accounting dashboard
             </p><p>
                 If you have not installed a chart of account, please install one first.<br/>
-               <a type="action" name="%(open_account_charts_modules)d">Browse available countries.</a>
+               <a type="action" name="%(open_account_charts_modules)d" tabindex="-1">Browse available countries.</a>
             </p>
         </field>
     </record>
diff --git a/addons/gamification/views/challenge.xml b/addons/gamification/views/challenge.xml
index 518d6edc7d4..a5f9f4fe2ee 100644
--- a/addons/gamification/views/challenge.xml
+++ b/addons/gamification/views/challenge.xml
@@ -151,7 +151,7 @@
                                <strong>
                                    <h4 class="o_kanban_record_title"><field name="name"/></h4>
                                    <div class="oe_kanban_project_list o_kanban_record_subtitle">
-                                       <a type="action" name="%(goals_from_challenge_act)d" style="margin-right: 10px">
+                                       <a type="action" name="%(goals_from_challenge_act)d" style="margin-right: 10px" tabindex="-1">
                                            <span t-if="record.line_ids.raw_value.length gt 1"><t t-esc="record.line_ids.raw_value.length"/> Goals</span>
                                            <span t-if="record.line_ids.raw_value.length lt 2"><t t-esc="record.line_ids.raw_value.length"/> Goal</span>
                                        </a>
diff --git a/addons/im_livechat/views/im_livechat_channel_views.xml b/addons/im_livechat/views/im_livechat_channel_views.xml
index f4341bea2ef..7bbb2f10668 100644
--- a/addons/im_livechat/views/im_livechat_channel_views.xml
+++ b/addons/im_livechat/views/im_livechat_channel_views.xml
@@ -49,7 +49,7 @@
                                             <t t-esc="record.nbr_channel.raw_value"/> Sessions
                                             <div>
                                                 <t t-if="record.rating_percentage_satisfaction.raw_value &gt; 0">
-                                                    <a type="action" name="%(rating_rating_action_view_livechat_rating)d">
+                                                    <a type="action" name="%(rating_rating_action_view_livechat_rating)d" tabindex="10">
                                                         <i class="fa fa-smile-o text-success" t-if="record.rating_percentage_satisfaction.raw_value &gt;= 70" title="Rating: Great" role="img" aria-label="Happy face"/>
                                                         <i class="fa fa-meh-o text-warning" t-if="record.rating_percentage_satisfaction.raw_value &gt; 30 and record.rating_percentage_satisfaction.raw_value &lt; 70" title="Rating: Okay" role="img" aria-label="Neutral face"/>
                                                         <i class="fa fa-frown-o text-danger" t-if="record.rating_percentage_satisfaction.raw_value &lt;= 30" title="Rating: Bad" role="img" aria-label="Sad face"/>
diff --git a/addons/project/views/project_views.xml b/addons/project/views/project_views.xml
index 5283c85f891..2de90bdd174 100644
--- a/addons/project/views/project_views.xml
+++ b/addons/project/views/project_views.xml
@@ -383,7 +383,7 @@
                 <p class="o_view_nocontent_smiling_face">
                     Create a new project
                 </p><p>
-                    Or <a type="action" name="%(project.ir_actions_server_project_sample)d" tabindex="1000">activate a sample project</a> to play with.
+                    Or <a type="action" name="%(project.ir_actions_server_project_sample)d" tabindex="-1">activate a sample project</a> to play with.
                 </p>
             </field>
         </record>
diff --git a/addons/sale/static/src/js/tour.js b/addons/sale/static/src/js/tour.js
index 275f28903dc..0938127a4b4 100644
--- a/addons/sale/static/src/js/tour.js
+++ b/addons/sale/static/src/js/tour.js
@@ -14,7 +14,7 @@ tour.register('sale_tour', {
     position: 'bottom',
 },  {
     trigger: ".o_list_button_add",
-    extra_trigger: ".o_sale_order",
+    extra_trigger: "div.o_view_controller:not(.o_has_banner) .o_sale_order",
     content: _t("Let's create a new quotation.<br/><i>Note that colored buttons usually point to the next logical actions.</i>"),
     position: "bottom",
 }, {
diff --git a/addons/sale_timesheet/views/hr_timesheet_templates.xml b/addons/sale_timesheet/views/hr_timesheet_templates.xml
index 501fd515449..ff7b2e71163 100644
--- a/addons/sale_timesheet/views/hr_timesheet_templates.xml
+++ b/addons/sale_timesheet/views/hr_timesheet_templates.xml
@@ -44,21 +44,21 @@
                                 <tbody>
                                     <tr>
                                         <th rowspan="6">
-                                            <a type="action" t-att-domain="json.dumps(timesheet_domain)" context="{'pivot_row_groupby': ['date:month'],'pivot_column_groupby': ['timesheet_invoice_type'], 'pivot_measures': ['unit_amount']}">Hours</a>
+                                            <a type="action" t-att-domain="json.dumps(timesheet_domain)" context="{'pivot_row_groupby': ['date:month'],'pivot_column_groupby': ['timesheet_invoice_type'], 'pivot_measures': ['unit_amount']}" tabindex="-1">Hours</a>
                                         </th>
                                         <td class="o_timesheet_plan_dashboard_cell">
                                             <t t-esc="dashboard['hours']['billable_time']" t-options="{'widget': 'float_time'}"/>
                                         </td>
                                         <td>Timesheets</td>
                                         <th rowspan="6">
-                                            <a type="action" t-att-domain="json.dumps(timesheet_domain)" context="{'pivot_row_groupby': ['date:month', 'employee_id'], 'pivot_column_groupby': ['timesheet_invoice_type'],'pivot_measures': ['unit_amount']}">Rates</a>
+                                            <a type="action" t-att-domain="json.dumps(timesheet_domain)" context="{'pivot_row_groupby': ['date:month', 'employee_id'], 'pivot_column_groupby': ['timesheet_invoice_type'],'pivot_measures': ['unit_amount']}" tabindex="-1">Rates</a>
                                         </th>
                                         <td class="o_timesheet_plan_dashboard_cell">
                                             <t t-esc="dashboard['rates']['billable_time']"/> %
                                         </td>
                                         <td>Timesheets</td>
                                         <th rowspan="6">
-                                            <a type="action" t-att-domain="json.dumps(timesheet_domain)" context="{'pivot_row_groupby': ['timesheet_invoice_id'], 'pivot_column_groupby': ['date:month'],'pivot_measures': ['amount']}">Profitability</a>
+                                            <a type="action" t-att-domain="json.dumps(timesheet_domain)" context="{'pivot_row_groupby': ['timesheet_invoice_id'], 'pivot_column_groupby': ['date:month'],'pivot_measures': ['amount']}" tabindex="-1">Profitability</a>
                                         </th>
                                         <td class="o_timesheet_plan_dashboard_cell">
                                             <t t-esc="dashboard['profit']['invoiced']" t-options='{"widget": "monetary", "display_currency": currency}'/>
@@ -161,16 +161,16 @@
                             <t t-if="repartition_employee">
                                 <div class="float-right o_timesheet_plan_badge">
                                     <span class="badge badge-pill o_progress_billable_fixed">
-                                        <a type="action" t-att-domain="json.dumps(timesheet_domain + [('timesheet_invoice_type','=','billable_fixed')])">Billable fixed</a>
+                                        <a type="action" t-att-domain="json.dumps(timesheet_domain + [('timesheet_invoice_type','=','billable_fixed')])" tabindex="-1">Billable fixed</a>
                                     </span>
                                     <span class="badge badge-pill o_progress_billable_time">
-                                        <a type="action" t-att-domain="json.dumps(timesheet_domain + [('timesheet_invoice_type','=','billable_time')])">Billable time</a>
+                                        <a type="action" t-att-domain="json.dumps(timesheet_domain + [('timesheet_invoice_type','=','billable_time')])" tabindex="-1">Billable time</a>
                                     </span>
                                     <span class="badge badge-pill o_progress_non_billable_project">
-                                        <a type="action" t-att-domain="json.dumps(timesheet_domain + [('timesheet_invoice_type','=','non_billable_project')])">No task found</a>
+                                        <a type="action" t-att-domain="json.dumps(timesheet_domain + [('timesheet_invoice_type','=','non_billable_project')])" tabindex="-1">No task found</a>
                                     </span>
                                     <span class="badge badge-pill o_progress_non_billable">
-                                        <a type="action" t-att-domain="json.dumps(timesheet_domain + [('timesheet_invoice_type','=','non_billable')])">Non billable</a>
+                                        <a type="action" t-att-domain="json.dumps(timesheet_domain + [('timesheet_invoice_type','=','non_billable')])" tabindex="-1">Non billable</a>
                                     </span>
                                 </div>
                                 <table class="table">
@@ -178,7 +178,7 @@
                                         <t t-foreach="repartition_employee" t-as="employee_id">
                                             <tr>
                                                 <td style="width: 15%">
-                                                    <a type="action" t-att-domain="json.dumps(timesheet_domain)" t-att-context="{'search_default_employee_id': employee_id}" views="[[0, 'list']]">
+                                                    <a type="action" t-att-domain="json.dumps(timesheet_domain)" t-att-context="{'search_default_employee_id': employee_id}" views="[[0, 'list']]" tabindex="-1">
                                                         <t t-esc="repartition_employee[employee_id]['employee_name']"/>
                                                     </a>
                                                 </td>