From 5bfcf170e5a70ed5e3abd1e07f80aff57685f415 Mon Sep 17 00:00:00 2001
From: Bruno Boi <boi@odoo.com>
Date: Wed, 12 Jan 2022 08:29:26 +0000
Subject: [PATCH] [FIX] web: clear unused option from hotkey service

When adding an hotkey callback through the service's API, the `activeElement` option had no effect at all and in fact was relics of the hotkey service's development process.

It has been removed as it was broken anyway and not tested.

closes odoo/odoo#82625

X-original-commit: 0e3663f28fd012d0fced14759f9f38592014c076
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
---
 .../static/src/core/hotkeys/hotkey_service.js    | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/addons/web/static/src/core/hotkeys/hotkey_service.js b/addons/web/static/src/core/hotkeys/hotkey_service.js
index 7ffcadee786..e4658be6c5a 100644
--- a/addons/web/static/src/core/hotkeys/hotkey_service.js
+++ b/addons/web/static/src/core/hotkeys/hotkey_service.js
@@ -243,7 +243,6 @@ export const hotkeyService = {
          * @param {string} hotkey
          * @param {()=>void} callback
          * @param {Object} options additional options
-         * @param {HTMLElement} [options.activeElement=undefined]
          * @param {boolean} [options.allowRepeat=false]
          *  allow registration to perform multiple times when hotkey is held down
          * @param {boolean} [options.global=false]
@@ -289,19 +288,17 @@ export const hotkeyService = {
             const registration = {
                 hotkey: hotkey.toLowerCase(),
                 callback,
-                activeElement: options.activeElement,
+                activeElement: null,
                 allowRepeat: options && options.allowRepeat,
                 global: options && options.global,
             };
             registrations.set(token, registration);
 
-            if (!registrations.activeElement) {
-                // Due to the way elements are mounted in the DOM by Owl (bottom-to-top),
-                // we need to wait the next micro task tick to set the context owner of the registration.
-                Promise.resolve().then(() => {
-                    registration.activeElement = ui.activeElement;
-                });
-            }
+            // Due to the way elements are mounted in the DOM by Owl (bottom-to-top),
+            // we need to wait the next micro task tick to set the context owner of the registration.
+            Promise.resolve().then(() => {
+                registration.activeElement = ui.activeElement;
+            });
 
             return token;
         }
@@ -321,7 +318,6 @@ export const hotkeyService = {
              * @param {() => void} callback
              * @param {Object} options
              * @param {boolean} [options.allowRepeat=false]
-             * @param {HTMLElement} [options.activeElement=undefined]
              * @param {boolean} [options.global=false]
              * @returns {() => void}
              */