From 5b4c93e3875563b61f6f024efa67dac8e33fe831 Mon Sep 17 00:00:00 2001
From: "Abdelouahab (abla)" <abla@odoo.com>
Date: Thu, 16 Feb 2023 08:55:41 +0000
Subject: [PATCH] [FIX] web : typo `t-if` vs `if`

To reproduce
=============
- on settings upload a custom background on document layout and save it
- open document layout again and try to download the image -> Traceback

Problem
=======
when calling download method we will ask server for a record with `id=false`
which gives an error

Solution
========
download button shouldn't be visible when `record.resId == false`

opw-3138230

closes odoo/odoo#113029

X-original-commit: 2e2cdee563dd645cabe2d361489d6eb17b174a33
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
---
 .../src/views/fields/binary/binary_field.xml      |  2 +-
 .../tests/views/fields/binary_field_tests.js      | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/addons/web/static/src/views/fields/binary/binary_field.xml b/addons/web/static/src/views/fields/binary/binary_field.xml
index 34f298d68c6..ca732d1bbce 100644
--- a/addons/web/static/src/views/fields/binary/binary_field.xml
+++ b/addons/web/static/src/views/fields/binary/binary_field.xml
@@ -9,7 +9,7 @@
                         acceptedFileExtensions="props.acceptedFileExtensions"
                         onUploaded.bind="update"
                     >
-                        <t if="props.record.resId">
+                        <t t-if="props.record.resId">
                             <button
                                 class="btn btn-secondary fa fa-download"
                                 data-tooltip="Download"
diff --git a/addons/web/static/tests/views/fields/binary_field_tests.js b/addons/web/static/tests/views/fields/binary_field_tests.js
index 02f96b86577..1646f41f9ff 100644
--- a/addons/web/static/tests/views/fields/binary_field_tests.js
+++ b/addons/web/static/tests/views/fields/binary_field_tests.js
@@ -415,4 +415,19 @@ QUnit.module("Fields", (hooks) => {
             "93.43 Bytes"
         );
     });
+
+    QUnit.test("Binary field for new record has no download button", async function (assert) {
+        serverData.models.partner.fields.document.default = BINARY_FILE;
+        await makeView({
+            serverData,
+            type: "form",
+            resModel: "partner",
+            arch: `
+                <form>
+                    <field name="document" filename="foo"/>
+                </form>
+            `,
+        });
+        assert.containsNone(target, "button.fa-download");
+    });
 });