From 5b0bcaef3ee45360d9a1a2e2c04e5dfdcacd039a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Mon, 6 Aug 2018 14:48:16 +0200
Subject: [PATCH] [IMP] mass_mailing: improve mass mailing view

Purpose is to prepare addition of UTM statistics in mass mailing view.

Specifications

 * add a hook on stat buttons to add some of them in sub modules;
 * add UTM information in debug mode to be able to see them and update
   them if necessary;

This commit is linked to task ID 1872198 and PR #26188.
---
 .../mass_mailing/views/mass_mailing_views.xml | 31 ++++++++++++++-----
 1 file changed, 24 insertions(+), 7 deletions(-)

diff --git a/addons/mass_mailing/views/mass_mailing_views.xml b/addons/mass_mailing/views/mass_mailing_views.xml
index 5865972e342..3b62b1a34c7 100644
--- a/addons/mass_mailing/views/mass_mailing_views.xml
+++ b/addons/mass_mailing/views/mass_mailing_views.xml
@@ -449,38 +449,44 @@
                         </strong></p>
                     </div>
                     <sheet>
-                        <div class="oe_button_box" name="button_box" attrs="{'invisible': [('state', 'in', ('draft','test'))]}">
+                        <div class="oe_button_box" name="button_box">
                             <button name="%(action_view_mail_mail_statistics_mailing_list)d" type="action"
                                 context="{'search_default_filter_sent': True}"
-                                icon="fa-envelope-o" class="oe_stat_button"
-                                attrs="{'invisible': [('sent', '=', 0)]}" >
+                                icon="fa-envelope-o" class="oe_stat_button o_mass_mailing_button"
+                                attrs="{'invisible': ['&amp;', ('sent', '=', 0), ('state', 'in', ('draft','test'))]}" >
                                 <field name="sent" string="Emails Sent" widget="statinfo"/>
                             </button>
                             <button name="%(action_view_mail_mail_statistics_mailing_list)d"
                                     context="{'search_default_filter_received': True}"
+                                    attrs="{'invisible': [('state', 'in', ('draft','test'))]}"
                                     type="action" class="oe_stat_button">
                                 <field name="received_ratio" string="Received" widget="percentpie"/>
                             </button>
                             <button name="%(action_view_mail_mail_statistics_mailing_list)d"
                                     context="{'search_default_filter_opened': True}"
+                                    attrs="{'invisible': [('state', 'in', ('draft','test'))]}"
                                     type="action" class="oe_stat_button">
                                 <field name="opened_ratio" string="Opened" widget="percentpie"/>
                             </button>
                             <button name="%(action_view_mail_mail_statistics_mailing_list)d"
                                     context="{'search_default_filter_replied': True}"
+                                    attrs="{'invisible': [('state', 'in', ('draft','test'))]}"
                                     type="action" class="oe_stat_button">
                                 <field name="replied_ratio" string="Replied" widget="percentpie"/>
                             </button>
                             <button name="%(action_view_mass_mailing_links_statistics)d"
+                                attrs="{'invisible': [('state', 'in', ('draft','test'))]}"
                                 type="action" class="oe_stat_button">
                                 <field name="clicks_ratio" string="Clicks" widget="percentpie"/>
                             </button>
                             <button name="%(action_view_mail_mail_statistics_mailing_list)d"
                                 context="{'search_default_filter_bounced': True}"
+                                attrs="{'invisible': [('state', 'in', ('draft','test'))]}"
                                 type="action" class="oe_stat_button">
                                 <field name="bounced_ratio" string="Bounced" widget="percentpie"/>
                             </button>
                             <button name="toggle_active" type="object"
+                                    attrs="{'invisible': [('state', 'in', ('draft','test'))]}"
                                     class="oe_stat_button" icon="fa-archive">
                                 <field name="active" widget="boolean_button"
                                     options='{"terminology": "archive"}'/>
@@ -534,10 +540,21 @@
                                         <field name="create_date" readonly="1" attrs="{'invisible': [('create_date', '=', False)]}"/>
                                         <field name="sent_date" readonly="1" attrs="{'invisible': [('sent_date', '=', False)]}"/>
                                     </group>
-                                    <group string="Campaign" groups="mass_mailing.group_mass_mailing_campaign">
-                                        <field name="mass_mailing_campaign_id" string="Campaign"/>
-                                        <label for="contact_ab_pc"/>
-                                        <div>
+                                    <group string="Campaign" groups="base.group_no_one,mass_mailing.group_mass_mailing_campaign">
+                                        <field name="mass_mailing_campaign_id"
+                                            string="Campaign"
+                                            groups="mass_mailing.group_mass_mailing_campaign"/>
+                                        <field name="campaign_id" invisible="1"
+                                            groups="base.group_no_one"/>
+                                        <field name="source_id"
+                                            string="Source"
+                                            required="False"
+                                            groups="base.group_no_one"/>
+                                        <field name="medium_id"
+                                             string="Medium"
+                                            groups="base.group_no_one"/>
+                                        <label for="contact_ab_pc" groups="mass_mailing.group_mass_mailing_campaign"/>
+                                        <div groups="mass_mailing.group_mass_mailing_campaign">
                                             <field name="contact_ab_pc" class="oe_inline"/> %
                                         </div>
                                     </group>