From 5afc1af40e479cf88d22043774bd2b60c4544ce2 Mon Sep 17 00:00:00 2001
From: sesn-odoo <sesn@odoo.com>
Date: Tue, 16 Jan 2024 09:39:24 +0100
Subject: [PATCH] [FIX] l10n_es_pos: handle missing partner in the
 ReceiptHeader template

Currently, if you have Spanish POS installed and create a Cash In/Out,
you are met with an error.

Steps to reproduce
------------------
* install `l10n_es_pos`
* start a POS session
* click on the hamburger button in the top-right corner > Cash In/Out
* add any amount and confirm

You should be met with an error.

Fix
---
At first glance, the original condition:
```
partner?.id !== props.data.simplified_partner_id
```

and the revised condition:
```
partner && partner.id !== props.data.simplified_partner_id
```

might seem equivalent. However, they behave differently when `partner`
is `null` or `undefined`.

In the original condition, the optional chaining operator evaluates
to `undefined`, leading to the following `undefined !==
props.data.simplified_partner_id` (which is most likely true).

The revised condition will shorcircuit when `partner` is falsy, ensuring
that the code only executes when `partner` is a truthy object.

opw-3667287

closes odoo/odoo#148688

Signed-off-by: John Laterre (jol) <jol@odoo.com>
---
 .../src/overrides/components/receipt_header/receipt_header.xml  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/l10n_es_pos/static/src/overrides/components/receipt_header/receipt_header.xml b/addons/l10n_es_pos/static/src/overrides/components/receipt_header/receipt_header.xml
index 7606245f86d..b2a730ea57e 100644
--- a/addons/l10n_es_pos/static/src/overrides/components/receipt_header/receipt_header.xml
+++ b/addons/l10n_es_pos/static/src/overrides/components/receipt_header/receipt_header.xml
@@ -16,7 +16,7 @@
         </xpath>
         <xpath expr="//div[hasclass('pos-receipt-contact')]" position="inside">
             <t t-set="partner" t-value="props.data.partner"/>
-            <t t-if="props.data.is_spanish and partner?.id !== props.data.simplified_partner_id">
+            <t t-if="props.data.is_spanish and partner and partner.id !== props.data.simplified_partner_id">
                 <div>Customer: <t t-esc="partner.name" /></div>
                 <div t-if="partner.vat"><t t-esc="props.data.company.country?.vat_label || 'Tax ID'"/>: <t t-esc="partner.vat" /></div>
                 <div t-if="partner.address" t-esc="partner.address"/>