diff --git a/addons/hr_holidays/i18n/hr_holidays.pot b/addons/hr_holidays/i18n/hr_holidays.pot index 0b639d451af..b9300baa73b 100644 --- a/addons/hr_holidays/i18n/hr_holidays.pot +++ b/addons/hr_holidays/i18n/hr_holidays.pot @@ -2867,6 +2867,12 @@ msgstr "" msgid "Years" msgstr "" +#. module: hr_holidays +#: code:addons/hr_holidays/models/hr_leave_allocation.py:0 +#, python-format +msgid "You can allocate %s only before %s" +msgstr "" + #. module: hr_holidays #: code:addons/hr_holidays/models/hr_leave_allocation.py:0 #, python-format diff --git a/addons/hr_holidays/models/hr_leave_allocation.py b/addons/hr_holidays/models/hr_leave_allocation.py index d1c365fd36a..b9faa215553 100644 --- a/addons/hr_holidays/models/hr_leave_allocation.py +++ b/addons/hr_holidays/models/hr_leave_allocation.py @@ -386,14 +386,12 @@ class HolidaysAllocation(models.Model): @api.constrains('holiday_status_id') def _check_leave_type_validity(self): for allocation in self: - if allocation.holiday_status_id.validity_start and allocation.holiday_status_id.validity_stop: - vstart = allocation.holiday_status_id.validity_start + if allocation.holiday_status_id.validity_stop: vstop = allocation.holiday_status_id.validity_stop today = fields.Date.today() - if vstart > today or vstop < today: - raise ValidationError(_('You can allocate %s only between %s and %s') % (allocation.holiday_status_id.display_name, - allocation.holiday_status_id.validity_start, allocation.holiday_status_id.validity_stop)) + if vstop < today: + raise ValidationError(_('You can allocate %s only before %s') % (allocation.holiday_status_id.display_name, allocation.holiday_status_id.validity_stop)) @api.model def create(self, values):