From 5a6057e5fddef51369108d7dce377391a0e29bcb Mon Sep 17 00:00:00 2001 From: Swapnesh Shah Date: Mon, 29 Mar 2021 18:24:10 +0000 Subject: [PATCH] [FIX] survey: do not always get answer_score Calling `_get_answer_score_values` on each question creation or update is not necessary if value is already provided. Followup of odoo/odoo@0d32ed45aebe2721073580ddae68ec4a8c1499d6 closes odoo/odoo#76223 X-original-commit: c6c7605cdae803aca4f441ef4e622a1b79f17019 Signed-off-by: Thibault Delavallee (tde) --- addons/survey/models/survey_user_input.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/survey/models/survey_user_input.py b/addons/survey/models/survey_user_input.py index 77f797bc21a..8f006543fec 100644 --- a/addons/survey/models/survey_user_input.py +++ b/addons/survey/models/survey_user_input.py @@ -604,8 +604,8 @@ class SurveyUserInputLine(models.Model): @api.model_create_multi def create(self, vals_list): for vals in vals_list: - score_vals = self._get_answer_score_values(vals) if not vals.get('answer_score'): + score_vals = self._get_answer_score_values(vals) vals.update(score_vals) return super(SurveyUserInputLine, self).create(vals_list) @@ -619,8 +619,8 @@ class SurveyUserInputLine(models.Model): 'question_id': line.question_id.id, **vals_copy } - score_vals = self._get_answer_score_values(getter_params, compute_speed_score=False) if not vals_copy.get('answer_score'): + score_vals = self._get_answer_score_values(getter_params, compute_speed_score=False) vals_copy.update(score_vals) res = super(SurveyUserInputLine, line).write(vals_copy) and res return res