From 5a45ed00facef46c3099400ffe5d6dc9b0c47845 Mon Sep 17 00:00:00 2001 From: "Denis Vermylen (dve)" Date: Thu, 10 Nov 2016 09:38:48 +0100 Subject: [PATCH] [FIX] hr_timesheet_sheet: fix sheet employee onchange onchange method was taking an extra argument that isn't given by @api.onchange (was due to a migration error) --- .../hr_timesheet_sheet/models/hr_timesheet_sheet.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/addons/hr_timesheet_sheet/models/hr_timesheet_sheet.py b/addons/hr_timesheet_sheet/models/hr_timesheet_sheet.py index bcb6f6c3de3..8e02fab1604 100644 --- a/addons/hr_timesheet_sheet/models/hr_timesheet_sheet.py +++ b/addons/hr_timesheet_sheet/models/hr_timesheet_sheet.py @@ -87,14 +87,11 @@ class HrTimesheetSheet(models.Model): if any(self.env.cr.fetchall()): raise ValidationError('You cannot have 2 timesheets that overlap!\nPlease use the menu \'My Current Timesheet\' to avoid this problem.') - @api.multi @api.onchange('employee_id') - def onchange_employee_id(self, employee_id): - employee = self.env['hr.employee'].browse(employee_id) - for sheet in self: - if employee_id: - sheet.department_id = employee.department_id - sheet.user_id = employee.user_id + def onchange_employee_id(self): + if self.employee_id: + self.department_id = self.employee_id.department_id + self.user_id = self.employee_id.user_id def copy(self, *args, **argv): raise UserError(_('You cannot duplicate a timesheet.'))