From 5a3ca636456b534bc07a4802f367b94e746382a6 Mon Sep 17 00:00:00 2001 From: Demesmaeker Date: Mon, 11 Jul 2022 10:51:12 +0000 Subject: [PATCH] [FIX] sale_product_configurator: clarifies tour Due to a race condition, the chair product was sometimes added before the js of the product configurator applied the changed attribute. Changing the rhythm of the tour and making it clearer solves the problem for the runbot. As the race condition itself will be solved soon with the owl migration and isn't a problem customers can trigger themselves, it was decided that it stays as is for now. task-2909387 closes odoo/odoo#96041 Signed-off-by: Victor Feyens (vfe) --- .../static/tests/tours/product_configurator_ui.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/addons/test_sale_product_configurators/static/tests/tours/product_configurator_ui.js b/addons/test_sale_product_configurators/static/tests/tours/product_configurator_ui.js index 0626b5586e3..9b4818cb0d0 100644 --- a/addons/test_sale_product_configurators/static/tests/tours/product_configurator_ui.js +++ b/addons/test_sale_product_configurators/static/tests/tours/product_configurator_ui.js @@ -31,16 +31,20 @@ tour.register('sale_product_configurator_tour', { }, { trigger: 'input[data-value_name="Black"]' }, { - trigger: '.btn-primary.disabled', - extra_trigger: '.show .modal-footer' + trigger: '.btn-primary.disabled span:contains("Confirm")', + extra_trigger: '.show .modal-footer' // check confirm is disable and try to do it anyway }, { trigger: 'input[data-value_name="White"]' }, { - trigger: '.btn-primary:not(.disabled)', - extra_trigger: '.show .modal-footer' + trigger: '.btn-primary:not(.disabled) span:contains("Confirm")', + extra_trigger: '.show .modal-footer', + run: function (){} // check confirm is available }, { trigger: 'span:contains("Aluminium"):eq(1)', extra_trigger: '.oe_advanced_configurator_modal', +}, { + trigger: '.js_product:has(strong:contains(Conference Chair)) .js_add', + extra_trigger: '.oe_advanced_configurator_modal', }, { trigger: '.js_product:has(strong:contains(Chair floor protection)) .js_add', extra_trigger: '.oe_advanced_configurator_modal',