From 590fee2ec2a3a100116607b2dd4a3076b9f3e0a7 Mon Sep 17 00:00:00 2001
From: Arnaud Baes <arb@odoo.com>
Date: Wed, 21 Aug 2019 13:12:27 +0000
Subject: [PATCH] [FIX] mrp: Byproduct views

For some reasons (probably missing sheet & group), the form view for the byproduct
wasn't displaying properly. This commit implement and force a cleaner view when
you're coming from the form view of the Bill of Materials.

TaskID: 2057347

closes odoo/odoo#35918

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
---
 addons/mrp/views/mrp_bom_views.xml | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)

diff --git a/addons/mrp/views/mrp_bom_views.xml b/addons/mrp/views/mrp_bom_views.xml
index d95920abd24..7ffb50dde88 100644
--- a/addons/mrp/views/mrp_bom_views.xml
+++ b/addons/mrp/views/mrp_bom_views.xml
@@ -8,6 +8,24 @@
             <field name="context" eval="{'model': 'report.mrp.report_bom_structure'}" />
         </record>
 
+        <record id="mrp_bom_byproduct_form_view" model="ir.ui.view">
+            <field name="name">mrp.bom.byproduct.form</field>
+            <field name="model">mrp.bom.byproduct</field>
+            <field name="arch" type="xml">
+                <form string="Byproduct">
+                    <group>
+                        <field name="product_id"/>
+                        <label for="product_qty"/>
+                        <div class="o_row">
+                            <field name="product_qty"/>
+                            <field name="product_uom_id" groups="uom.group_uom"/>
+                        </div>
+                        <field name="operation_id" groups="mrp.group_mrp_routings" domain="[('routing_id', '=', parent.routing_id)]" options="{'no_quick_create':True,'no_create_edit':True}"/>
+                    </group>
+                </form>
+            </field>
+        </record>
+
         <record id="mrp_bom_form_view" model="ir.ui.view">
             <field name="name">mrp.bom.form</field>
             <field name="model">mrp.bom</field>
@@ -70,19 +88,13 @@
                             </field>
                         </page>
                         <page string="By-products" attrs="{'invisible': [('type','!=','normal')]}" groups="mrp.group_mrp_byproducts">
-                            <field name="byproduct_ids">
+                            <field name="byproduct_ids"  context="{'form_view_ref' : 'mrp.mrp_bom_byproduct_form_view'}">
                                 <tree string="By-products"  editable="top">
                                     <field name="product_id" context="{'default_type': 'product'}"/>
                                     <field name="product_qty"/>
                                     <field name="product_uom_id" groups="uom.group_uom"/>
                                     <field name="operation_id" groups="mrp.group_mrp_routings" domain="[('routing_id', '=', parent.routing_id)]" options="{'no_quick_create':True,'no_create_edit':True}"/>
                                 </tree>
-                                <form string="By-products">
-                                    <field name="product_id"/>
-                                    <field name="product_qty"/>
-                                    <field name="product_uom_id" groups="uom.group_uom"/>
-                                    <field name="operation_id" groups="mrp.group_mrp_routings" domain="[('routing_id', '=', parent.routing_id)]" options="{'no_quick_create':True,'no_create_edit':True}"/>
-                                </form>
                            </field>
                        </page>
                         <page string="Miscellaneous">