From 5642ea4a159ba322dcc948fed7b8e04cbbe75436 Mon Sep 17 00:00:00 2001 From: Kevin Baptiste Date: Thu, 22 Sep 2022 12:10:19 +0000 Subject: [PATCH] [FIX] hr_holidays: fix leave responsible cleanup again The method `_clean_leave_responsible_users` is also called from the write method in hr.employee, however not anyone can remove users from groups. Fix of the fix in odoo/odoo#100591 closes odoo/odoo#100923 X-original-commit: 129e4799b04210f107185ba96b5c1845d943cf8b Signed-off-by: Kevin Baptiste --- addons/hr_holidays/models/hr_employee.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/hr_holidays/models/hr_employee.py b/addons/hr_holidays/models/hr_employee.py index c0e6b050c54..407ba806e8e 100644 --- a/addons/hr_holidays/models/hr_employee.py +++ b/addons/hr_holidays/models/hr_employee.py @@ -217,7 +217,7 @@ class HrEmployeeBase(models.AbstractModel): res = super(HrEmployeeBase, self).write(values) # remove users from the Responsible group if they are no longer leave managers - old_managers._clean_leave_responsible_users() + old_managers.sudo()._clean_leave_responsible_users() if 'parent_id' in values or 'department_id' in values: today_date = fields.Datetime.now()