From 548c2a03a00e4e9c9c43a3162f8e715e01769bf7 Mon Sep 17 00:00:00 2001 From: Meghna Jaswani Date: Fri, 27 Sep 2019 09:16:17 +0000 Subject: [PATCH] [FIX] hr_holidays: Include manager (parent_id) as valid responsible On a time off request, if the 'Time Off Responsible' (leave_manager_id) is not set, then the SUPERUSER_ID is taken as time off responsible for the validation. Before falling back on OdooBot, include the parent_id of the employee, aka the manager, as a valid responsible. closes odoo/odoo#39041 Task: 2072111 X-original-commit: 1e1b9b4089736ee8f7ef374c663376d040372ffd Signed-off-by: Yannick Tivisse (yti) --- addons/hr_holidays/models/hr_leave.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/addons/hr_holidays/models/hr_leave.py b/addons/hr_holidays/models/hr_leave.py index e26f688dacd..c741e86a4cb 100644 --- a/addons/hr_holidays/models/hr_leave.py +++ b/addons/hr_holidays/models/hr_leave.py @@ -917,6 +917,8 @@ class HolidaysRequest(models.Model): if self.validation_type == 'manager' or (self.validation_type == 'both' and self.state == 'confirm'): if self.employee_id.leave_manager_id: responsible = self.employee_id.leave_manager_id + elif self.employee_id.parent_id.user_id: + responsible = self.employee_id.parent_id.user_id elif self.validation_type == 'hr' or (self.validation_type == 'both' and self.state == 'validate1'): if self.holiday_status_id.responsible_id: responsible = self.holiday_status_id.responsible_id