From 542e9640e21568cfa8c06243102183095ff85ecc Mon Sep 17 00:00:00 2001 From: xmo-odoo Date: Thu, 8 Aug 2019 09:43:59 +0000 Subject: [PATCH] [FIX] base: incorrect _on_login_cooldown return _on_login_cooldown is documented as being disabled when "base.login_cooldown_after" is set to 0, however the incorrect return value meant setting this parameter to 0 would put every user on login cooldown permanently. Closes odoo/odoo#35544 reported by @rodrig92 closes odoo/odoo#35555 Signed-off-by: Xavier Morel (xmo) --- odoo/addons/base/models/res_users.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/odoo/addons/base/models/res_users.py b/odoo/addons/base/models/res_users.py index 788016f15ed..9b583027910 100644 --- a/odoo/addons/base/models/res_users.py +++ b/odoo/addons/base/models/res_users.py @@ -834,7 +834,7 @@ class Users(models.Model): cfg = self.env['ir.config_parameter'].sudo() min_failures = int(cfg.get_param('base.login_cooldown_after', 5)) if min_failures == 0: - return True + return False delay = int(cfg.get_param('base.login_cooldown_duration', 60)) return failures >= min_failures and (datetime.datetime.now() - previous) < datetime.timedelta(seconds=delay)