From 539af8a8f04375e100eb55d7c61b25b39c5c31f2 Mon Sep 17 00:00:00 2001
From: Christophe Simonis <chs@openerp.com>
Date: Fri, 14 Dec 2012 16:24:53 +0100
Subject: [PATCH] [FIX] hr_attendance: check the user is an employee by
 checking if (s)he belongs to the "Employee" group

bzr revid: chs@openerp.com-20121214152453-tvtjuvvmefw9qcrp
---
 .../hr_attendance/static/src/js/attendance.js | 34 ++++++-------------
 1 file changed, 11 insertions(+), 23 deletions(-)

diff --git a/addons/hr_attendance/static/src/js/attendance.js b/addons/hr_attendance/static/src/js/attendance.js
index 281822361ef..f030562da9b 100644
--- a/addons/hr_attendance/static/src/js/attendance.js
+++ b/addons/hr_attendance/static/src/js/attendance.js
@@ -72,34 +72,22 @@ openerp.hr_attendance = function (instance) {
     });
 
     instance.web.UserMenu.include({
-
-        is_employee: function() {
-            var self = this;
-            if (_.isUndefined(self._is_employee)) {
-                var Users = new instance.web.Model('res.users');
-                return Users.query(['employee']).filter([['id', '=', self.session.uid]]).all().then(function(records) {
-                    if (_.isEmpty(records)) {
-                        self._is_employee = false;
-                    } else {
-                        self._is_employee = records[0].employee;
-                    }
-                    return self._is_employee;
-                });
-            } else {
-                return $.Deferred().resolve(self._is_employee).promise();
-            }
-        },
-
         do_update: function () {
             this._super();
             var self = this;
             this.update_promise.done(function () {
-                $.when(self.is_employee()).done(function(is_employee) {
-                    if (!is_employee || self.attendanceslider) {
-                        return;
+                if (_.isUndefined(self.attendanceslider)) {
+                    return;
+                }
+                // check current user is an employee
+                var Users = new instance.web.Model('res.users');
+                Users.call('has_group', ['base.group_user']).done(function(is_employee) {
+                    if (is_employee) {
+                        self.attendanceslider = new instance.hr_attendance.AttendanceSlider(self);
+                        self.attendanceslider.prependTo(instance.webclient.$('.oe_systray'));
+                    } else {
+                        self.attendanceslider = null;
                     }
-                    self.attendanceslider = new instance.hr_attendance.AttendanceSlider(self);
-                    self.attendanceslider.prependTo(instance.webclient.$('.oe_systray'));
                 });
             });
         },