From 53786e560d1bb1eda5c54d32a40fdd511a265635 Mon Sep 17 00:00:00 2001 From: Yannick Tivisse Date: Fri, 29 Sep 2017 12:14:43 +0200 Subject: [PATCH] [FIX] web: Propose to update translation only for fields that have a value Purpose ======= If you create a product template with only the name set, the system proposes to update translations for all the translatable fields, even if no value is set for a field. --- addons/web/static/src/js/views/form/form_controller.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/web/static/src/js/views/form/form_controller.js b/addons/web/static/src/js/views/form/form_controller.js index e1a834b2c18..a6248c827a2 100644 --- a/addons/web/static/src/js/views/form/form_controller.js +++ b/addons/web/static/src/js/views/form/form_controller.js @@ -195,10 +195,12 @@ var FormController = BasicController.extend({ // need to make sure changed fields that should be translated // are displayed with an alert var fields = self.renderer.state.fields; + var data = self.renderer.state.data; var alertFields = []; for (var k = 0; k < changedFields.length; k++) { var field = fields[changedFields[k]]; - if (field.translate) { + var fieldData = data[changedFields[k]]; + if (field.translate && fieldData) { alertFields.push(field); } }