From 53281b5dbf8c5e4e18c44356febc2759ed20007b Mon Sep 17 00:00:00 2001 From: Nicolas Martinelli Date: Thu, 20 Oct 2016 15:08:15 +0200 Subject: [PATCH] [FIX] payment_stripe: tracebacks Tracebacks due to key not present in dict, and inconsistent return of the method. --- addons/payment_stripe/models/payment.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/payment_stripe/models/payment.py b/addons/payment_stripe/models/payment.py index 3e9958a78f6..d7a0be07547 100644 --- a/addons/payment_stripe/models/payment.py +++ b/addons/payment_stripe/models/payment.py @@ -168,11 +168,11 @@ class PaymentTokenStripe(models.Model): @api.model def stripe_create(self, values): - res = None + res = {} payment_acquirer = self.env['payment.acquirer'].browse(values.get('acquirer_id')) url_token = 'https://%s/tokens' % payment_acquirer._get_stripe_api_url() url_customer = 'https://%s/customers' % payment_acquirer._get_stripe_api_url() - if values['cc_number']: + if values.get('cc_number'): payment_params = { 'card[number]': values['cc_number'].replace(' ', ''), 'card[exp_month]': str(values['cc_expiry'][:2]), @@ -202,5 +202,5 @@ class PaymentTokenStripe(models.Model): # pop credit card info to info sent to create for field_name in ["cc_number", "cvc", "cc_holder_name", "cc_expiry", "cc_brand"]: - values.pop(field_name) + values.pop(field_name, None) return res