From 524ba8fefcdf449bfc4ccb831cae6d1d990b5c60 Mon Sep 17 00:00:00 2001
From: "Nicolas (vin)" <vin@odoo.com>
Date: Thu, 20 Aug 2020 09:16:45 +0000
Subject: [PATCH] [FIX] account: fix accounts requirement

Since the misc. improvements, the default_account is required on all journals,
while it should not.

Task id #2322643

closes odoo/odoo#56193

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
---
 addons/account/views/account_journal_views.xml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/account/views/account_journal_views.xml b/addons/account/views/account_journal_views.xml
index 7a829dfb76f..373a8fc399c 100644
--- a/addons/account/views/account_journal_views.xml
+++ b/addons/account/views/account_journal_views.xml
@@ -46,11 +46,11 @@
                                         <field name="default_account_type" invisible="1"/>
                                         <!-- Bank -->
                                         <field name="default_account_id" string="Bank Account"
-                                               attrs="{'required': [('id', '!=', False)], 'invisible': [('type', '!=', 'bank')]}"
+                                               attrs="{'required': [('id', '!=', False), ('type', '=', 'bank')], 'invisible': [('type', '!=', 'bank')]}"
                                                groups="account.group_account_readonly"/>
                                         <!-- Cash -->
                                         <field name="default_account_id" string="Cash Account"
-                                               attrs="{'required': [('id', '!=', False)], 'invisible': [('type', '!=', 'cash')]}"
+                                               attrs="{'required': [('id', '!=', False), ('type', '=', 'cash')], 'invisible': [('type', '!=', 'cash')]}"
                                                groups="account.group_account_readonly"/>
 
                                         <field name="suspense_account_id"
@@ -60,11 +60,11 @@
                                         <field name="loss_account_id" attrs="{'invisible': [('type', '!=', 'cash')]}"/>
                                         <!-- Sales -->
                                         <field name="default_account_id" string="Default Income Account"
-                                               attrs="{'required': [('id', '!=', False)], 'invisible': [('type', '!=', 'sale')]}"
+                                               attrs="{'required': [('id', '!=', False), ('type', '=', 'sale')], 'invisible': [('type', '!=', 'sale')]}"
                                                groups="account.group_account_readonly"/>
                                         <!-- Purchase -->
                                         <field name="default_account_id" string="Default Expense Account"
-                                               attrs="{'required': [('id', '!=', False)], 'invisible': [('type', '!=', 'purchase')]}"
+                                               attrs="{'required': [('id', '!=', False), ('type', '=', 'purchase')], 'invisible': [('type', '!=', 'purchase')]}"
                                                groups="account.group_account_readonly"/>
                                         <field name="refund_sequence" attrs="{'invisible': [('type', 'not in', ['sale', 'purchase'])]}"/>
                                         <field name="code"/>