From 51db7cd7b6904d68e5d30fcbd8debf5b5baad792 Mon Sep 17 00:00:00 2001
From: Romeo Fragomeli <rfr@odoo.com>
Date: Fri, 13 Jan 2023 11:43:14 +0000
Subject: [PATCH] [FIX] *: some border aren't apply anymore
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* = digest, hw_posbox_homepage, im_livechat, mass_mailing, web_editor,
website, website_slides_forum

Since the migration of Bootstrap 5 [1], some CSS rules was automatically
converted (`border-left` and `border-right`) when it shouldn't be.
These conversions were made because the CSS rules was embedded in
HTML/XML code and the REGEX for the conversion had no protection for
these cases.

This commit restores the old correct value.

Ref:
[1] odoo/odoo@1fcd098af5fa18e848c66bb83bdceb6ba0308512

closes odoo/odoo#110141

X-original-commit: 0cbf7c00ecc307fc725da345415647828e771bb4
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Signed-off-by: Romeo Fragomeli (rfr) <rfr@odoo.com>
---
 addons/digest/data/digest_data.xml                        | 4 ++--
 addons/hw_posbox_homepage/views/homepage.html             | 4 ++--
 addons/im_livechat/data/mail_templates.xml                | 4 ++--
 addons/mass_mailing/views/snippets_themes.xml             | 8 ++++----
 addons/web_editor/static/src/xml/wysiwyg.xml              | 2 +-
 addons/website/views/snippets/snippets.xml                | 2 +-
 .../views/website_slides_forum_templates.xml              | 6 +++---
 7 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/addons/digest/data/digest_data.xml b/addons/digest/data/digest_data.xml
index 8709bc7b969..956c9ea9d07 100644
--- a/addons/digest/data/digest_data.xml
+++ b/addons/digest/data/digest_data.xml
@@ -263,8 +263,8 @@
                 }
                 #header {
                     padding: 20px 30px 25px 30px;
-                    border-start: 1px solid var(--color-company);
-                    border-end: 1px solid var(--color-company);
+                    border-left: 1px solid var(--color-company);
+                    border-right: 1px solid var(--color-company);
                 }
                 .global_layout {
                     padding: 25px 30px 30px 30px;
diff --git a/addons/hw_posbox_homepage/views/homepage.html b/addons/hw_posbox_homepage/views/homepage.html
index 876b7ee3ed6..70d4c62340f 100644
--- a/addons/hw_posbox_homepage/views/homepage.html
+++ b/addons/hw_posbox_homepage/views/homepage.html
@@ -32,10 +32,10 @@
     }
     table td {
         padding: 8px;
-        border-start: 1px solid #f1f1f1;
+        border-left: 1px solid #f1f1f1;
     }
     table td:first-child {
-        border-start: 0;
+        border-left: 0;
     }
     td.heading {
         font-weight: bold;
diff --git a/addons/im_livechat/data/mail_templates.xml b/addons/im_livechat/data/mail_templates.xml
index b1466120cb0..29d1c5e2032 100644
--- a/addons/im_livechat/data/mail_templates.xml
+++ b/addons/im_livechat/data/mail_templates.xml
@@ -26,8 +26,8 @@
     <!-- CONTENT -->
     <t t-set="top" t-value="'border-top: thin solid #dee2e6;'" />
     <t t-set="bottom" t-value="'border-bottom: thin solid #dee2e6;'" />
-    <t t-set="right" t-value="'border-end: thin solid #dee2e6;'" />
-    <t t-set="left" t-value="'border-start: thin solid #dee2e6;'" />
+    <t t-set="right" t-value="'border-right: thin solid #dee2e6;'" />
+    <t t-set="left" t-value="'border-left: thin solid #dee2e6;'" />
     <tr>
         <td style="padding: 0 50px;">
             <div style="font-size: 13px; padding: 10px 0;">
diff --git a/addons/mass_mailing/views/snippets_themes.xml b/addons/mass_mailing/views/snippets_themes.xml
index 3b9566b9c37..ec7fc13500c 100644
--- a/addons/mass_mailing/views/snippets_themes.xml
+++ b/addons/mass_mailing/views/snippets_themes.xml
@@ -269,7 +269,7 @@
             <we-button title="Solid" data-select-style="solid"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: solid;"/></we-button>
             <we-button title="Dashed" data-select-style="dashed"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: dashed;"/></we-button>
             <we-button title="Dotted" data-select-style="dotted"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: dotted;"/></we-button>
-            <we-button title="Double" data-select-style="double"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: double; border-start: none; border-end: none;"/></we-button>
+            <we-button title="Double" data-select-style="double"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: double; border-left: none; border-right: none;"/></we-button>
         </we-select>
         <we-colorpicker data-dependencies="border_width_opt"
                         t-att-data-apply-to="apply_to"
@@ -733,7 +733,7 @@
                     <div class="o_we_fake_img_item o_we_border_preview" style="border-style: dotted;"/>
                 </we-button>
                 <we-button title="Double" data-customize-css-property="double">
-                    <div class="o_we_fake_img_item o_we_border_preview" style="border-style: double; border-start: none; border-end: none;"/>
+                    <div class="o_we_fake_img_item o_we_border_preview" style="border-style: double; border-left: none; border-right: none;"/>
                 </we-button>
             </we-select>
             <we-colorpicker data-customize-css-property=""
@@ -780,7 +780,7 @@
                     <div class="o_we_fake_img_item o_we_border_preview" style="border-style: dotted;"/>
                 </we-button>
                 <we-button title="Double" data-customize-css-property="double">
-                    <div class="o_we_fake_img_item o_we_border_preview" style="border-style: double; border-start: none; border-end: none;"/>
+                    <div class="o_we_fake_img_item o_we_border_preview" style="border-style: double; border-left: none; border-right: none;"/>
                 </we-button>
             </we-select>
             <we-colorpicker data-customize-css-property=""
@@ -806,7 +806,7 @@
                     <div class="o_we_fake_img_item o_we_border_preview" style="border-style: dotted;"/>
                 </we-button>
                 <we-button title="Double" data-customize-css-property="double">
-                    <div class="o_we_fake_img_item o_we_border_preview" style="border-style: double; border-start: none; border-end: none;"/>
+                    <div class="o_we_fake_img_item o_we_border_preview" style="border-style: double; border-left: none; border-right: none;"/>
                 </we-button>
             </we-select>
             <we-colorpicker data-customize-css-property=""
diff --git a/addons/web_editor/static/src/xml/wysiwyg.xml b/addons/web_editor/static/src/xml/wysiwyg.xml
index 314428cd7ad..2b92ae3a0ac 100644
--- a/addons/web_editor/static/src/xml/wysiwyg.xml
+++ b/addons/web_editor/static/src/xml/wysiwyg.xml
@@ -266,7 +266,7 @@
                             <we-button title="Solid" class="dropdown-item" data-value="solid"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: solid;"/></we-button>
                             <we-button title="Dashed" class="dropdown-item" data-value="dashed"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: dashed;"/></we-button>
                             <we-button title="Dotted" class="dropdown-item" data-value="dotted"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: dotted;"/></we-button>
-                            <we-button title="Double" class="dropdown-item" data-value="double"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: double; border-start: none; border-end: none;"/></we-button>
+                            <we-button title="Double" class="dropdown-item" data-value="double"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: double; border-left: none; border-right: none;"/></we-button>
                         </we-selection-items>
                     </div>
                 </we-select>
diff --git a/addons/website/views/snippets/snippets.xml b/addons/website/views/snippets/snippets.xml
index ea60117c837..8ef685056fc 100644
--- a/addons/website/views/snippets/snippets.xml
+++ b/addons/website/views/snippets/snippets.xml
@@ -268,7 +268,7 @@
             <we-button title="Solid" data-select-style="solid"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: solid;"/></we-button>
             <we-button title="Dashed" data-select-style="dashed"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: dashed;"/></we-button>
             <we-button title="Dotted" data-select-style="dotted"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: dotted;"/></we-button>
-            <we-button title="Double" data-select-style="double"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: double; border-start: none; border-end: none;"/></we-button>
+            <we-button title="Double" data-select-style="double"><div class="o_we_fake_img_item o_we_border_preview" style="border-style: double; border-left: none; border-right: none;"/></we-button>
         </we-select>
         <we-colorpicker data-dependencies="border_width_opt"
                         t-att-data-apply-to="apply_to"
diff --git a/addons/website_slides_forum/views/website_slides_forum_templates.xml b/addons/website_slides_forum/views/website_slides_forum_templates.xml
index 8c958134ad7..2379a21b958 100644
--- a/addons/website_slides_forum/views/website_slides_forum_templates.xml
+++ b/addons/website_slides_forum/views/website_slides_forum_templates.xml
@@ -8,17 +8,17 @@
                         <ul class="nav nav-tabs o_wprofile_nav_tabs mt-0 flex-nowrap" role="tablist" id="profile_extra_info_tablist">
                             <li class="nav-item">
                                 <a t-att-href="'/slides/%s%s' % (slug(forum.slide_channel_id), '/%s' % slug(category) if category else '')"
-                                    t-att-class="'nav-link o_wprofile_navlink'" style="border-start: 0px">
+                                    t-att-class="'nav-link o_wprofile_navlink'" style="border-left: 0px">
                                     <i class="fa fa-home"/> Course</a>
                             </li>
                             <li t-if="forum.slide_channel_id.allow_comment" class="nav-item">
                                 <a t-att-href="'/slides/%s?active_tab=review' % (slug(forum.slide_channel_id))"
-                                    t-att-class="'nav-link o_wprofile_navlink'" style="border-start: 0px">
+                                    t-att-class="'nav-link o_wprofile_navlink'" style="border-left: 0px">
                                     Reviews<t t-if="forum.slide_channel_id.rating_count"> (<t t-esc="forum.slide_channel_id.rating_count"/>)</t>
                                 </a>
                             </li>
                             <li class="nav-item">
-                                <a t-att-href="'/forum/%s' % (slug(forum))" t-att-class="'nav-link active o_wprofile_navlink'" style="border-start: 0px">Forum</a>
+                                <a t-att-href="'/forum/%s' % (slug(forum))" t-att-class="'nav-link active o_wprofile_navlink'" style="border-left: 0px">Forum</a>
                             </li>
                         </ul>
                     </div>