From 507e098d5ac06b35e048af66215055f592bf561b Mon Sep 17 00:00:00 2001 From: Yannick Tivisse Date: Thu, 14 Feb 2019 07:35:25 +0000 Subject: [PATCH] [FIX] hr_payroll: Unlink all benefits at once unlink() invalidates the whole cache, it's an anti-pattern to use it in a loop! Accumulate the records to unlink and do it at the very end. --- addons/hr_payroll/models/hr_benefit.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/addons/hr_payroll/models/hr_benefit.py b/addons/hr_payroll/models/hr_benefit.py index 279a25d1d80..ee4c5883efd 100644 --- a/addons/hr_payroll/models/hr_benefit.py +++ b/addons/hr_payroll/models/hr_benefit.py @@ -178,6 +178,8 @@ class HrBenefit(models.Model): return [(start, end) for start, end in days if start != end] new_benefits = self.env['hr.benefit'] + benefits_to_unlink = self.env['hr.benefit'] + for benefit in self: if benefit.date_start.date() == benefit.date_stop.date(): new_benefits |= benefit @@ -190,7 +192,7 @@ class HrBenefit(models.Model): 'benefit_type_id': benefit.benefit_type_id.id, } benefit_state = benefit.state - benefit.unlink() + benefits_to_unlink |= benefit for start, stop in _split_range_by_day(benefit_start, benefit_stop): values['date_start'] = start.astimezone(pytz.utc) values['date_stop'] = stop.astimezone(pytz.utc) @@ -199,6 +201,7 @@ class HrBenefit(models.Model): new_benefit.state = benefit_state new_benefits |= new_benefit + benefits_to_unlink.unlink() return new_benefits @api.multi