From 4f4fdb2f3520ffc7d3c053fb10e99a87c0bca571 Mon Sep 17 00:00:00 2001 From: Nadal Francisco Garcia Date: Thu, 9 Aug 2018 13:46:57 +0200 Subject: [PATCH] [FIX] stock: fix unreserve In the original commit 19116cc8782ace5a3, `action_assign` was called on all `move_ids`. However, after API conversion, moves are filtered. Closes #25886 opw-1868834 --- addons/stock/models/stock_picking.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/addons/stock/models/stock_picking.py b/addons/stock/models/stock_picking.py index 9a00c2660d4..3e3e99c931e 100644 --- a/addons/stock/models/stock_picking.py +++ b/addons/stock/models/stock_picking.py @@ -784,8 +784,9 @@ class Picking(models.Model): else: moves = self.env['stock.move'].browse(move_ids) if self.env.context.get('no_state_change'): - moves = moves.filtered(lambda m: m.reserved_quant_ids) - moves.do_unreserve() + moves.filtered(lambda m: m.reserved_quant_ids).do_unreserve() + else: + moves.do_unreserve() moves.action_assign(no_prepare=True) @api.multi