From 4e8501c4c96d2e133ddaf25c96be472400bf3920 Mon Sep 17 00:00:00 2001
From: "Andrea Grazioso (agr-odoo)" <agr@odoo.com>
Date: Fri, 29 May 2020 08:26:22 +0000
Subject: [PATCH] [FIX] account: avoid hiding 'Amount Matching'

Go to Reconciliation Models > Invoices Matching Rule
Set the parameter 'Amount Matching'
Set 'Partner Is Set & Matches'
Save
Edit
Unset 'Partner Is Set & Matches'

'Amount Matching' will switch to invisible but is not disabled.
Removing the invisibility check so that the field is always
editable

This also reverts commit 61f1ca63e5dc27e06c855bb09b18bf4897e8ab1f.
Due to a misunderstanding this solution was chosen while the real
intention was to always show the field

opw-2261134

closes odoo/odoo#52264

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
---
 addons/account/models/account_reconcile_model.py       | 5 -----
 addons/account/views/account_reconcile_model_views.xml | 4 ++--
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/addons/account/models/account_reconcile_model.py b/addons/account/models/account_reconcile_model.py
index c93a1f05393..0ad3728a305 100644
--- a/addons/account/models/account_reconcile_model.py
+++ b/addons/account/models/account_reconcile_model.py
@@ -207,11 +207,6 @@ class AccountReconcileModel(models.Model):
         if self.match_total_amount_param < 0 or self.match_total_amount_param > 100:
             self.match_total_amount_param = min(max(0, self.match_total_amount_param), 100)
 
-    @api.onchange('match_partner')
-    def _onchange_match_partner(self):
-        if not self.match_partner:
-            self.match_total_amount = False
-
     ####################################################
     # RECONCILIATION PROCESS
     ####################################################
diff --git a/addons/account/views/account_reconcile_model_views.xml b/addons/account/views/account_reconcile_model_views.xml
index 83d95fbb891..1235522c1f8 100644
--- a/addons/account/views/account_reconcile_model_views.xml
+++ b/addons/account/views/account_reconcile_model_views.xml
@@ -123,8 +123,8 @@
                                 </div>
                                 <field name="match_same_currency" attrs="{'invisible': [('rule_type', '!=', 'invoice_matching')]}"/>
                                 <label for="match_total_amount"
-                                       attrs="{'invisible': ['|', '|', ('rule_type', '!=', 'invoice_matching'), ('match_same_currency', '=', False), ('match_partner', '=', False)]}"/>
-                                <div attrs="{'invisible': ['|', '|', ('rule_type', '!=', 'invoice_matching'), ('match_same_currency', '=', False), ('match_partner', '=', False)]}">
+                                       attrs="{'invisible': ['|', ('rule_type', '!=', 'invoice_matching'), ('match_same_currency', '=', False)]}"/>
+                                <div attrs="{'invisible': ['|', ('rule_type', '!=', 'invoice_matching'), ('match_same_currency', '=', False)]}">
                                     <field name="match_total_amount" class="oe_inline"/>
                                     <field name="match_total_amount_param" class="oe_inline"
                                            attrs="{'invisible': [('match_total_amount', '=', False)]}"/>