From 4e7f4bad71690f6e1002869744c1249cf01e2a9b Mon Sep 17 00:00:00 2001 From: Khushi Vakil Date: Tue, 30 May 2023 11:45:35 +0000 Subject: [PATCH] [FIX] stock_account: prevent AttributeError on clicking valuation button Steps to reproduce ================== - Create purchase order and confirm it. - Receive the product and validate the done quantities. - Click on valuation button. It will raise traceback Error caused by commit: https://github.com/odoo/odoo/commit/a080337d7e8bf515018d9cfb7996461adf717224 closes odoo/odoo#122886 Signed-off-by: Tiffany Chang --- addons/stock_account/models/stock_picking.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/stock_account/models/stock_picking.py b/addons/stock_account/models/stock_picking.py index 03697f3ebf0..a497ed6744b 100644 --- a/addons/stock_account/models/stock_picking.py +++ b/addons/stock_account/models/stock_picking.py @@ -14,7 +14,7 @@ class StockPicking(models.Model): def action_view_stock_valuation_layers(self): self.ensure_one() scraps = self.env['stock.scrap'].search([('picking_id', '=', self.id)]) - domain = [('id', 'in', (self.move_ids + scraps.move_id).stock_valuation_layer_ids.ids)] + domain = [('id', 'in', (self.move_ids + scraps.move_ids).stock_valuation_layer_ids.ids)] action = self.env["ir.actions.actions"]._for_xml_id("stock_account.stock_valuation_layer_action") context = literal_eval(action['context']) context.update(self.env.context)